From patchwork Mon Oct 24 10:06:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 8300 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp358031wru; Mon, 24 Oct 2022 03:07:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4HTPR0v8V/zyshOiIKf7EbEeoO1LpOC8MsMWNijAvo5qk1r8PyBmbvKlxK2D/xqQ+PXqbu X-Received: by 2002:a05:6a00:1ac8:b0:563:7d18:7a15 with SMTP id f8-20020a056a001ac800b005637d187a15mr32722352pfv.59.1666606059696; Mon, 24 Oct 2022 03:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666606059; cv=none; d=google.com; s=arc-20160816; b=Ng0g2USt0GiwX20iaYlA1pzZRPWB8jg/BrH9hxnhCjRZGO8JnayMy/1aj+RYLbMNGC hn1iRBDH+6rjmms+3YcM87W+vQm2hGNPN399mMYcC6We36TaIfqZUeV/KWEvWR13AimY cvN9/H/QP6xAIaoifrbFzmhXx01dHp/uSYAE0lpsE1flACNBozP9an9Y9mBpIP0v6vXE RGnj4ojsseUKagngXb+umdYbt1wO19vTdVQzqk7bRk4RwfjlyhGXG7HV/9tQ/8o9V5el IMpACccxqs7cGPj7JSGw/UAJYO7J31N/O+hx3NGU/Ubf6EhOGAviCxKSIVzq4GawftC6 zkTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+RvRdrAyO13Bx6rogoll9qsinZkX+yDNzbEPsFcJF8w=; b=LkepjQjiQweDQAmKcQfjuXH+r32uGUb9hqcRo0XXOVtECCuZpHHwl0KWo9OQ6xulA0 ByLoFvnFNmNLiRTSiKG1lS8MR2zeY+mDgizIOA4vMPFK5zXNCZvzloYyzkr0sb1ywugD bL47Xqkgqddq51m1YpNAe6lrxXeuUMX14/z5/bU691vvHU3qs2xAxqUKGk+EnOdASwit JqEN5b9oGcEkXou6Shf8mA0vObjby21yojp1LLN6XC+Q3LPqE3vs+sl4jZNdwqhy94Ae 68Q39BhawkTav+btUwHZnrLtT4fJThP/Frr9pA14GTyCRrENZwMj3EFLlc8830dHYl7T mkzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LbR7LDlS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q12-20020a170902eb8c00b00186748fe8e8si10461719plg.188.2022.10.24.03.07.25; Mon, 24 Oct 2022 03:07:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LbR7LDlS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbiJXKHK (ORCPT + 99 others); Mon, 24 Oct 2022 06:07:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbiJXKHI (ORCPT ); Mon, 24 Oct 2022 06:07:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43F466432; Mon, 24 Oct 2022 03:07:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE053611AD; Mon, 24 Oct 2022 10:07:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42B16C433B5; Mon, 24 Oct 2022 10:07:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666606023; bh=Blc66Ko1azHrb/nEVIdVCCRSopdMuUlafRjUOxGWY+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LbR7LDlSZk4rHgr+yNoQRlUV7hPaFX1hrAXCVoGz8fzsx2pt17hAar/UlV9UJ80Zi zRZeun+PffO3YmJaFNzuSq1nyAl6opCGKW7MvyFXqLR4PEHzrYNK7RSQhoteYWzQqL Gtha2VWTuKmWiYfUwdFjcCPk1dmXt99tBM7Vy9lAkqvHg9fWIVSKIrzQ+oTNsWTZta GABXjIvld32EoaoE7vx2j7pL6/5mWlqR6EKFzO+/CUfnIcG7lu+3v2q7oQYiVb73v0 QFkGCM78jfK+e/DNoj307aTKkt1aOLU5rwr97GAxvnE39ADY+JI1C1q1IHLl3vhgk5 YUPqpVvFQAXNw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1omuM2-0005M6-Ob; Mon, 24 Oct 2022 12:06:46 +0200 From: Johan Hovold To: Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset Date: Mon, 24 Oct 2022 12:06:20 +0200 Message-Id: <20221024100632.20549-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221024100632.20549-1-johan+linaro@kernel.org> References: <20221024100632.20549-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747563115521580346?= X-GMAIL-MSGID: =?utf-8?q?1747563115521580346?= The PCS_USB register block lives at an offset of 0x1000 from the PCS region on SC8280XP so add the missing offset to avoid corrupting unrelated registers on runtime suspend. Note that the current binding is broken as it does not describe the PCS_USB region and the PCS register size does not cover PCS_USB and the regions in between. As Linux currently maps full pages, simply adding the offset to driver works until the binding has been fixed. Fixes: c0c7769cdae2 ("phy: qcom-qmp: Add SC8280XP USB3 UNI phy") Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c index d0c433197080..82af28f4a91b 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -1682,6 +1682,7 @@ static const struct qmp_phy_cfg sc8280xp_usb3_uniphy_cfg = { .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = qmp_v4_usb3phy_regs_layout, + .pcs_usb_offset = 0x1000, }; static const struct qmp_phy_cfg qmp_v3_usb3_uniphy_cfg = {