From patchwork Mon Oct 24 08:14:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 8211 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp317527wru; Mon, 24 Oct 2022 01:19:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5sRJRXPEguG8d7ZOD6UxMT9LoXeiRRE5zTRYHFAoa48045P+5LHyffgM4diEV8v4zydbuU X-Received: by 2002:aa7:c504:0:b0:461:122b:882b with SMTP id o4-20020aa7c504000000b00461122b882bmr18548938edq.14.1666599552202; Mon, 24 Oct 2022 01:19:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666599552; cv=none; d=google.com; s=arc-20160816; b=SDMUZg25MZ3lYyKStc48R9R/H8+UGTtkHZIZdyW3D8ilM6TN2CcLiCNN7NISWTf0cp atQ7kKk2tR8ItkjJ/F/tCf8WNoNgoO7xpKnj7AMbx2SZuIH//WUazbDU2BtJQed52fug D+PA/09+6sEy4GFYVytuxLH9Xme+G73lfU0kdU89rJ0FrGoG+k4UU3nxxRqs/dMKrjEk ngmMuXp12vXgEKRkhD1f1+ti7pXXVbA7EQqsM5a0jLy68o1Fp4E1OPcwo/EDkWNGPhsV W6sF5dHgNi8IcArYCiVOode/fgKpM66d4E5nBBFK860ad+1SoB3JJYmjMFF9Y7t8FXCo ab1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=t88/uKwgGYYucGHU2CsWrvPj6Mqlde9rb3qzWXt9rVs=; b=Df+XRYH3+IQ6/R3n5Li6bn7TcJ0yaOKqr0McyXD2jukUi/+4YPcUm/GRTL/abtgXB1 YNT8bmGcyqAF+Gdgl58vROeyLbm6C7cYaB0q0YQkiJFeytFPGXuDs04zwi5ArxDfzqof n3ZeqP/j1UbdwdmycehHbN+V2G8bGbhP7MaV8BxhXaAadhJx2YzC6JW2QvP+9lpPzLhR UFkVGUwFVeQVIudOa1y48R3TD+ISGVjZC+QTyLGCFCMXCMn5gt5gfbOB2MUriovidltA eVrcGLNn+N+OLe1JWYuzuwcE7ngJ3168ne4PTFogO5IuyA0FICDWi47mT36smPp81VYJ 0JLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a056402190e00b0045b965cf1dasi30583649edz.175.2022.10.24.01.18.48; Mon, 24 Oct 2022 01:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbiJXIQB (ORCPT + 99 others); Mon, 24 Oct 2022 04:16:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbiJXIPM (ORCPT ); Mon, 24 Oct 2022 04:15:12 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BCE52E9F7 for ; Mon, 24 Oct 2022 01:14:48 -0700 (PDT) Received: from ipservice-092-217-079-032.092.217.pools.vodafone-ip.de ([92.217.79.32] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1omsbb-0000nk-Ns; Mon, 24 Oct 2022 10:14:43 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 16/17] staging: r8188eu: remove an else branch Date: Mon, 24 Oct 2022 10:14:16 +0200 Message-Id: <20221024081417.66441-17-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221024081417.66441-1-martin@kaiser.cx> References: <20221024081417.66441-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747556292100249014?= X-GMAIL-MSGID: =?utf-8?q?1747556292100249014?= If we go into this else branch, go2asoc is 0. We can continue to the end of the function. The final if condition will be false. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 7120e015d1bd..77402e55f640 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -848,8 +848,6 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram } else if (seq == 4) { if (pmlmeinfo->auth_algo == dot11AuthAlgrthm_Shared) go2asoc = 1; - else - return; } if (go2asoc)