From patchwork Mon Oct 24 08:14:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 8208 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp317421wru; Mon, 24 Oct 2022 01:18:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7fJKTMN7IEJDFoZ8iHU7OmiEDZCXgDANrRVK8tuWbO4N/Nyk4R9w2TA8t0XYtYlc495nBo X-Received: by 2002:a05:6402:5162:b0:457:6ef2:df3 with SMTP id d2-20020a056402516200b004576ef20df3mr29566014ede.128.1666599534090; Mon, 24 Oct 2022 01:18:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666599534; cv=none; d=google.com; s=arc-20160816; b=hsTf0hskV3TvilGKWSduatpH6uqXZ0PYipI1xwKxEPyE5kC/FH4J2IfjsLZafaRYTk HcehYLl/w/XHkPYJ4U4Myr6kigc/xJmq5LZ7E+ZlBtfsBGK3FBtlDIDy4SpqecrgIIJ/ 25GSGJeQnPDaCRoBtYiDOsUsaxodr74cn5tpxX+5oMBvEBrjR17VpRKkJmkoqDUL9kZ8 mmwLkwjg9Z92rWaOXED95YkS99ztnyWJH2c24fHT4oAciiQvWQxd/0K4PDRZ2XiohYqt cFuoslQI7dnCxrcAemctVkouPUyiqy0tWEeUyJ18YPITZLd/84bU7PdlmWXeNSHQ5Ly1 zrPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=utt2NrFZ1LZxcmesTnZABMZ0JXtpIpLRlvGxTMurJXI=; b=BKffyiZW1/E3jlI2PgWYaD1aqBeGMLsWh7aLNX8N8a+sHLGLgKJuYt94+ysOGToKmZ XjUD3IKTixoQPdAOeVTHj1UAUmuMXjOLVfVtgurIug5NCD+ycFUf/FTVLF0CIp3WdacC lrMs5DCpKlKkblr1fD58Vk5K+M2fHVrpElMYHeVFbLe78F6MLWHmuVRHw3LgCY/Ghsh9 8GAtN+bLoxUvB+BRNWOQxuiv6uKI2ArkVRPiYJ3y7HdHrA9qEkJLoZZGT4bbUsNpAlR1 XcNa7W52n5nqmXxGMK5BQS6BSLMWKCutrUPlfGYkPoXSEFY65iE7kdH5SlcjxUVv0clE 1HuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc41-20020a1709078a2900b0078d027ceb41si30773448ejc.857.2022.10.24.01.18.30; Mon, 24 Oct 2022 01:18:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbiJXIPm (ORCPT + 99 others); Mon, 24 Oct 2022 04:15:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbiJXIPA (ORCPT ); Mon, 24 Oct 2022 04:15:00 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72585D13E for ; Mon, 24 Oct 2022 01:14:48 -0700 (PDT) Received: from ipservice-092-217-079-032.092.217.pools.vodafone-ip.de ([92.217.79.32] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1omsbZ-0000nk-UH; Mon, 24 Oct 2022 10:14:41 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 14/17] staging: r8188eu: remove unnecessary else branch Date: Mon, 24 Oct 2022 10:14:14 +0200 Message-Id: <20221024081417.66441-15-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221024081417.66441-1-martin@kaiser.cx> References: <20221024081417.66441-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747556273506062953?= X-GMAIL-MSGID: =?utf-8?q?1747556273506062953?= Remove an else branch in OnAuthClient that is not needed. If we go into the else branch, go2asoc is 0. We can simply continue and the last if condition will be false. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 01fe5019b333..3c6ea9912d7f 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -850,9 +850,6 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram go2asoc = 1; else return; - } else { - /* this is also illegal */ - return; } if (go2asoc) {