From patchwork Mon Oct 24 08:14:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 8206 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp317345wru; Mon, 24 Oct 2022 01:18:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6lgIhw695YYVN/eQNnO9JHxDTgdNoNcguQzWGkYe0079L9+bxgqzKSXjq/GsRJM7j6Tq+B X-Received: by 2002:a05:6402:501a:b0:457:f093:cadb with SMTP id p26-20020a056402501a00b00457f093cadbmr29115750eda.143.1666599521057; Mon, 24 Oct 2022 01:18:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666599521; cv=none; d=google.com; s=arc-20160816; b=xu2QbAbg3VYxrrjz9hURJtbr7VadrXquGolp9GDdtH4L6MuO1Ec2QMoXRGU0ThmvVk 85kWxQiv20cYLQVHjFxDGYEW3ta+paGO3gA3aOiqW0a0qSpHqj7735b/Vjw+FmO2yDW1 +NNKXm0XNtzSBO1RXKJQ5KoMQ0px0CtGOqEVpTTtvMux18JI1zzSKDiiswSod24XcKs3 sSpKFUdw5bKAvYhm7aY07GovFQPYDQTQQDUOLp4fJmpbsX1GafXhxXp5h20excTRw3kN J884tCaO73L/Eq6h3c2sEnbot61rdJEWSbHoVxsUyDqfNHs43iw/Ww6zNTeTelj7WAQo T/XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uCQHSYNh6hjZ0Z6a+rCPVOzyXZS0ejUWFFIYjJMzpSM=; b=PeKCWTiDOif0nZ6x0HlRiM7EQgatNqVF3utKOM8IdA0CbQ9Q/JYltJmu3myX9WrYRN zgCWUzoB8AJ0ua/UB6r+sJ0AveYUsEEIEP4Ugit2c6287bKHmMJKV5QVIZlQZfsgdV7b N64BxTm7ULJJvQoeIqfcVuleo/KxSOS5XjaDZPSjDQhsxYr6vGfgMqwhijfa03pUShUZ rM8Z28SjfF/d2Q/7uXrCVJwqybmPMaWTQSs47mRmjLWq8dRDzTCWOkuqtccNgIJ2IcTr ZkLhG1aP96yej0701lzZ8JWNuvYLUsO25u8tbioqf8Tu0XeIkxikTrdFEHo5VoDUG22i n7HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g19-20020a056402181300b00461d02225a3si1485032edy.448.2022.10.24.01.18.16; Mon, 24 Oct 2022 01:18:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbiJXIPU (ORCPT + 99 others); Mon, 24 Oct 2022 04:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbiJXIOu (ORCPT ); Mon, 24 Oct 2022 04:14:50 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE25517A9E for ; Mon, 24 Oct 2022 01:14:46 -0700 (PDT) Received: from ipservice-092-217-079-032.092.217.pools.vodafone-ip.de ([92.217.79.32] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1omsbZ-0000nk-1l; Mon, 24 Oct 2022 10:14:41 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 13/17] staging: r8188eu: remove unnecessary label Date: Mon, 24 Oct 2022 10:14:13 +0200 Message-Id: <20221024081417.66441-14-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221024081417.66441-1-martin@kaiser.cx> References: <20221024081417.66441-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747556259103671851?= X-GMAIL-MSGID: =?utf-8?q?1747556259103671851?= Remove a label on OnAuthClient that just calls return. We can return directly instead of jumping to this label. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 074c95f76e27..01fe5019b333 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -823,7 +823,7 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram } set_link_timer(pmlmeext, 1); - goto authclnt_fail; + return; } if (seq == 2) { @@ -833,7 +833,7 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); if (!p) - goto authclnt_fail; + return; memcpy((void *)(pmlmeinfo->chg_txt), (void *)(p + 2), len); pmlmeinfo->auth_seq = 3; @@ -849,18 +849,16 @@ static void OnAuthClient(struct adapter *padapter, struct recv_frame *precv_fram if (pmlmeinfo->auth_algo == dot11AuthAlgrthm_Shared) go2asoc = 1; else - goto authclnt_fail; + return; } else { /* this is also illegal */ - goto authclnt_fail; + return; } if (go2asoc) { start_clnt_assoc(padapter); return; } -authclnt_fail: - return; } static void UpdateBrateTbl(u8 *mbrate)