From patchwork Mon Oct 24 07:23:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kunihiko Hayashi X-Patchwork-Id: 8182 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp300985wru; Mon, 24 Oct 2022 00:24:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6mLK0/0nldtS54B6cA3Iousn113BaIY8rqvnmi+QkpO9iJ712RqBGE+BNhIelg5ngwBePl X-Received: by 2002:a63:6b09:0:b0:453:b1f8:bb3b with SMTP id g9-20020a636b09000000b00453b1f8bb3bmr28119473pgc.36.1666596298106; Mon, 24 Oct 2022 00:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666596298; cv=none; d=google.com; s=arc-20160816; b=D+/pSVZkduc2cvAWkgpy5k3EvRQBa1473Xp/yFFLhn7tcjteyUtXNe3JycjqU1QIPk bkNKOBn4Umj4uowyHn+e6M1ndKU4bAOzDoXcqLlG3ILd1vfEeXsvO9+qdQVdiI91lS77 0JC4cvgTmAtPeAaAoifsgmziV6TQCM8JXE6oEyD2GUs7Gr7TBox56aMyS9Wn51bG3SvD HIgl4JzkSJvoJGgHtjwP7RQpVcRRi+KH7HUHYhwp2RvPRsx0HscjNpuVwM3v056WijvO V4uZesAbF4r2e3Q3NneLx9NULx6bRjbgHIlLPC3EqN5yYbTH+VdHHZ3qWcbZ/19I6rUQ hliQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/+G44lkuSkbvKj1a8VBBM2Jne1/RqqhRGO+mC+7bJo4=; b=rWe9KQVFDXLhlfZ1pUJY0ce9bVzKrTIZVtm4+0qd2oxburMPaDFs6fSgX3QCwdQHgo ELJ9iYgarHgDxEZjvq4O8JX05lc4yJ4vSLTWs9UWq+epKh/s4rj7B36Fbn3h5Gnf3PZu MRQsXaP7VnJJjr+Z6a8GbfIfFzo8zfOdNR1NXn/VtOP/plYDgYgYOAGInt55C0BXlrpe Yp8lK3tYrZIV3GJxMFRNA/cSlKErGWDluBIMTXBxi9AGj1Gum05MoRSBzqgXbVz3AbCC vEg0J5HSC9VbBKWmnO1PsfjU1Sp5TC/Dmh0v39iTBF1EYbtrhwPpd9/RunAOsh90ntDF VEpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ij22-20020a170902ab5600b00186ab026646si2146800plb.394.2022.10.24.00.24.45; Mon, 24 Oct 2022 00:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbiJXHXV (ORCPT + 99 others); Mon, 24 Oct 2022 03:23:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbiJXHXT (ORCPT ); Mon, 24 Oct 2022 03:23:19 -0400 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D276E5C9CE; Mon, 24 Oct 2022 00:23:17 -0700 (PDT) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 24 Oct 2022 16:23:17 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 09E2A20584CE; Mon, 24 Oct 2022 16:23:17 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Mon, 24 Oct 2022 16:23:17 +0900 Received: from plum.e01.socionext.com (unknown [10.212.243.119]) by kinkan2.css.socionext.com (Postfix) with ESMTP id B63E5B62A4; Mon, 24 Oct 2022 16:23:16 +0900 (JST) From: Kunihiko Hayashi To: Heiner Kallweit , "David S . Miller " , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunihiko Hayashi Subject: [PATCH net-next] net: ethernet: ave: Remove duplicate phy_resume() calls Date: Mon, 24 Oct 2022 16:23:14 +0900 Message-Id: <20221024072314.24969-1-hayashi.kunihiko@socionext.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747552879850758177?= X-GMAIL-MSGID: =?utf-8?q?1747552879850758177?= ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no need to call phy_resume() explicitly. Remove it. Signed-off-by: Kunihiko Hayashi --- drivers/net/ethernet/socionext/sni_ave.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c index d2c6a5dfdc0e..c6a6c9ed5365 100644 --- a/drivers/net/ethernet/socionext/sni_ave.c +++ b/drivers/net/ethernet/socionext/sni_ave.c @@ -1766,12 +1766,6 @@ static int ave_resume(struct device *dev) wol.wolopts = priv->wolopts; __ave_ethtool_set_wol(ndev, &wol); - if (ndev->phydev) { - ret = phy_resume(ndev->phydev); - if (ret) - return ret; - } - if (netif_running(ndev)) { ret = ave_open(ndev); netif_device_attach(ndev);