From patchwork Sat Oct 22 07:29:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1109906wrr; Sat, 22 Oct 2022 01:50:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4fM9CSGMa53Cw9CpXrEMpn4MTSV1gDxr+h7LNzM4FerUu+GlX1Cix2FjfPXgax9kskcRUs X-Received: by 2002:a05:6402:11c9:b0:45d:aa9b:5193 with SMTP id j9-20020a05640211c900b0045daa9b5193mr21291102edw.372.1666428630196; Sat, 22 Oct 2022 01:50:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666428630; cv=none; d=google.com; s=arc-20160816; b=oGsuuC6HkyxGjXWJXwhe1pjayZ9A/o4+a9jtu/kf+j3dBGAjyAIt/r79jc+SPpayOY oApTJcRROq1rXCuwkuBBn0yv97xEb++SL1hhbuSsz32jKLpfSC38Vnlb5zE7hZW+XnhS 3qQ8uVuTRNCpfOIrAp28jKCYgOt51ZXQ+LhanbIM31lGwrvglXgan39SDi7D28nqhuXf o9ubuHLdNvn02CmubaHJJ1QgSv9NhDld2MmQQpCTGPa5HzQwRw6W+CymyyJGUukl237s GNcyBQ0vQQprqy/z7RgQngvjvA6/FxrMzKLwv4EVjSJC1w43ouQ/1OjW+rt4AipsAjnX vGUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xJQEd/tw+5bihUtS8xNDx4uOCFTFc7l87/IjfaVZf1w=; b=EM3fLPZcip2fAadVNwfdFf0YmePnzudG+a4r56gaSLMAbAsxrN8THUv8XVfzJ+7ESe Te0npbVg2hegKoxwpQE8Wtze5Z5lfPGmQbptUWaODe4i0cN2+bPyN4gReZNZ8WHXN8gw jjIS8q1hYfHE7vre0sdc8erhB+txaqnO7CTw9SEfXj/Jf1/gYFKokC3hUCGt6ip+N9iR sym3tIL+vj+bDGu1moEWojz2/IuOyEPxJVy99huSIJh8YL8/WahRmiKZsRv2kq9LUmm+ 09dbEYXQyVhIrS0gNmvpc/XXw2yUmfSSdqunFZIBzH0szyO+BlLeVw7gvvo7FFb/TPCM 0/fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RofjZBJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds1-20020a170907724100b00782a3405722si19938844ejc.40.2022.10.22.01.50.06; Sat, 22 Oct 2022 01:50:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RofjZBJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234326AbiJVIss (ORCPT + 99 others); Sat, 22 Oct 2022 04:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234643AbiJVIpv (ORCPT ); Sat, 22 Oct 2022 04:45:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909031FCFD; Sat, 22 Oct 2022 01:09:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B589EB82E38; Sat, 22 Oct 2022 08:06:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B2A9C433D6; Sat, 22 Oct 2022 08:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666425985; bh=6vbKmmz0ryFxKZLGyy2yrARzgTOezGzvxGBhsplRrh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RofjZBJG5GTZgE02VIy2nT1mxRHEwDa2T8Dav/Yad8edJc/9ofhHAPOfmsfWAg2tI F6J3R6UN1HXfdJoxdjtR9mW5EhEMrLQgJZIrxJumxP7EviygCbHOfx+tVQEKnKUFFY nks5apVJpA4tCnezT3zWbILFm0QVT9kG7ysVoRB8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, sunghwan jung , Sasha Levin Subject: [PATCH 5.19 680/717] Revert "usb: storage: Add quirk for Samsung Fit flash" Date: Sat, 22 Oct 2022 09:29:19 +0200 Message-Id: <20221022072528.541040261@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747377067411412100?= X-GMAIL-MSGID: =?utf-8?q?1747377067411412100?= From: sunghwan jung [ Upstream commit ad5dbfc123e6ffbbde194e2a4603323e09f741ee ] This reverts commit 86d92f5465958752481269348d474414dccb1552, which fix the timeout issue for "Samsung Fit Flash". But the commit affects not only "Samsung Fit Flash" but also other usb storages that use the same controller and causes severe performance regression. # hdparm -t /dev/sda (without the quirk) Timing buffered disk reads: 622 MB in 3.01 seconds = 206.66 MB/sec # hdparm -t /dev/sda (with the quirk) Timing buffered disk reads: 220 MB in 3.00 seconds = 73.32 MB/sec The commit author mentioned that "Issue was reproduced after device has bad block", so this quirk should be applied when we have the timeout issue with a device that has bad blocks. We revert the commit so that we apply this quirk by adding kernel paramters using a bootloader or other ways when we really need it, without the performance regression with devices that don't have the issue. Signed-off-by: sunghwan jung Link: https://lore.kernel.org/r/20220913114913.3073-1-onenowy@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/unusual_devs.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 4993227ab293..20dcbccb290b 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h @@ -1275,12 +1275,6 @@ UNUSUAL_DEV( 0x090a, 0x1200, 0x0000, 0x9999, USB_SC_RBC, USB_PR_BULK, NULL, 0 ), -UNUSUAL_DEV(0x090c, 0x1000, 0x1100, 0x1100, - "Samsung", - "Flash Drive FIT", - USB_SC_DEVICE, USB_PR_DEVICE, NULL, - US_FL_MAX_SECTORS_64), - /* aeb */ UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff, "Feiya",