From patchwork Sat Oct 22 07:28:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7758 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1117916wrr; Sat, 22 Oct 2022 02:17:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5spWXnfNcFx4IEjgANw6/QEijiqi+ZL0HjrjVfld5kqJppVv2A/cChGhP5y/z5zzCtyzYK X-Received: by 2002:a63:90c1:0:b0:45f:c9a7:15c3 with SMTP id a184-20020a6390c1000000b0045fc9a715c3mr19712396pge.304.1666430260469; Sat, 22 Oct 2022 02:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666430260; cv=none; d=google.com; s=arc-20160816; b=hYALR+Yyp+zOcEVYSJVxm7lHYD2vW6BS2Q/p4Ns0Eg/AThVoezdLkFegofYlvBDQ7p fbvPuxerenIaJXrUTX4Zz2ADGKoRVnZAM6VM2qwNVGgIPRjdzMBBYnmQG+ZM/0fs4wRq yNRbycUNHJSfeRcQzGMOstn4JNoCNmYR5toP1a2ce14wZjaICgURgG3fana/lthY9uqG 0SGnq2l7QuSLevpUjokosZEr/gLQxsDzGAww9PVXLKVBCNNN7+pD2C3LoMK+0pNnYZM9 89+2b4eRozlQdQcMr3++IdOULGs84jd5aA7EKqnrV5hWFGw7IWn8EhnljVXTRrmWsnA4 lXVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LNEljwYhzdpsteIcbSmCMOtcT8vPHf/PaAn/Jkp12Zc=; b=eAEFB+cv9huXBmGeq4aaoFo4VJfMyn1tpRmGdlZHoMK9ipoqg0xCSSYWcHPoADTBJy aPgklNc99ZucETuI1zAHep4Z0gVN2ZWkhysE7HrR8jxaYhSc7YCSa0XrIM/1xAw8k7Tu elCsvWMLM+njS5lH4NQm3MtRxw5Lx3EGxOVUYxBhn+sHFr3IOKIUt0xB67x8+EvriSXr JuFRz0WFCIdhyFp5seusFMUjTdqS1aT9O4SB9FgNRqU3ty3VLIcgGC5Pc7UKDIl5zdsE UTAdDybvM9eUOOydhKljtJzGYpLyiWLgVAAOicxt+bttJJoIB8akgDqQn/B3jgF/SVKo 1ojQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZF9gjC1/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i11-20020a170902cf0b00b0017f580f646fsi30918155plg.304.2022.10.22.02.17.28; Sat, 22 Oct 2022 02:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZF9gjC1/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234812AbiJVI5k (ORCPT + 99 others); Sat, 22 Oct 2022 04:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233790AbiJVI47 (ORCPT ); Sat, 22 Oct 2022 04:56:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF565DEF35; Sat, 22 Oct 2022 01:15:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E95160ADC; Sat, 22 Oct 2022 08:05:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73773C433C1; Sat, 22 Oct 2022 08:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666425957; bh=7La2O9nGNKQitcBs24OLPlXs/LRT+Ca0fFDBGqHMwGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZF9gjC1/emEg6mDqXRWhxHirYxfLBcv+AtcdYWuUEt9eCJklZ3PqVPg0nYsJa2NgF gebTaQ3u7tbe8Ej6r9DGsmlYwpFIPuEFrugNPnpRXS0P0M+MU8IWB8b9VeQPHjJJ+a WDsNjnSf4YaQDtC8gw73G/1wkKYBZGwVHdUpzl64= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daisuke Matsuda , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.19 654/717] RDMA/rxe: Delete error messages triggered by incoming Read requests Date: Sat, 22 Oct 2022 09:28:53 +0200 Message-Id: <20221022072527.341237628@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747378776640698824?= X-GMAIL-MSGID: =?utf-8?q?1747378776640698824?= From: Daisuke Matsuda [ Upstream commit 2c02249fcbfc066bd33e2a7375c7006d4cb367f6 ] An incoming Read request causes multiple Read responses. If a user MR to copy data from is unavailable or responder cannot send a reply, then the error messages can be printed for each response attempt, resulting in message overflow. Link: https://lore.kernel.org/r/20220829071218.1639065-1-matsuda-daisuke@fujitsu.com Signed-off-by: Daisuke Matsuda Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index e38bf958ab48..2ef21a1cba81 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -787,10 +787,8 @@ static enum resp_states read_reply(struct rxe_qp *qp, if (!skb) return RESPST_ERR_RNR; - err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), - payload, RXE_FROM_MR_OBJ); - if (err) - pr_err("Failed copying memory\n"); + rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), + payload, RXE_FROM_MR_OBJ); if (mr) rxe_put(mr); @@ -801,10 +799,8 @@ static enum resp_states read_reply(struct rxe_qp *qp, } err = rxe_xmit_packet(qp, &ack_pkt, skb); - if (err) { - pr_err("Failed sending RDMA reply.\n"); + if (err) return RESPST_ERR_RNR; - } res->read.va += payload; res->read.resid -= payload;