From patchwork Sat Oct 22 07:28:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7637 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1107605wrr; Sat, 22 Oct 2022 01:41:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5/kks9Z/NM5Rt/gOmP3PpMJfIqfR4JdjTG2F55YW6JOSeCDkIqlfMCwHqAtfgMm4gketKf X-Received: by 2002:a17:907:a40f:b0:790:540c:b6e3 with SMTP id sg15-20020a170907a40f00b00790540cb6e3mr19312744ejc.41.1666428089733; Sat, 22 Oct 2022 01:41:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666428089; cv=none; d=google.com; s=arc-20160816; b=FSQSj1aa4f9MQeTqUWcp+deg46O6ONeh5Slqak+iOLpA8D41zTMMoq0Ibi8uHSexg4 1LpR3FinT4TLVBUner5bzwsiHUpG1m8yAmPoc+XGhBzUPqIdNSBOzg+rm59XfBIHzDxr wQ1nqglgepvH3zOR+oRGiD+UJTFjy1ZuXwiv6jzDF8xUgdzPETJPvLegiMS+rg/xAzTw G/nvhJ34I1G0OdbJY9F0glRYBAx4yHF/C+Z51znvHxbBnCnq2ANCEUbmdZzXJCxkxwsD JPMITunUKC5zuzoyeIjlIXJU18Nu/eMD8agpdY/x5Jy3W16Z2VoDuTIC4Gm90+G+qpNP xDVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HKWcpNGSz/qO9umKP5O4jo5RzD6s32hka6dtmUVAbiY=; b=UwZRPa7BK1HNCcJPuDJWRijEfLk08quPATioAjhdjH9CbHoFjjyaf0JxUKa68StuvY Gc50XvlxrsK0e9f7YNU7LFNJRBc81v3AqJK6ZfXurYzRiSwFCfuYiRixjBB5QGnkG1Od APxskD2mqGzEFrSjRj67wsRASQv/ilGSgW5wdRxCTPIB9xR1HrgLvGRBJ4pHjnC6V6MH 8cFTELO+5c2lRSHJxJ5H7yKIP/goPaXFxYDmOTIkyhSUiBU/mOCufqgjMDTaN6SgUNXO taWHnbB9xmKCwNfzEk2u5MAtGsD9N6v0XBbDxfZ6LNWtAxCJgY7nxUE9/t5XfFDoC2cU aBXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HDaaIGj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c14-20020a05640227ce00b0045bd55b122csi25330777ede.332.2022.10.22.01.41.04; Sat, 22 Oct 2022 01:41:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HDaaIGj9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234487AbiJVIin (ORCPT + 99 others); Sat, 22 Oct 2022 04:38:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234242AbiJVIef (ORCPT ); Sat, 22 Oct 2022 04:34:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40B2F2D129C; Sat, 22 Oct 2022 01:04:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D67260B9D; Sat, 22 Oct 2022 08:03:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A96CC433D6; Sat, 22 Oct 2022 08:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666425785; bh=VyRbyK2ww2404bbaV+nZGsh7aEeNQVyazO8tGuaL5hY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HDaaIGj97gHA3SFddkcBpE7XWI02ZOyKyx07JD9uyFZLTAWqYYWSRjtkp2Fzpu7lX 5GNb+nJdYa+9A0HW7GTwXFFsZL2LrgNMyeLlAmduRJ4ZX0SLWeZj/A40r5N8A5j4px HXB9jZaTFYriQhLNresrHHkkTmAA3xCZZ0KFVDSY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Sasha Levin Subject: [PATCH 5.19 615/717] platform/x86: msi-laptop: Change DMI match / alias strings to fix module autoloading Date: Sat, 22 Oct 2022 09:28:14 +0200 Message-Id: <20221022072525.674204494@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747376500489137588?= X-GMAIL-MSGID: =?utf-8?q?1747376500489137588?= From: Hans de Goede [ Upstream commit 2a2565272a3628e45d61625e36ef17af7af4e3de ] On a MSI S270 with Fedora 37 x86_64 / systemd-251.4 the module does not properly autoload. This is likely caused by issues with how systemd-udevd handles the single quote char (') which is part of the sys_vendor / chassis_vendor strings on this laptop. As a workaround remove the single quote char + everything behind it from the sys_vendor + chassis_vendor matches. This fixes the module not autoloading. Link: https://github.com/systemd/systemd/issues/24715 Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20220917210407.647432-1-hdegoede@redhat.com Signed-off-by: Sasha Levin --- drivers/platform/x86/msi-laptop.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c index 3e935303b143..0e804b6c2d24 100644 --- a/drivers/platform/x86/msi-laptop.c +++ b/drivers/platform/x86/msi-laptop.c @@ -596,11 +596,10 @@ static const struct dmi_system_id msi_dmi_table[] __initconst = { { .ident = "MSI S270", .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "MICRO-STAR INT'L CO.,LTD"), + DMI_MATCH(DMI_SYS_VENDOR, "MICRO-STAR INT"), DMI_MATCH(DMI_PRODUCT_NAME, "MS-1013"), DMI_MATCH(DMI_PRODUCT_VERSION, "0131"), - DMI_MATCH(DMI_CHASSIS_VENDOR, - "MICRO-STAR INT'L CO.,LTD") + DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR INT") }, .driver_data = &quirk_old_ec_model, .callback = dmi_check_cb @@ -633,8 +632,7 @@ static const struct dmi_system_id msi_dmi_table[] __initconst = { DMI_MATCH(DMI_SYS_VENDOR, "NOTEBOOK"), DMI_MATCH(DMI_PRODUCT_NAME, "SAM2000"), DMI_MATCH(DMI_PRODUCT_VERSION, "0131"), - DMI_MATCH(DMI_CHASSIS_VENDOR, - "MICRO-STAR INT'L CO.,LTD") + DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR INT") }, .driver_data = &quirk_old_ec_model, .callback = dmi_check_cb