From patchwork Sat Oct 22 07:27:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7614 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1106777wrr; Sat, 22 Oct 2022 01:39:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6FZ/gha17BjBsYpfUZJrRsG83YUPX6UqLGeM4IXpymzbjN97cWXLoHUA9IhKlSy8vz32EE X-Received: by 2002:a17:902:e747:b0:186:7608:1857 with SMTP id p7-20020a170902e74700b0018676081857mr8400261plf.88.1666427941693; Sat, 22 Oct 2022 01:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666427941; cv=none; d=google.com; s=arc-20160816; b=Xxfs0AklAR4CrPXoge3T57kqA/kqVDrGQcIQQkVESLfdjYbgkHPlB2eE7vN4i/ElzG OmIWp5sohiQrpWTRz06yqODWgMgN9t4RhmUjHiljHYqwUvlkoA51ETReZiwSw3G03doW f6V07xo4dFssqQyrosshVeAq7FROghnhipc+V7JdNdC1jIh3w7ULnRCOEC6isXZ4YUG4 +fKZ57j3/tPQNC61knDcnC281naS30eBzzncmsnpSQ/ASBOBis6kjYVkU0p+Cm+itJEy BdI3VJpjnt7M6jGMpiC30AvhuDjd0PLCCPFM0WlLBFsj7gfzi7NaZfUem2lmzG20o53U CixA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=H5cX8WuSS/KD1C+NRdKsD77AFyIr7VAPQQxJd6j+XYA=; b=GEPpWcWSv8hXR2tieFWsGgM6iyfMCeyqpmQmVEtNFZ/tnaPMAfYj08hjUt0+PERJpu UAWUOM2GVKkTGtHAKJLoyrQYfHEFO4qMfYY6Rf2QD4DeCMIWXvoAU0xTlOphWyRx5zoY sFxKab1vAa0jaUJ6IjdMPSiUWMTNYCoiu2FjVOeEEsgXWJElP1d2pykVtkqA3STJQtII mrk46ME6ojBfZ2As9K7olQJ4xS8D6lY/3WPm5wDpTvgbD57I9CDCfIq5RJRSLACiPOh7 neIEZDCxDq974SXxCZRIAsPYdX8aGu6Ygy9XXHWdzt+FGVygVyImY+tuVvm9YKph7ZwF Hn6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eNvZmUvs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k2-20020a170902c40200b001769541146bsi32649436plk.573.2022.10.22.01.38.49; Sat, 22 Oct 2022 01:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eNvZmUvs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234103AbiJVIdn (ORCPT + 99 others); Sat, 22 Oct 2022 04:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234261AbiJVIaO (ORCPT ); Sat, 22 Oct 2022 04:30:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F832D080E; Sat, 22 Oct 2022 01:02:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAC3FB82E33; Sat, 22 Oct 2022 08:00:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A973C433B5; Sat, 22 Oct 2022 08:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666425626; bh=WbRwxcu/QJGq8CcvlsmhWax0qh8D82LhJMYaSGEx+V0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eNvZmUvsrAqH5q6dzY3O/iFOo2pWSDsBr3j7vfGgay/xlDrDDvRl1We1InnBvHNlN EjWKYN8NkzlGDN+CEYGf7DmGH+2BwfT0MMdkzvaaMzknOrcKNXDwcQ0f+5tKeDkJhs uGG791+tz4GxTDJQRXTep+4wmakv7t/V/9t9qre4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dai Ngo , Chuck Lever , Sasha Levin Subject: [PATCH 5.19 555/717] NFSD: fix use-after-free on source server when doing inter-server copy Date: Sat, 22 Oct 2022 09:27:14 +0200 Message-Id: <20221022072522.924524928@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747376345118647130?= X-GMAIL-MSGID: =?utf-8?q?1747376345118647130?= From: Dai Ngo [ Upstream commit 019805fea91599b22dfa62ffb29c022f35abeb06 ] Use-after-free occurred when the laundromat tried to free expired cpntf_state entry on the s2s_cp_stateids list after inter-server copy completed. The sc_cp_list that the expired copy state was inserted on was already freed. When COPY completes, the Linux client normally sends LOCKU(lock_state x), FREE_STATEID(lock_state x) and CLOSE(open_state y) to the source server. The nfs4_put_stid call from nfsd4_free_stateid cleans up the copy state from the s2s_cp_stateids list before freeing the lock state's stid. However, sometimes the CLOSE was sent before the FREE_STATEID request. When this happens, the nfsd4_close_open_stateid call from nfsd4_close frees all lock states on its st_locks list without cleaning up the copy state on the sc_cp_list list. When the time the FREE_STATEID arrives the server returns BAD_STATEID since the lock state was freed. This causes the use-after-free error to occur when the laundromat tries to free the expired cpntf_state. This patch adds a call to nfs4_free_cpntf_statelist in nfsd4_close_open_stateid to clean up the copy state before calling free_ol_stateid_reaplist to free the lock state's stid on the reaplist. Signed-off-by: Dai Ngo Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin --- fs/nfsd/nfs4state.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 9409a0dc1b76..c16646f9db31 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -1049,6 +1049,7 @@ static struct nfs4_ol_stateid * nfs4_alloc_open_stateid(struct nfs4_client *clp) static void nfs4_free_deleg(struct nfs4_stid *stid) { + WARN_ON(!list_empty(&stid->sc_cp_list)); kmem_cache_free(deleg_slab, stid); atomic_long_dec(&num_delegations); } @@ -1463,6 +1464,7 @@ static void nfs4_free_ol_stateid(struct nfs4_stid *stid) release_all_access(stp); if (stp->st_stateowner) nfs4_put_stateowner(stp->st_stateowner); + WARN_ON(!list_empty(&stid->sc_cp_list)); kmem_cache_free(stateid_slab, stid); } @@ -6608,6 +6610,7 @@ static void nfsd4_close_open_stateid(struct nfs4_ol_stateid *s) struct nfs4_client *clp = s->st_stid.sc_client; bool unhashed; LIST_HEAD(reaplist); + struct nfs4_ol_stateid *stp; spin_lock(&clp->cl_lock); unhashed = unhash_open_stateid(s, &reaplist); @@ -6616,6 +6619,8 @@ static void nfsd4_close_open_stateid(struct nfs4_ol_stateid *s) if (unhashed) put_ol_stateid_locked(s, &reaplist); spin_unlock(&clp->cl_lock); + list_for_each_entry(stp, &reaplist, st_locks) + nfs4_free_cpntf_statelist(clp->net, &stp->st_stid); free_ol_stateid_reaplist(&reaplist); } else { spin_unlock(&clp->cl_lock);