From patchwork Sat Oct 22 07:25:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7840 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1153139wrr; Sat, 22 Oct 2022 04:04:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Ema2Met0y8TJchZT1iu9cBZTUAcmw2ef5jc67kyvcy4WHOYRDuFrYSFnpMv06gb3LyRm9 X-Received: by 2002:a17:906:fe04:b0:777:b13d:30a6 with SMTP id wy4-20020a170906fe0400b00777b13d30a6mr19278796ejb.248.1666436691156; Sat, 22 Oct 2022 04:04:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666436691; cv=none; d=google.com; s=arc-20160816; b=agkiZ/JFRBqDOWXFPQx8bm6ZlIS3i2puR5YfFy5yQsIcFLmk/OGGJdYmZZvTtvz+7B iPmYSB0EyMB7VbCtvXwsE64c67hazE7Rk8mq1Phjz2Ha9boxBK9B/TQEn69jAFHBQQ6a ETuTnKjz8x/RYkNSA60zqpXyxGYzQLze1vyzNqeGmDkZV0GQX3DXGtG2tfGNi1ObJsAY JNrcE7sHFmMQ0aLtYaymSuaGkwKuIxnzEJcqiITk8j4wUH1cl10qnfqPwnh9TM/+PBWQ G7h4UwXmjznXsI/tqyKeE3bizaZSynuLJlaxm24OPrwG5xzgp1FnfKLLpM0xryVsXLZP iZoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DaTEd/xT6UTzO3OgvZc60DTCtjxGPPhX+9N6vYoS20k=; b=nq0cYj264+eW7CnXOx8S831x9Fj9UbGW5Z4PYorXDAL613+xBkzGeibanfi3Pon8gt HyvKw8NTjKbGn0IP4m6agTwnnhHFsxmZxyvNpSXtxGNFcYv0KGvRgxYnDfU5E8p9BhgN uBTBBLLRURjzluBEkcNfW2hot49J8JSHK0bLvNtCcyPIFeFDX3bmyNIy4i0xLqvDsOlG vO2a/QhpfRtsHqvdi5V+iXZtAZGsC+s8L+DeKnRMEP3Rt2x/nl2PdZxZmk0Hph3QyT2e n33IGbQWmZ5OxcjTa1v7a2Cljoau5vTsuW30/+M/5LeJC5lSiYJGnmrdw3UD/u6dvW8C 31Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="qi//daVm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020a1709066dd400b0078d9b2facaesi20019447ejt.339.2022.10.22.04.04.18; Sat, 22 Oct 2022 04:04:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="qi//daVm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiJVK6x (ORCPT + 99 others); Sat, 22 Oct 2022 06:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbiJVK6d (ORCPT ); Sat, 22 Oct 2022 06:58:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5517072291; Sat, 22 Oct 2022 03:17:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 40F98B82E2B; Sat, 22 Oct 2022 07:55:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FE4AC43470; Sat, 22 Oct 2022 07:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666425329; bh=TOSu46mciuE/L6gJio2Q140JlgyZxiLGuzWYQlMx65Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qi//daVm1AIkIkt0QJnPGef7yb1ioLl2SoMfPdbboftKN8mqfiPAO+cWOoEIsT0g4 cyA7qcAArguFmI4l/TE9WXGTVLRDg5pD56j0SjgxjFxdYjae6e0e+J0Dn7J/PHHkxx 4y5gIgNGA9BqE2biG6ihrTA3Qd13P7y2n9YBonoU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 5.19 466/717] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Sat, 22 Oct 2022 09:25:45 +0200 Message-Id: <20221022072518.916284151@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747385519894351655?= X-GMAIL-MSGID: =?utf-8?q?1747385519894351655?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 5e8c94e008ed..85d070bce0e2 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -77,6 +77,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }