From patchwork Sat Oct 22 07:23:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7373 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1096554wrr; Sat, 22 Oct 2022 01:05:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7gKx8oXqp7E20MF4uhB4gEzeKT1d04D8briohUFjTRuJuhXbePRKjCPzYqb7yrq/M+u8ox X-Received: by 2002:aa7:88c5:0:b0:565:eca5:c289 with SMTP id k5-20020aa788c5000000b00565eca5c289mr23788185pff.72.1666425926020; Sat, 22 Oct 2022 01:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666425926; cv=none; d=google.com; s=arc-20160816; b=w9V0JaAeBKfEY09ZIlVbk9sHSJqNCpyEWbwMaIymLVTHm2rvPkbFqPM2xvZVJcODNr csern1r38qpaWUzPgtnASpvqSZK8oSdFttOpOH1Vy6CH82XK1Rz0wKME7zy0BuUfr3BH HTABJszwOEB7jrJGoCqfPOk4RkF3g1OQwT/mHSrH8VqHptCkRC+n0ZHUJevQJD4AvUY7 yjVoEU+5s+RDRxuCqhb9izjKXvZvrp7rxLObdmghEy/t1KfMGbAKRt7zl/0sk9+UH7w9 FS/u5UcuLSPUwxSne6THkdY4uG6JKFqAsU8JaoQvqsiQAHExIrN8QccUTgEPxyVV6V24 rQEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OGSBkxhbWKJGXaAwt6r+yIV6B3wO9auTVMUwVgGEWYw=; b=ZWx+VMeVxsH77tV5ooAA+XnH7CoQ8uumIAFK1nsbwhxTdiVZUukXOYwevDxV/HtuaS XIZH6+qg6OmMnU/3JB7Pbb5Oq2HEI5sNaOhrBn32w3l1VALR1ceGMdJ9R9hvzxVpPZcZ qJ+Zvg2tseVgBC0vG0rQdQh/y3IMZ4K9h6dkVsVPFtBSM8rWUX/otN0mjc83VBO7MPd7 965e6b/1TxwS7oTLcjJoJOYmXSCZkgYt774HXypVhnV3Ftrdc04TzQ0TlFV1/K0YLg4l nNcBJsE+0SfTwYlYfy2Zg5v3Psrhy0bQX39drDbd/3NQLLoSqKSokUT+fQo81vG47Tva 1GkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=H1i6NkRd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mw4-20020a17090b4d0400b0020da3876a77si10072850pjb.119.2022.10.22.01.05.13; Sat, 22 Oct 2022 01:05:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=H1i6NkRd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232241AbiJVID5 (ORCPT + 99 others); Sat, 22 Oct 2022 04:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232308AbiJVH5D (ORCPT ); Sat, 22 Oct 2022 03:57:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747AA2615; Sat, 22 Oct 2022 00:48:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2DD8EB82E11; Sat, 22 Oct 2022 07:47:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CE25C433D6; Sat, 22 Oct 2022 07:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424854; bh=igiYCLXYnX3P4qwWb2eb2cyMpJjh/OfOIwrUzVmttEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H1i6NkRdpNAjfca8jjojXA1hQzvVWkJZJDirwO5mzVd/C6IjUMtSV/TLi1FwSekYk 7cXrwpwIZVIw5E4gAV124MKNxLb4pkQzQosu0mcPfwheL8FZgqdqW62gPS29Ng6XG/ lgGHUA66RAP+8Gz+4qae8TiNPE5+ZCTwYDZkZiwE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chen-Yu Tsai , Neil Armstrong , Robert Foss , Sasha Levin Subject: [PATCH 5.19 302/717] drm/bridge: parade-ps8640: Fix regulator supply order Date: Sat, 22 Oct 2022 09:23:01 +0200 Message-Id: <20221022072506.305012646@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747374231661730522?= X-GMAIL-MSGID: =?utf-8?q?1747374231661730522?= From: Chen-Yu Tsai [ Upstream commit fc94224c2e0ae8d83ac511a3ef4962178505469d ] The datasheet says that VDD12 must be enabled and at full voltage before VDD33 is enabled. Reorder the bulk regulator supply names so that VDD12 is enabled before VDD33. Any enable ramp delays should be handled by setting proper constraints on the regulators. Fixes: bc1aee7fc8f0 ("drm/bridge: Add I2C based driver for ps8640 bridge") Signed-off-by: Chen-Yu Tsai Reviewed-by: Neil Armstrong Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20220721092258.3397461-1-wenst@chromium.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index edb939b14c04..38dcc606b499 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -596,8 +596,8 @@ static int ps8640_probe(struct i2c_client *client) if (!ps_bridge) return -ENOMEM; - ps_bridge->supplies[0].supply = "vdd33"; - ps_bridge->supplies[1].supply = "vdd12"; + ps_bridge->supplies[0].supply = "vdd12"; + ps_bridge->supplies[1].supply = "vdd33"; ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies), ps_bridge->supplies); if (ret)