From patchwork Sat Oct 22 07:22:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7340 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1095011wrr; Sat, 22 Oct 2022 01:01:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4dt05Qk+I4QhlfyueZvehUk8rR2BwpprFkoL+/Fyu0Rnhhwu3SlOnzZzYclRfZJo5zUIqe X-Received: by 2002:a63:5551:0:b0:461:8bc8:6bdf with SMTP id f17-20020a635551000000b004618bc86bdfmr19424489pgm.453.1666425690121; Sat, 22 Oct 2022 01:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666425690; cv=none; d=google.com; s=arc-20160816; b=dZNQTwY/7rHQ+udbe2d0yytM/sbEJPhXYgdUgTKc8mcAprY4TordVf6yGtPVxXQ3e9 +MwAIZyU6AY9y0GEx14KQiKW0gidvwjpLNCSq5DnDb9N5aFXrWeTpXJqS+4LAJZOJBPs CcnvM0JKUy57AqPJo+69Hzecmzp4MhU+18tajbs5HXtTszww3YQBmQgqwb0gMTa85C1O KA4a5OrWJT62V805ghFcOGcEhCPhScPE/IJ5f2Sx1a4fTCgjrYXHORzyVoabzw4aDGEj gBOcJbZ84zzb8u6eebD1wgeN0YxSJ88TmKBcT7PsgXe/lNNHF4KxfBnxvQnqaWM6Qgmh kPFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hoUERXjGNd2o8CnyFPbMc5XcSFDIi9YpZZfdtR5QjIY=; b=QVeJpajFCkmCoUGadOYjlobDYT9UR1g6UTElOGC4MP21SCGg8GxnJdBvZLq81q2o1E BQOA8urUJbgY42fiUop3G6O1JKfLKbkvDrkeazqrDZM3h9mpXeDpIlQU6SF2uZCPCCye QW1gHZ1k1mDuLQPKwh70OYQ8yXUvxysTaJ5UNAgbNn85i5/3LoYZo7/UjTAIro/R0RUR JZeTM/IhCHRCx4vTlCLrDMzN3AJst2ylqYGNL8T0U6gD299YFbM7yOdxP23uy+TpBIHK 23lI+6d5tc7JkDHUmFBX2kLE7ovnbQxoxf4Kcea/p4kaWOBfu6to99IFRj6rsWRLiK0l A0sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sF6wYgmU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020a056a0010cf00b005589b36444esi29938543pfu.87.2022.10.22.01.01.17; Sat, 22 Oct 2022 01:01:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sF6wYgmU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232479AbiJVH7D (ORCPT + 99 others); Sat, 22 Oct 2022 03:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbiJVHyH (ORCPT ); Sat, 22 Oct 2022 03:54:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BDCE66F35; Sat, 22 Oct 2022 00:47:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDA2360B09; Sat, 22 Oct 2022 07:46:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E731C433C1; Sat, 22 Oct 2022 07:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424777; bh=xNMqv/ZsY0vx5mTBDBy94sW1JDIi2qFUa783AYIVEJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sF6wYgmUJSH5s4ycXf45/Jx2bkcSWnFOhFGPoC+sKQ9JAqah15w2hGE75izZtfMy6 H0Z0/tLdgwBEVmD/n6Unhxf4+PkJsMbJf/bnn6LVodn2v1sVGz1L1zTA/Mu0iP4EB6 xWDctsU3kcb6F/VJv9mFjMjGY61mJ7GNPKKOwCm4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Phil Sutter , Florian Westphal , Sasha Levin Subject: [PATCH 5.19 273/717] netfilter: nft_fib: Fix for rpath check with VRF devices Date: Sat, 22 Oct 2022 09:22:32 +0200 Message-Id: <20221022072502.701219783@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747373984895540578?= X-GMAIL-MSGID: =?utf-8?q?1747373984895540578?= From: Phil Sutter [ Upstream commit 2a8a7c0eaa8747c16aa4a48d573aa920d5c00a5c ] Analogous to commit b575b24b8eee3 ("netfilter: Fix rpfilter dropping vrf packets by mistake") but for nftables fib expression: Add special treatment of VRF devices so that typical reverse path filtering via 'fib saddr . iif oif' expression works as expected. Fixes: f6d0cbcf09c50 ("netfilter: nf_tables: add fib expression") Signed-off-by: Phil Sutter Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/ipv4/netfilter/nft_fib_ipv4.c | 3 +++ net/ipv6/netfilter/nft_fib_ipv6.c | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/nft_fib_ipv4.c b/net/ipv4/netfilter/nft_fib_ipv4.c index b75cac69bd7e..7ade04ff972d 100644 --- a/net/ipv4/netfilter/nft_fib_ipv4.c +++ b/net/ipv4/netfilter/nft_fib_ipv4.c @@ -83,6 +83,9 @@ void nft_fib4_eval(const struct nft_expr *expr, struct nft_regs *regs, else oif = NULL; + if (priv->flags & NFTA_FIB_F_IIF) + fl4.flowi4_oif = l3mdev_master_ifindex_rcu(oif); + if (nft_hook(pkt) == NF_INET_PRE_ROUTING && nft_fib_is_loopback(pkt->skb, nft_in(pkt))) { nft_fib_store_result(dest, priv, nft_in(pkt)); diff --git a/net/ipv6/netfilter/nft_fib_ipv6.c b/net/ipv6/netfilter/nft_fib_ipv6.c index 8970d0b4faeb..1d7e520d9966 100644 --- a/net/ipv6/netfilter/nft_fib_ipv6.c +++ b/net/ipv6/netfilter/nft_fib_ipv6.c @@ -41,6 +41,9 @@ static int nft_fib6_flowi_init(struct flowi6 *fl6, const struct nft_fib *priv, if (ipv6_addr_type(&fl6->daddr) & IPV6_ADDR_LINKLOCAL) { lookup_flags |= RT6_LOOKUP_F_IFACE; fl6->flowi6_oif = get_ifindex(dev ? dev : pkt->skb->dev); + } else if ((priv->flags & NFTA_FIB_F_IIF) && + (netif_is_l3_master(dev) || netif_is_l3_slave(dev))) { + fl6->flowi6_oif = dev->ifindex; } if (ipv6_addr_type(&fl6->saddr) & IPV6_ADDR_UNICAST) @@ -197,7 +200,8 @@ void nft_fib6_eval(const struct nft_expr *expr, struct nft_regs *regs, if (rt->rt6i_flags & (RTF_REJECT | RTF_ANYCAST | RTF_LOCAL)) goto put_rt_err; - if (oif && oif != rt->rt6i_idev->dev) + if (oif && oif != rt->rt6i_idev->dev && + l3mdev_master_ifindex_rcu(rt->rt6i_idev->dev) != oif->ifindex) goto put_rt_err; nft_fib_store_result(dest, priv, rt->rt6i_idev->dev);