From patchwork Sat Oct 22 07:21:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7327 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1093857wrr; Sat, 22 Oct 2022 00:58:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6HEhfQU7TdaYDMlGniTvhQDAgp+vO82bKJdwFNvQrf/5K2GoU1IYDQM3/a4X1Ap02juYwV X-Received: by 2002:a17:90b:4a84:b0:20d:8953:5ab0 with SMTP id lp4-20020a17090b4a8400b0020d89535ab0mr62056029pjb.48.1666425519247; Sat, 22 Oct 2022 00:58:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666425519; cv=none; d=google.com; s=arc-20160816; b=rhwP7YMacqLhzb9WcbSFr9uN8dHausqxybudmrYsIh9qJy7xkpo6Bu3/S12i3sIUtR G01DZe1+tIDzOOPpRXZOCCeEXNWSvj3w4JR5j8Ry/Lixx+8HLvZcKTuSDBx3ouwSnw20 10jsKP2pQ/Ph93whmZXXP7gVGoCxzsirfE9gbJcKaZTIDnFP1v2yG5bACYdvzQ0soVLF MXdZmE8sApUYH7RORN5Lu+tE+eoUywXg0c7fszG9tZ6F0P+5X4ykZ2i8fQHnnycDDPth CV7KQcabWQwu4Ac+cFxk61yBsKm59xKHQEWAA5z64TDnm4AGM/EK/Pp8izfr/0xad/YF pUXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0NSNSeWPyGDNoPo/MXlMb+vb5mPoByzXNLn9r7Z/+MU=; b=ijyhI/g6c4vBae/7kpi4i/wnV1FVv2sM34fP3ZkEdetucBqbuohQb9LrpV0KEdv2ZS +0TbUl46c5do9wBfRSX7BpKftjE3qT5QZf9DnSVSU49FrTP28uSL6QURyMahl6q82uAa c5OdI1Q8rpsYpmkWEwb/dDG7pQPOT2ExryPfyUYX+92Y5pvCJpzazHWsil1Vcajt2mwT 1Cv2qhoZdevsmmME7Z3+ow6n6JTGJwasQT7Xl5UfGbyaWOiWAr9DmqqALoYhpFt5g6ED N3QcjzXD7dlaR47Lc7yZQmjH1qdl7BGa2/mG14rMGxWEpGW+hdhtgHOTvkO8YpK9n5Gx Wh5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mY23q3fS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pj11-20020a17090b4f4b00b0020d542eb5f0si2670456pjb.110.2022.10.22.00.58.26; Sat, 22 Oct 2022 00:58:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mY23q3fS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbiJVH5u (ORCPT + 99 others); Sat, 22 Oct 2022 03:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231824AbiJVHxo (ORCPT ); Sat, 22 Oct 2022 03:53:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3092CA7FF; Sat, 22 Oct 2022 00:47:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B4E460AD9; Sat, 22 Oct 2022 07:45:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD672C433C1; Sat, 22 Oct 2022 07:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424756; bh=JhgL9COsiyeoFdvdjazLag1ghoyXd+7VEHktdi85UDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mY23q3fSCAEvPbwQ2GlXCiWwrYXQVDceEx32SlO+O7Gu1njUPzRACWGMhkaEVgE6p IXx8T/8ccqRlNYPsdz20gsjVs3sxSCQUUZmaYT9mzKmBdhJbuc7pVnPBOMlEJH8UYy wKDSBLavw1X972hs7EN94WV4/GlmE1qNkDKP5iY0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 5.19 235/717] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Sat, 22 Oct 2022 09:21:54 +0200 Message-Id: <20221022072456.608029589@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747373805569887199?= X-GMAIL-MSGID: =?utf-8?q?1747373805569887199?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 03b04d6913d7..780a485eafd9 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2929,12 +2929,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];