From patchwork Sat Oct 22 07:21:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7266 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1091829wrr; Sat, 22 Oct 2022 00:51:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7DC2HBrJQCjUIR8Ip6P9AByO1kPQOJqX8aDYvf1S1vjPXrl3OfkLj0vF/NKSy9wYn4VS9G X-Received: by 2002:a17:902:a416:b0:178:a030:5f94 with SMTP id p22-20020a170902a41600b00178a0305f94mr23409685plq.162.1666425119219; Sat, 22 Oct 2022 00:51:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666425119; cv=none; d=google.com; s=arc-20160816; b=ukwTYlr+A0jHeXSotIShO/owdpthGQJWs7OlSr3Lz8qMKTPvHutGpaYGSAjCNG+XXv 8/p8XRQvKNMYcqwgvMYCyX9f4u3wxZ+neVp9jA2+SMzBliRCE1xRmz5d448H8riFDRN/ 4zc8yl8YGGlU3nD+lulx5527JTeGUGtjJ07No27cSU3BWBcZrLgD2v3NvuYgvxqby0q1 jfWyQ3zueUJV8H6jRwupybAORMsm1LNcJw2Gxd7xMcZNScNaPcmUOKDTSe6p0Wasy2za bJdvQEZU0XYRQSrCtzC9vr+gEuWZZdhFAwNLsfeqSGswiCksElNm1alwozC5kSRD7Uo8 G5Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SPXz+2SK7iEGe/kOieE0OASf5orUj4AsgH4uWoCc/5U=; b=cP69PwPsbwbBlmOuHiHMoCnIOM1zHtGhC9jQLu04mKZsUWjKlNojUcgimIv13puUPW qwyxzMdPkRySxUM8JKaGUPxmIcnlN+SHwOu3sNCFktVjInHCxIjyOCu3myaDBou5rNrn MgBGXKODOM1aqrHT3GL9lwN1CmuWQe5c8uzp4BopyjeNjF/16X3x8vb+57os86MJBMy7 cthqtX/Mu8KY6TYkE+W70b6sbVmHET7Pk+W2drKDa/Vbl4Z2m+kAUFyrTFY+n2CU+cyQ MdjTLsA+P9JmdmygCfPPjAX5XsRmCdcaNEAP2SoWxYYxTchMRXGG0UV87STrvtpVlFPn Sk/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zPXCAPaI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020a654242000000b0045c19daa33esi27791233pgq.355.2022.10.22.00.51.46; Sat, 22 Oct 2022 00:51:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zPXCAPaI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbiJVHvW (ORCPT + 99 others); Sat, 22 Oct 2022 03:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231833AbiJVHtS (ORCPT ); Sat, 22 Oct 2022 03:49:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7EF1BB55A; Sat, 22 Oct 2022 00:45:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 519A060B09; Sat, 22 Oct 2022 07:42:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6561AC433D6; Sat, 22 Oct 2022 07:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424565; bh=e+Vd7JvFc0fcUes11UDUpyQCNraPicOwdsaoFGchMI0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zPXCAPaIiCP/lWC5vgyydlhydVYeNZZdUUGSP4ERgbLTD5kd43UlH8hZ5q3e8jmB7 q/ATEQdkLNYwoOEnU1n7sk0w8KuDt5zz5LQdoDGu1oAqr3p7bMVkUeNYo9j/7zbcER ZINwJ8GGPh72NdpB6hY9oGuWT2sNbAsrQZNCCWI0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huisong Li , Sudeep Holla , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.19 192/717] ACPI: PCC: Fix Tx acknowledge in the PCC address space handler Date: Sat, 22 Oct 2022 09:21:11 +0200 Message-Id: <20221022072449.554503446@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747373385617789377?= X-GMAIL-MSGID: =?utf-8?q?1747373385617789377?= From: Huisong Li [ Upstream commit 18729106c26fb97d4c9ae63ba7aba9889a058dc4 ] Currently, mbox_client_txdone() is called from the PCC address space handler and that expects the user the Tx state machine to be controlled by the client which is not the case and the below warning is thrown: | PCCT: Client can't run the TX ticker Let the controller run the state machine and the end of Tx can be acknowledge by calling mbox_chan_txdone() instead. Fixes: 77e2a04745ff ("ACPI: PCC: Implement OperationRegion handler for the PCC Type 3 subtype") Signed-off-by: Huisong Li Reviewed-by: Sudeep Holla Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpi_pcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index 16ba875e3293..ee4ce5ba1fb2 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -121,7 +121,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physical_address addr, } } - mbox_client_txdone(data->pcc_chan->mchan, ret); + mbox_chan_txdone(data->pcc_chan->mchan, ret); memcpy_fromio(value, data->pcc_comm_addr, data->ctx.length);