From patchwork Sat Oct 22 07:20:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7243 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1091267wrr; Sat, 22 Oct 2022 00:50:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5C9IEfVv/Fkh2YB71PynEJpEo8BLOHLqSiA5DrKVUtTGL2luEWWaQT/C+CJionExSa4KT1 X-Received: by 2002:a17:903:32ce:b0:17f:75dd:de88 with SMTP id i14-20020a17090332ce00b0017f75ddde88mr23196616plr.5.1666425001478; Sat, 22 Oct 2022 00:50:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666425001; cv=none; d=google.com; s=arc-20160816; b=KrgmWjQvacEjmi+zl9clm1zvVqSsEJPrFrEbbwnePkZVksdvh4t+TGyWWHKBZLey3K A9gFw24HUTw+uyvEi7xcozAYmrwEZkmbqEfYNwO1x9GC/Z96PadBaJ8WubOvvcZ3PF7H dgyeSlzHqLiCafoa/5PglDrh1z3ZLa7Cupf1FkPi9Zzp70buZCSpuTmaDuhDZMriC28R 2zYiR+988yXv22KJGS0KYvg/rqYA5V+IEtu1XH7ySzJICycgkZB8lgeX4fynpBtn1Dlx FL+P/mdEBFZkHOpdP4iVreHQFJx4LY7B9y7rmgBJgjAKd3ebh7JxgRuBgrZE68aiKUlQ 3rvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZvTI9bvNoKHsyFgiuzWKp14KnT6xFE5GhdT5g4Pt3Lk=; b=KOxOj4+Ws7CFJy0LOMshsfGgjJfNq+jGppl6ovYG7FATvYbKfZE4bwxxPvvW9YBA1L +yAQM03jKXOBCGvsjy0+UHM0TTKbt3C1uFX+Uxl42QgoE2gziAlXYglirVNRt8F0yJMP E6sG0mPm2DpQApSpIE2K/6QOSPRqrIrY5GfQOs8M94A+M+HAZdwTeHK1rYsnq4/iKDhg 8VOKBZ56fwFZaxb5bFpt4pcFqtRINLo3J1AuB19TJCX6MzfZJeehwE/OpN+3rtaVrgaj ls8bS8cvctqVinq8du9xMddXh7TNVuS2Wex/71TfNM22k4JsK44Jzae2HXAv3496qNFX eWDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZVnPlWlZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c4-20020a17090a8d0400b0020038eb8b5asi8627203pjo.21.2022.10.22.00.49.48; Sat, 22 Oct 2022 00:50:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZVnPlWlZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231693AbiJVHtA (ORCPT + 99 others); Sat, 22 Oct 2022 03:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231415AbiJVHsO (ORCPT ); Sat, 22 Oct 2022 03:48:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F436844D3; Sat, 22 Oct 2022 00:45:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41FA4B82E17; Sat, 22 Oct 2022 07:42:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF4B7C43144; Sat, 22 Oct 2022 07:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424563; bh=hkN++V+EZziRXwAqDFEpFocfj0LhpT6OEj3yMchgpAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZVnPlWlZJC1VhSe9LrNFVAsfNDn82o+8H63b2IqCNk2ZAUtNeAoAKMMEnCFy9EXn8 cpFY6sKymhV4iP6cAv76AeLZHk2U8DISLfW4+xiI0glTCxbGM5f5Yw3df7/uLUMNag EFgyQPoVTo3G/5Qu4lDOo4XSiB3W6d8fzcrvT72Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lyude Paul , Karol Herbst Subject: [PATCH 5.19 165/717] drm/nouveau/kms/nv140-: Disable interlacing Date: Sat, 22 Oct 2022 09:20:44 +0200 Message-Id: <20221022072444.681003556@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747373262137879078?= X-GMAIL-MSGID: =?utf-8?q?1747373262137879078?= From: Lyude Paul commit 8ba9249396bef37cb68be9e8dee7847f1737db9d upstream. As it turns out: while Nvidia does actually have interlacing knobs on their GPU still pretty much no current GPUs since Volta actually support it. Trying interlacing on these GPUs will result in NVDisplay being quite unhappy like so: nouveau 0000:1f:00.0: disp: chid 0 stat 00004802 reason 4 [INVALID_ARG] mthd 2008 data 00000001 code 00080000 nouveau 0000:1f:00.0: disp: chid 0 stat 10005080 reason 5 [INVALID_STATE] mthd 0200 data 00000001 code 00000001 So let's fix this by following the same behavior Nvidia's driver does and disable interlacing entirely. Signed-off-by: Lyude Paul Cc: stable@vger.kernel.org Reviewed-by: Karol Herbst Link: https://patchwork.freedesktop.org/patch/msgid/20220816180436.156310-1-lyude@redhat.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -503,7 +503,8 @@ nouveau_connector_set_encoder(struct drm connector->interlace_allowed = nv_encoder->caps.dp_interlace; else - connector->interlace_allowed = true; + connector->interlace_allowed = + drm->client.device.info.family < NV_DEVICE_INFO_V0_VOLTA; connector->doublescan_allowed = true; } else if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS ||