From patchwork Sat Oct 22 07:20:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7283 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1092228wrr; Sat, 22 Oct 2022 00:53:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4TtY8q9zo/3c636yCpdzb2aHqll4PBUvxYUV0fmxWSjR5aFVV1EcL3BzDH2P296/cy8uCw X-Received: by 2002:aa7:84c1:0:b0:563:d2c:c37c with SMTP id x1-20020aa784c1000000b005630d2cc37cmr22550037pfn.24.1666425207209; Sat, 22 Oct 2022 00:53:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666425207; cv=none; d=google.com; s=arc-20160816; b=mhIZOhCAtsO5KORiAhC+z0Cid/xXVsYnstmbBfbK0MfREq6O0lKbl4BrJlH7PCWVHR a6BpuFtBXbFlZyVnS46kw03kYWP5D0PVWQzaDh7dCa8k9F8uaY3WJXZlTVysv/mfRTsf f+8kpGIj9iZPdrS10GGcfivAArioC+ZfJQVvDQ+6GjFQtW0U4jvvNFUBMgTSnoLlLVhq aLGsBoIWroQV+DEF3F1LMMDbW6bN85f5vE2ZDdofazt16ajaAJEZec9n0GliKVQiX5DZ If00YrKY2T/3KFnSJk1pfKumQmHzY9UNd2FUU7AYeYITDenE+a+TTIi/BetXDmkktz8l pFbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UUegYTILBeNMJePcZrN/m5Vkl9/l3KkjS/idS0p1nhg=; b=qVM7VBF1mDu6u12H3JRzCifXOMFzzaNzUCPAvtOH+BIpMVRzoaP1w/TIyR2nZoeP76 wUBv3aJlRUKoTXVLiadYsOrqRh0po1HyKkohhFtYSq3mnKKdTmNVo+KRAgqEB0jDtn50 h8XVm+wvlEYkJZIShWafuQi9aFxklN8Z4l3I1Ef5PcxlLzVIJtE3WASJGCpCCuayacCj EuhzETa04+i2Xp7aR8EKruN9VummYQIkEUqZlZJYt6GtM7uhn9ro2Ctl+6kbxoaQyahn kbuYLc54EY5KU0Nk/X+8h2lC9ld/k8hoZdjeX8hro8/SAEROE/QRqvBaxqfDuZmHGYaj yTVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UTV2Gidt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j18-20020a63ec12000000b0046ed62f820dsi2417865pgh.288.2022.10.22.00.53.15; Sat, 22 Oct 2022 00:53:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UTV2Gidt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231895AbiJVHw4 (ORCPT + 99 others); Sat, 22 Oct 2022 03:52:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbiJVHtt (ORCPT ); Sat, 22 Oct 2022 03:49:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 900092B76BA; Sat, 22 Oct 2022 00:46:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97A9260B40; Sat, 22 Oct 2022 07:39:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA4F7C433D6; Sat, 22 Oct 2022 07:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424386; bh=/T5WIT+OJWxhYMw+OGtb645cRypYMAjjAnkcyWWRik8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UTV2GidtferzF5sNR95OaZs0uODL6E+Kpu0A6yNQigSyrI3amz8WShpgWATxMk3Fu SjgE6ulTA2Q+G/XoE5/i1gh24CtjWu+EMMlK4cJ5kU4/TNJK7snspw5/VPScDCcINS stQhtY5Mztf9iArkQDS4sRg+IKfyJg7IFvf6s7e8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Lalith Rajendran , Theodore Tso Subject: [PATCH 5.19 125/717] ext4: make ext4_lazyinit_thread freezable Date: Sat, 22 Oct 2022 09:20:04 +0200 Message-Id: <20221022072437.577812816@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747373477903400039?= X-GMAIL-MSGID: =?utf-8?q?1747373477903400039?= From: Lalith Rajendran commit 3b575495ab8dbb4dbe85b4ac7f991693c3668ff5 upstream. ext4_lazyinit_thread is not set freezable. Hence when the thread calls try_to_freeze it doesn't freeze during suspend and continues to send requests to the storage during suspend, resulting in suspend failures. Cc: stable@kernel.org Signed-off-by: Lalith Rajendran Link: https://lore.kernel.org/r/20220818214049.1519544-1-lalithkraj@google.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3758,6 +3758,7 @@ static int ext4_lazyinit_thread(void *ar unsigned long next_wakeup, cur; BUG_ON(NULL == eli); + set_freezable(); cont_thread: while (true) {