From patchwork Sat Oct 22 07:18:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 7155 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1088015wrr; Sat, 22 Oct 2022 00:38:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7uoRFzHbwu/YRc/SDr333uKrRMImooEEHm4ys63W60Q/X+Y9ZYtrY9DpCvv0T2AEUZY4LR X-Received: by 2002:a17:907:7704:b0:780:da38:4480 with SMTP id kw4-20020a170907770400b00780da384480mr19218690ejc.64.1666424307814; Sat, 22 Oct 2022 00:38:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666424307; cv=none; d=google.com; s=arc-20160816; b=M2OOg5eLXDJAZr+76jH9A2swg/hAP9kiq4WPTFH7wYLA9sYkpGJDUH2tJ0odAgg1eW vRo9YngoQprWBGy/DdVTYqY04SKYPoevF3iLZCiERezqu+NRXQgMXpdgiiRSWBLotH40 LHDU/K1IcqwRilPmh2H4E9xyMxC6u3CzsLDdp7EKmCzwRFcHihxpxHi3LBxPdy75d5eb 7m+7Z4VgiRvhJ9V+OgSwcvRk3FJsJX2UEwdRbbqma3Zwn7cQSG3EXJ99POswYwokPDT8 FFCIDxmKLidclqqcPSpP+7gDXalet/Vc+3vXm/k0iB55RmxOdhPsBgiLy6AAe2rSx5cj qxow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lG0byh4LVcrlgAoUPDvq7T/ChO9FOAe0ySYVLa2ba+k=; b=d0ZUhOIwElm9cmPhSRfHmN/LtjQYDORrjy6JhFJOm6MdiiRl2WQksxlFmTpr74gccy 16ftIRquICmUGOPPBtddC9kjMdIpGDNOkfGMC7WamXGqiJ222pFrr+5ie5VwpQ8RcQ3m Wzj5fuuAnfCzhda7mfOCcGhnJzxYJwg1moUqotrD6BS04sSeLT+I82WJv6wDoyQZqS0z vduQYIzz/hgZ4to2RIkPgKmtW+HsvHWaakKRSR2IdWWd4ns2vY8uI7SCDsCy1Lbf/FzU TcCUpzfmMbaLmiFhUE+Te018vzO+Ui5z5RPZsJjJpmjfvPeYMveCpwLTv3PmrwR4Bva/ H0Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ixYUUXP/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a0564021e8800b0044e78dbb615si25953516edf.379.2022.10.22.00.38.03; Sat, 22 Oct 2022 00:38:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ixYUUXP/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbiJVHhg (ORCPT + 99 others); Sat, 22 Oct 2022 03:37:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbiJVHgu (ORCPT ); Sat, 22 Oct 2022 03:36:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F04C44E410; Sat, 22 Oct 2022 00:35:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C08F60AD7; Sat, 22 Oct 2022 07:35:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 537BBC4347C; Sat, 22 Oct 2022 07:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424117; bh=m+TRFRTP9gvTQtFF2Gus8jbfXoqPRF+vKAg3y1aelXY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ixYUUXP/ezUt/AUQsRU6Bs+73imfHvfjxQVUpqIeSrtvr9Jqs7OyVFTUxestgRKeT 1SvtQdKqwYdJtNihWRtuowcvWyWfkE7sdYY7oqKseWCquuKrkaDdHGN6sdtM16rbaH WOnSjp0RhP9tfbLm5VlGC9tPk0rN2H92/xeok/Uc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Callum Osmotherly , Takashi Iwai Subject: [PATCH 5.19 006/717] ALSA: hda/realtek: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Date: Sat, 22 Oct 2022 09:18:05 +0200 Message-Id: <20221022072416.192634022@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747372535226555626?= X-GMAIL-MSGID: =?utf-8?q?1747372535226555626?= From: Callum Osmotherly commit 417b9c51f59734d852e47252476fadc293ad994a upstream. After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Fixes: 1885ff13d4c4 ("ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop") Signed-off-by: Callum Osmotherly Cc: Link: https://lore.kernel.org/r/Yz0uyN1zwZhnyRD6@piranha Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9151,7 +9151,6 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),