From patchwork Sat Oct 22 00:05:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Fricke X-Patchwork-Id: 7051 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp965656wrr; Fri, 21 Oct 2022 17:20:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4r+WqVeG2//lN/Ppr6Iuc/jV7ULilZWovqpohE13wWqCMkgOH//ESIUSVUkYN3AgC7LKIz X-Received: by 2002:a17:90b:1c90:b0:203:b7b4:b1cf with SMTP id oo16-20020a17090b1c9000b00203b7b4b1cfmr62671531pjb.160.1666398046820; Fri, 21 Oct 2022 17:20:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666398046; cv=none; d=google.com; s=arc-20160816; b=cwxOck6jacDtSgvPpJ+4c1WDCvP5dtHnRfpZOESj9tEvKfuQK9BOJHYXonLzkpWoks lhmI2M3ECMZ7NQ78BNu8eSbbmJ+hLQJB4J5QoXAs0QUiL2/U4T4i4yYVSl/teWVUretE Ywsirj9eaxTI6+abwdTWiG6FjIXSpUHHyPrd7BotvNMTNWW/Pq3xPcJljTuQ81mi+AFn FD3sMD9YzEgQqXhEIgUbprAwrN2BPJPMLYehOuojMX2QxvutQvToSB+z9wonjMaj9i8s 1yrcWa2Jjc6OI+2GgFZAVifulfFlCG2/JhPgUFxhYeK3mQ6dpcOz0dElLnPPrTT/Pr59 nphw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3kS7nJW139Lhg4bS9q998Ok1DdhL9L97fBEgW8Roum8=; b=DW7sQk6lB4Cul1OBXPq0+sMvtLPMR0a+skVa04lNE1SA5BI2TWNasR7eTw6GkRmpfj OZhUoKi3pG2BmDIdcnC1uN31C1PKszAw0WOEOWNajBWlxdzE3imgS/OquH5Bmcd8JWlQ iL87dxIk7puxMEPSq12O966JH4cXZO76X/5AU31Nsgr4i9W3k2rf/TwRYBofAvo8ZDQ/ u60cSvMV2riCyT3Ie15mQR8VGoToMRhTtAWwupYy6+h76DM+5Hp4wM0kA8aElQT7tnGW kR6JbIsXMLODtvE7CAKAQIRzl+3oOeIQCr97eMYIfBqOwV+ZlVEQsnjigSIbPqdDjane 5Wbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="K/rbv30I"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a656687000000b0045160a30fcasi24235425pgw.388.2022.10.21.17.20.30; Fri, 21 Oct 2022 17:20:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="K/rbv30I"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbiJVAHq (ORCPT + 99 others); Fri, 21 Oct 2022 20:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbiJVAG7 (ORCPT ); Fri, 21 Oct 2022 20:06:59 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9061F46622; Fri, 21 Oct 2022 17:06:26 -0700 (PDT) Received: from localhost (89-26-75-29.goll.dyn.salzburg-online.at [89.26.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sebastianfricke) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3E8FE660281F; Sat, 22 Oct 2022 01:05:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666397125; bh=6+DWQ6D12NSOxQM77moNpvxny+57/A+nUvDMCeEUmOk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K/rbv30ITrs5oQT7ax46mLTvf5Sgmecz9O+jn2vAgvN36IZ1H3be48CwlOc0RnkVb xY30UzYmdj2ktoLMB/kJlAM0y49QcMFNMj/Vz/Kfe0Uu/dO5OcFF8dC99R9sL0k59z eqt0CRLqE5CshlDmA0l0mUQSOgtSMgQv0FVH/jcqLzb1AcB4OIiQXIPp0G60d5cmzO iJEmom3L8L3wtozyYDEx0Io0fglbGthxreV3s+9j0+XkMKgzduvhZPfY0tTN4/M8yy zOdRk24WmcVT6zTlpPcwf1hvDguLByUGFt7ABtQr0gjUgyi8/Lbw67WXvDTmOkgYcN 9t8SqJjXOVOvQ== From: Sebastian Fricke To: linux-media@vger.kernel.org Cc: kernel@collabora.com, nas.chung@chipsnmedia.com, hverkuil@xs4all.nl, ezequiel@vanguardiasur.com.ar, linux-kernel@vger.kernel.org, nicolas.dufresne@collabora.com, p.zabel@pengutronix.de, dafna@fastmail.com Subject: [PATCH v10 5/7] media: chips-media: wave5: Add TODO file Date: Sat, 22 Oct 2022 02:05:04 +0200 Message-Id: <20221022000506.221933-6-sebastian.fricke@collabora.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221022000506.221933-1-sebastian.fricke@collabora.com> References: <20221022000506.221933-1-sebastian.fricke@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747344998359444158?= X-GMAIL-MSGID: =?utf-8?q?1747344998359444158?= From: Nas Chung Add a TODO file with remaining elements to be improved/added. Signed-off-by: Robert Beckett Signed-off-by: Dafna Hirschfeld Signed-off-by: Sebastian Fricke Signed-off-by: Nas Chung --- drivers/staging/media/wave5/TODO | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 drivers/staging/media/wave5/TODO diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO new file mode 100644 index 000000000000..6cc38d4ccbc9 --- /dev/null +++ b/drivers/staging/media/wave5/TODO @@ -0,0 +1,25 @@ +* Handle interrupts better + +Currently the interrupt handling uses an unusual design employing a kfifo to +transfer irq status to irq thread. This was done as a work around for dropped +interrupts seen with IRQF_ONESHOT based handling. + +This needs further investigation and fixing properly, with the aid of +C&M and StarFive engineers. + +* remove all struct fields, that are assigned to but not used in the code, add + documentation about each removed field at the macro for the register it is + related too. + +* power management handling - add (runtime_)suspen/resume cb where the clock is enabled + +* revise logic of wave5_vpu_(dec/enc)_register_framebuffer + +* check if the normal kernel endianness/__swab32 routines are sufficient. (instead of the ones + implemented in the driver) + +* Extended Codec Controls for encoder. + +implement extended codec control for HEVC/H264 encoder. +PROFILE/LEVEL/MIN_QP/MAX_QP/LOOP_FILTER/HFLIP/VFIIP/ROTATE/ +GOP_SIZE/RC_ENABLE/I_PERIOD/BITRATE.