diff mbox series

[17/21] input: remove s3c24xx touchscreen driver

Message ID 20221021203329.4143397-17-arnd@kernel.org
State New
Headers
Series ARM: s3c: clean out obsolete platforms |

Commit Message

Arnd Bergmann Oct. 21, 2022, 8:27 p.m. UTC 
  From: Arnd Bergmann <arnd@arndb.de>

The s3c24xx SoC support and its adc driver was removed, so this driver
has no remaining users.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/input/touchscreen/Kconfig      |  12 -
 drivers/input/touchscreen/Makefile     |   1 -
 drivers/input/touchscreen/s3c2410_ts.c | 464 -------------------------
 3 files changed, 477 deletions(-)
 delete mode 100644 drivers/input/touchscreen/s3c2410_ts.c

Comments

Dmitry Torokhov Oct. 24, 2022, 11:57 a.m. UTC | #1 
On Fri, Oct 21, 2022 at 10:27:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The s3c24xx SoC support and its adc driver was removed, so this driver
> has no remaining users.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.
Krzysztof Kozlowski Oct. 24, 2022, 12:50 p.m. UTC | #2 
On 21/10/2022 16:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The s3c24xx SoC support and its adc driver was removed, so this driver
> has no remaining users.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/input/touchscreen/Kconfig      |  12 -
>  drivers/input/touchscreen/Makefile     |   1 -
>  drivers/input/touchscreen/s3c2410_ts.c | 464 -------------------------
>  3 files changed, 477 deletions(-)

This also could be usable on S3C64xx, but it seems no one added any DT
nodes, so:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Arnd Bergmann Oct. 24, 2022, 1:02 p.m. UTC | #3 
On Mon, Oct 24, 2022, at 14:50, Krzysztof Kozlowski wrote:
> On 21/10/2022 16:27, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The s3c24xx SoC support and its adc driver was removed, so this driver
>> has no remaining users.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/input/touchscreen/Kconfig      |  12 -
>>  drivers/input/touchscreen/Makefile     |   1 -
>>  drivers/input/touchscreen/s3c2410_ts.c | 464 -------------------------
>>  3 files changed, 477 deletions(-)
>
> This also could be usable on S3C64xx, but it seems no one added any DT
> nodes, so:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks. To clarify, the key bit here is the 'depends on S3C_ADC',
and that driver in turn 'depends on !ARCH_MULTIPLATFORM' since
2014. So even for the boardfile variant of s3c64xx, it was
already impossible to use for a long time without anyone complaining
or trying to fix it.

     Arnd
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 4fde2b93b990..4d451640a223 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -462,18 +462,6 @@  config TOUCHSCREEN_IPROC
 	  To compile this driver as a module, choose M here: the
 	  module will be called bcm_iproc_tsc.
 
-config TOUCHSCREEN_S3C2410
-	tristate "Samsung S3C2410/generic touchscreen input driver"
-	depends on ARCH_S3C24XX || SAMSUNG_DEV_TS
-	depends on S3C_ADC
-	help
-	  Say Y here if you have the s3c2410 touchscreen.
-
-	  If unsure, say N.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called s3c2410_ts.
-
 config TOUCHSCREEN_S6SY761
 	tristate "Samsung S6SY761 Touchscreen driver"
 	depends on I2C
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index 533a80ad054c..eb53d652c935 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -73,7 +73,6 @@  obj-$(CONFIG_TOUCHSCREEN_PCAP)		+= pcap_ts.o
 obj-$(CONFIG_TOUCHSCREEN_PENMOUNT)	+= penmount.o
 obj-$(CONFIG_TOUCHSCREEN_PIXCIR)	+= pixcir_i2c_ts.o
 obj-$(CONFIG_TOUCHSCREEN_RM_TS)		+= raydium_i2c_ts.o
-obj-$(CONFIG_TOUCHSCREEN_S3C2410)	+= s3c2410_ts.o
 obj-$(CONFIG_TOUCHSCREEN_S6SY761)	+= s6sy761.o
 obj-$(CONFIG_TOUCHSCREEN_SILEAD)	+= silead.o
 obj-$(CONFIG_TOUCHSCREEN_SIS_I2C)	+= sis_i2c.o
diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
deleted file mode 100644
index 2e70c0b79444..000000000000