| Message ID | 20221021190908.1502026-3-nfraprado@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp862669wrr;
Fri, 21 Oct 2022 12:15:13 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM7ydE0DahDz7L3anFjFoh+s2Hd2g+aq1WhfetllMbk6JmoHeyA3cfHahLBLZHNpkH60gJwW
X-Received: by 2002:a17:907:e89:b0:78d:cdd7:5a28 with SMTP id
ho9-20020a1709070e8900b0078dcdd75a28mr17460678ejc.167.1666379713381;
Fri, 21 Oct 2022 12:15:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666379713; cv=none;
d=google.com; s=arc-20160816;
b=TpvE3tDNOZRZuZM+ljmcIEq41QAcNSjqeKp5od5EzPRubR+SLYJl8Pu9+OJm0V332c
WpbxWdFdaiW/GDQ485eP6vB+QzLFvIbTawTIM82bXdOI422fcfLdDJmxmHeGPC4q3NhX
fCAh51foeVBWMsiA2xDoRlkPHocBJ8Kk9Cs9p1zB+G9bD780RVQ7hJxmnIDP3vbqtCRd
bHD+R+AG/bMeWBn6TJZWTSmWjmoNgW2c25sNvp7c6ZlHsLnBfNsWOsM3oG0a/A+3fRF8
BRd13+NjylIrJuyF6eXaiZ2cq5+MYfUJ30CeFWhzIjazsfErvG3QbGN744xN4YZip4IR
sxzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=Rlzl+2VwG5ZQGU4gsYys2pX93K8h6LwRO47yVqohzQQ=;
b=ILSzBzRIPbXMpzDHiaJeZN1PsimarGyZ5lCZvvcvsR6OR/kO565edcnPbnd2kJG6Y1
eggqLHuJzzFdj0TRufVanaBFcjUkTWPpaOvF8vDYGwzoY1k//5ey3whuky7GSbYK5Sql
OdVqvDLvRUC9/jb3NK9mxE5P2O8EDdGuxheUovffhPQEdvBTiw/Luf3nsbeezG/41w3u
90xZrQklumHi6/xdNRx99xzkPZdMrWhTFU0SNHxsA1eafjJtqovaUOtM5vZuZGhobska
7rqBD6OCdnJIRXbgNKj/FnTdyqRCt++goc4H3nkt1VGP1PT2n+mAxmzl5YXY25rVwfDt
FDcQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b="N/oJ4KJN";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
b11-20020a0564021f0b00b0045bf23171d5si20004871edb.165.2022.10.21.12.14.49;
Fri, 21 Oct 2022 12:15:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b="N/oJ4KJN";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230024AbiJUTJb (ORCPT <rfc822;mntrajkot1@gmail.com> + 99 others);
Fri, 21 Oct 2022 15:09:31 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34452 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230310AbiJUTJT (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 21 Oct 2022 15:09:19 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[46.235.227.172])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E783F4621F;
Fri, 21 Oct 2022 12:09:17 -0700 (PDT)
Received: from notapiano.myfiosgateway.com (unknown
[IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: nfraprado)
by madras.collabora.co.uk (Postfix) with ESMTPSA id 49EE066026E6;
Fri, 21 Oct 2022 20:09:15 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1666379356;
bh=DS3kNRrxvQNnQ5FSBW8HqwtDWRSQIlWA9aI0kdJZTLQ=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=N/oJ4KJNyg6WVSLigu+m3R6pG774ED2lh9CHfCen5Xvwl3LEtWmXDkQD1JIqUOcGG
2rRbhrj4MkXSw9/V1xWZxWI82K6mrLCQU7ZCdx3g6jeccBPQ1i3tJewuNV40lAXdpp
OH9OSCbWbAU9tvVdm3QhatLiEdL/3OREevzsXZf7lYmn72QJhysaKIETFH8z8Ap5pn
d8ZIXyOehrZtBJncoi6WBd296/nulbmmnEoWvcu+lXSSz9IwGExC0a8KF1I0k0Ty0n
H7f7HDfvzxztz7vpMo8wEkI//53M35J/j4LQxEI/PwoSmzH9kABPMPK8OWzCQyqcEl
9HB6ll62hMaaw==
From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
kernel@collabora.com,
=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>,
Derek Fang <derek.fang@realtek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD
supplies
Date: Fri, 21 Oct 2022 15:09:07 -0400
Message-Id: <20221021190908.1502026-3-nfraprado@collabora.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221021190908.1502026-1-nfraprado@collabora.com>
References: <20221021190908.1502026-1-nfraprado@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747325774277017319?=
X-GMAIL-MSGID: =?utf-8?q?1747325774277017319?=
|
| Series |
Add missing dt-binding properties to rt5682(s)
|
|
Commit Message
Nícolas F. R. A. Prado
Oct. 21, 2022, 7:09 p.m. UTC
The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
for them.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
1 file changed, 4 insertions(+)
Comments
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com> On 21/10/2022 21:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ea53a55015c4..ca1037e76f96 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -90,6 +90,10 @@ properties: > "#sound-dai-cells": > const: 0 > > + AVDD-supply: true > + > + MICVDD-supply: true > + > additionalProperties: false > > required:
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ea53a55015c4..ca1037e76f96 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -90,6 +90,10 @@ properties: > "#sound-dai-cells": > const: 0 > > + AVDD-supply: true > + > + MICVDD-supply: true > + How about keeping some order in the list of properties? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ea53a55015c4..ca1037e76f96 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -90,6 +90,10 @@ properties: > "#sound-dai-cells": > const: 0 > > + AVDD-supply: true > + > + MICVDD-supply: true Ach, unacked. Please use lowercase names. Best regards, Krzysztof
On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote: > On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > > for them. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > > index ea53a55015c4..ca1037e76f96 100644 > > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > > @@ -90,6 +90,10 @@ properties: > > "#sound-dai-cells": > > const: 0 > > > > + AVDD-supply: true > > + > > + MICVDD-supply: true > > + > > How about keeping some order in the list of properties? The current properties don't seem to follow any particular order and keeping the supplies grouped together seemed reasonable. What ordering do you suggest? Thanks, Nícolas
On 24/10/2022 11:06, Nícolas F. R. A. Prado wrote: > On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: >>> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties >>> for them. >>> >>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >>> --- >>> >>> Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> index ea53a55015c4..ca1037e76f96 100644 >>> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> @@ -90,6 +90,10 @@ properties: >>> "#sound-dai-cells": >>> const: 0 >>> >>> + AVDD-supply: true >>> + >>> + MICVDD-supply: true >>> + >> >> How about keeping some order in the list of properties? > > The current properties don't seem to follow any particular order and keeping the > supplies grouped together seemed reasonable. What ordering do you suggest? That's true... :/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index ea53a55015c4..ca1037e76f96 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -90,6 +90,10 @@ properties: "#sound-dai-cells": const: 0 + AVDD-supply: true + + MICVDD-supply: true + additionalProperties: false required: