Message ID | 20221021173504.27546-1-colin.i.king@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp824850wrr; Fri, 21 Oct 2022 10:43:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7MUSL57eWMXAOMVipdiQ2oO3l+s9x7JxCm0Xd7YjL65oMBqkYMy98ua4WjdXCBzuPAVWT0 X-Received: by 2002:a63:8ac8:0:b0:46e:c3dd:69df with SMTP id y191-20020a638ac8000000b0046ec3dd69dfmr2375732pgd.539.1666374202545; Fri, 21 Oct 2022 10:43:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666374202; cv=none; d=google.com; s=arc-20160816; b=wanEuku7I4bpCoZ5f291z71YlBXlI1L3txeuJzLoIYXduKsA2aMuNVWHNr3ebmmf3T iJaSZ4eDgJRkIKcNZb3RD8BI2xYD1Tl8AVz1nsSchHTzF46Db7dECTwcG/rGgZS86nIt lbE4a1WRQpJYKSy/IPWclJpPRNJiOeGX5kWdCfrhqZ4aicTSEQ9zb6TO9Qnak6zyjSi/ igADUs7p2G6fP0AnBL9Yz+R/GowUFXLxUClrM8iJCnFWNEbiv2zzoaCQ+XAXT27J1EQZ gbp8nywIJtU3RRB2pfm6DZWs8J6XToJ5TGkMJcZbUylm3hbTBTvk+ktnW5fFRGUy0+ib DIUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=L//Wieblo+p2SGcpxf4C8N8iwGJJZA437EZKxzdxE5c=; b=KYE8SIhq9N0nAid4VuSMqOsntrWZffYTjXr5bCZ15/X6208F+K+vSh94SIPE5b/D5W f/N5+15ujccxsrjlb51Si50ZFcRYnvFPs1GMwBMvnF+lGj3fFTW70/0Tgk7KV/bg8qvo JS2wgSj+i2ARj0i5YPYjSoo5vFzuVKgzHfCGDzSDePzY6Xd3Lyp4eQ6OyVuCgJk1xgc5 gp2Ud/O90DivB33pf//XqQC+8QXnggg8LOuBZDKG1z56Xq5Jd5t/LXH0dyfuppVd/UwT vCfbuq7M92c/bfr7ITcilKE/Z6MiHcDHwY1GaD2BJt8+OJefpV2aFIcST40/Z5IrdURr Molw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=c7QSuv7i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f9-20020a636a09000000b0046b208e7298si25095449pgc.782.2022.10.21.10.43.08; Fri, 21 Oct 2022 10:43:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=c7QSuv7i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbiJURfQ (ORCPT <rfc822;mntrajkot1@gmail.com> + 99 others); Fri, 21 Oct 2022 13:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbiJURfI (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Oct 2022 13:35:08 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2210A9A290; Fri, 21 Oct 2022 10:35:07 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id v1so6036521wrt.11; Fri, 21 Oct 2022 10:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L//Wieblo+p2SGcpxf4C8N8iwGJJZA437EZKxzdxE5c=; b=c7QSuv7iBp5wBrkef3xhwdcZzBUk7O3yFsXRHdNkIwZRAgDvjtzVu3lTez4Or0vyqZ 5srXJJ+CRE3E1YNzid2s4Md7XF+aRPkxl6K6NALoeHYddEpW4VHZ04RTPBnnp2PX0EZU +qSojd6H9nT4wHskzFEaa9LLw+Xqc2GyohDTnJYaSg0okXfDNoEea1f/jiX48iSzMHyO SiX5Sa2HbS2v7CjuJkBHKOzHxYpvBOvOeKYvCEE1sOjjA3Pvio7YrU86gea29CMgYS8Z T74fs5CQ8RzDLttl668kRmYZg/P+hiJZfHttqjmrQ0NEe/1nwgIm3TUSqhDljjSlhlEN 4RUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L//Wieblo+p2SGcpxf4C8N8iwGJJZA437EZKxzdxE5c=; b=2DyxTja42MTzDFn5tLwsjk8ncNlkmRce/G1LjiIQaSjTCHOawlAsNxHQMq5inkTVd+ 2QbLKzt0vNJMf3nY+piRf4tM1BHyzp1ub17OdF70uwPimPhXK5S9hcpcu+nmDuXlcsNP R3kT+kl4l9QFk1M1jXFjr4LkPG6QJXSf8TsNEEA5VjTKvz5ylMVWDE8I/NJV9acVWc2h XfNa4cl0HnXgZpI6jXaEairibtZAIVlQNOGIbsV/pqzZqhadBiD0u70EY9evyYvqFbgh 60jyVjhYIYF9tKuvh0JcPd4ccSQV2rCXx8z+GLe/2xHO32L5l0GnD1HpY43OsF29Ts8R DaGQ== X-Gm-Message-State: ACrzQf0pgefLmCRxyo9cLPzYuDtcLWlf5r/+GFmMUzaFbD6RDILXaLOJ +MqsXFr/WTdqvIM4+5uMe1Y= X-Received: by 2002:a05:6000:18ac:b0:232:c7c1:314f with SMTP id b12-20020a05600018ac00b00232c7c1314fmr12382847wri.109.1666373705721; Fri, 21 Oct 2022 10:35:05 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id e38-20020a5d5966000000b002252884cc91sm19436118wri.43.2022.10.21.10.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 10:35:05 -0700 (PDT) From: Colin Ian King <colin.i.king@gmail.com> To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>, Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt Date: Fri, 21 Oct 2022 18:35:04 +0100 Message-Id: <20221021173504.27546-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747319995970451461?= X-GMAIL-MSGID: =?utf-8?q?1747319995970451461?= |
Series |
RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt
|
|
Commit Message
Colin Ian King
Oct. 21, 2022, 5:35 p.m. UTC
The variable freeze_cnt being incremented but it is never referenced,
it is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/infiniband/hw/qib/qib_iba6120.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
Comments
On Fri, 21 Oct 2022 18:35:04 +0100, Colin Ian King wrote: > The variable freeze_cnt being incremented but it is never referenced, > it is redundant and can be removed. > > Applied, thanks! [1/1] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt https://git.kernel.org/rdma/rdma/c/5dc1b37d75e713 Best regards,
diff --git a/drivers/infiniband/hw/qib/qib_iba6120.c b/drivers/infiniband/hw/qib/qib_iba6120.c index aea571943768..23a81edf3f7a 100644 --- a/drivers/infiniband/hw/qib/qib_iba6120.c +++ b/drivers/infiniband/hw/qib/qib_iba6120.c @@ -799,12 +799,9 @@ static void qib_handle_6120_hwerrors(struct qib_devdata *dd, char *msg, hwerrs &= ~TXE_PIO_PARITY; } - if (!hwerrs) { - static u32 freeze_cnt; - - freeze_cnt++; + if (!hwerrs) qib_6120_clear_freeze(dd); - } else + else isfatal = 1; }