diff mbox series

[2/2] cpuidle: dt: Clarify a comment and simplify code in dt_init_idle_driver()

Message ID 20221021151013.148457-2-ulf.hansson@linaro.org
State New
Headers
Series [1/2] cpuidle: dt: Return the correct numbers of parsed idle states |

Commit Message

Ulf Hansson Oct. 21, 2022, 3:10 p.m. UTC 
  The drv->state_count is assigned the total number of available states, so
let's make that clear.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/cpuidle/dt_idle_states.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Sudeep Holla Oct. 25, 2022, 11:43 a.m. UTC | #1 
On Fri, Oct 21, 2022 at 05:10:13PM +0200, Ulf Hansson wrote:
> The drv->state_count is assigned the total number of available states, so
> let's make that clear.
> 

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
diff mbox series

Patch

diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c
index 448bc796b0b4..7ca3d7d9b5ea 100644
--- a/drivers/cpuidle/dt_idle_states.c
+++ b/drivers/cpuidle/dt_idle_states.c
@@ -211,12 +211,9 @@  int dt_init_idle_driver(struct cpuidle_driver *drv,
 	of_node_put(cpu_node);
 	if (err)
 		return err;
-	/*
-	 * Update the driver state count only if some valid DT idle states
-	 * were detected
-	 */
-	if (i)
-		drv->state_count = state_idx;
+
+	/* Set the number of total supported idle states. */
+	drv->state_count = state_idx;
 
 	/*
 	 * Return the number of present and valid DT idle states, which can