From patchwork Fri Oct 21 13:06:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 6693 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp688613wrr; Fri, 21 Oct 2022 06:09:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM54cemSiE0xxSdpCooYJTFbSpCMlwD1plS3eloWeR+UTq2PD1srGQlzelOnd/5TKtIL4wen X-Received: by 2002:a17:907:c25:b0:78e:1a4:132 with SMTP id ga37-20020a1709070c2500b0078e01a40132mr15583645ejc.521.1666357793471; Fri, 21 Oct 2022 06:09:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666357793; cv=none; d=google.com; s=arc-20160816; b=X6obAlr6p2WbTrctaiqP91drElzpD/LaJ6qHuYFoPLsGEXTl7vUyVm+g31pM2iykUw c69VALD/QWxM26atylwL/oo0Q39hiJhOaozkT8mweSrUaB+PlSN8Ls9wGxZap56gyIxh w/ZQV7UwdjGePt00UtBTQb0kJXweq9u1V6iLD/9fLFC4/JV53IvLI8xon1Ygr1Uro1JI 4Oveyq54QsbOiwTEH4DoFls1O2ZsjholrG9ogPs/hY9mdP2kAXD3Sa/Dke0sBJYPvqvX PNDl/IAWoLiBDGPjkLk/zlV3A3/pfwL9eo1ktNWRdioMT3Nzl+Sl3pz+5T4vaN2Mxg/m a3Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZsL6rLEb0UF2ncO40TIN5Bu/cFZuE7FVkpR01PQr7Dk=; b=MeHlTYhT58xi5Ls1JAJA1MHRXsbj5HPh0mtktETLypE8Yz5fF74zBOwob/5JJZveAP Kb4CFzVFez74k6y28Q37+jzCycFAezjHP7kBKkPo15q1ei4Btf9ykFPaynwhmEsY5B6w fMC2NwaOLwGAT5AJiTCgPFWYJcQx2oqi3pOteGl3GsydzX3vF2CnnMYFhEmwlHRt4yKC kv/dhPTWW1asGGuM750Jp3LLuYrmWGeldWeUlhYhPBz8RU9d0I1l2rR6N9JbSJGK4pdP /X9LydYaLFvxFRCA/k+1sBA35+aljgOEiY43+aXlJE/covavOD3As6yX3AVachwLELH+ 1xvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pAkgaXyi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y19-20020a056402271300b0045d9a3adf19si14781992edd.564.2022.10.21.06.09.27; Fri, 21 Oct 2022 06:09:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pAkgaXyi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230293AbiJUNHL (ORCPT + 99 others); Fri, 21 Oct 2022 09:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbiJUNGZ (ORCPT ); Fri, 21 Oct 2022 09:06:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 224C826CDE6; Fri, 21 Oct 2022 06:06:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A93F161EA3; Fri, 21 Oct 2022 13:06:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ED38C43470; Fri, 21 Oct 2022 13:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666357579; bh=LBaEFSh5DOeyzDGsOyxhMwQpssm5JK6u2HESg5ybNII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pAkgaXyiv8pAQmQv5zw0PS1FBjghpTjn/+TC5F1qoVrIhLFKWhVZhkykR9YVZDftb 0gvUciPyF8NPSjTQoDmZzrpREJvKzc3SEH0D94VojrUhWRJAPYDt7BkZ92qmUm2YV1 HNU03eZI2/8YPtlqegsQcDdM/eWg1nealcAZHLzfm4oPfXqs0Nw0mZ++2Jmm6QmYBb NUMWmb3sJLfEKoBlTN/vsVY/71rC4StDmuft8LwpOWTMO7YIfORfEW3Q4yGBnMEpj6 u/+aMApkoVUwyk6JCZ1dq1yaexLhZP0AOc0Shj9z1encZN2QKLppMJt/+IrfH2fslP y15IEoy/SuYLw== From: Jeff Layton To: tytso@mit.edu, adilger.kernel@dilger.ca, djwong@kernel.org, david@fromorbit.com, trondmy@hammerspace.com, neilb@suse.de, viro@zeniv.linux.org.uk, zohar@linux.ibm.com, xiubli@redhat.com, chuck.lever@oracle.com, lczerner@redhat.com, jack@suse.cz, bfields@fieldses.org, brauner@kernel.org, fweimer@redhat.com Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: [PATCH v8 6/8] nfsd: move nfsd4_change_attribute to nfsfh.c Date: Fri, 21 Oct 2022 09:06:00 -0400 Message-Id: <20221021130602.99099-7-jlayton@kernel.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221021130602.99099-1-jlayton@kernel.org> References: <20221021130602.99099-1-jlayton@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747302789847293387?= X-GMAIL-MSGID: =?utf-8?q?1747302789847293387?= This is a pretty big function for inlining. Move it to being non-inlined. Reviewed-by: NeilBrown Signed-off-by: Jeff Layton --- fs/nfsd/nfsfh.c | 27 +++++++++++++++++++++++++++ fs/nfsd/nfsfh.h | 29 +---------------------------- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index d73434200df9..7030d9209903 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -748,3 +748,30 @@ enum fsid_source fsid_source(const struct svc_fh *fhp) return FSIDSOURCE_UUID; return FSIDSOURCE_DEV; } + +/* + * We could use i_version alone as the change attribute. However, + * i_version can go backwards after a reboot. On its own that doesn't + * necessarily cause a problem, but if i_version goes backwards and then + * is incremented again it could reuse a value that was previously used + * before boot, and a client who queried the two values might + * incorrectly assume nothing changed. + * + * By using both ctime and the i_version counter we guarantee that as + * long as time doesn't go backwards we never reuse an old value. + */ +u64 nfsd4_change_attribute(struct kstat *stat, struct inode *inode) +{ + if (inode->i_sb->s_export_op->fetch_iversion) + return inode->i_sb->s_export_op->fetch_iversion(inode); + else if (IS_I_VERSION(inode)) { + u64 chattr; + + chattr = stat->ctime.tv_sec; + chattr <<= 30; + chattr += stat->ctime.tv_nsec; + chattr += inode_query_iversion(inode); + return chattr; + } else + return time_to_chattr(&stat->ctime); +} diff --git a/fs/nfsd/nfsfh.h b/fs/nfsd/nfsfh.h index c3ae6414fc5c..4c223a7a91d4 100644 --- a/fs/nfsd/nfsfh.h +++ b/fs/nfsd/nfsfh.h @@ -291,34 +291,7 @@ static inline void fh_clear_pre_post_attrs(struct svc_fh *fhp) fhp->fh_pre_saved = false; } -/* - * We could use i_version alone as the change attribute. However, - * i_version can go backwards after a reboot. On its own that doesn't - * necessarily cause a problem, but if i_version goes backwards and then - * is incremented again it could reuse a value that was previously used - * before boot, and a client who queried the two values might - * incorrectly assume nothing changed. - * - * By using both ctime and the i_version counter we guarantee that as - * long as time doesn't go backwards we never reuse an old value. - */ -static inline u64 nfsd4_change_attribute(struct kstat *stat, - struct inode *inode) -{ - if (inode->i_sb->s_export_op->fetch_iversion) - return inode->i_sb->s_export_op->fetch_iversion(inode); - else if (IS_I_VERSION(inode)) { - u64 chattr; - - chattr = stat->ctime.tv_sec; - chattr <<= 30; - chattr += stat->ctime.tv_nsec; - chattr += inode_query_iversion(inode); - return chattr; - } else - return time_to_chattr(&stat->ctime); -} - +u64 nfsd4_change_attribute(struct kstat *stat, struct inode *inode); extern void fh_fill_pre_attrs(struct svc_fh *fhp); extern void fh_fill_post_attrs(struct svc_fh *fhp); extern void fh_fill_both_attrs(struct svc_fh *fhp);