From patchwork Fri Oct 21 02:20:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 6482 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp437823wrr; Thu, 20 Oct 2022 19:25:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7nbRrZzxQ69lhthl7FHddr8hbxRmBgCY+VTQeJNHCOyQggCXA0h14U8HnUhid5a9s8jfBY X-Received: by 2002:a17:903:100c:b0:186:63a1:3b5d with SMTP id a12-20020a170903100c00b0018663a13b5dmr6160950plb.148.1666319137349; Thu, 20 Oct 2022 19:25:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666319137; cv=none; d=google.com; s=arc-20160816; b=kTOd12GhlPp7RO/wLi86s9OxagfualAgpXoPc23ovO8EhagrE55IYaLr+Kqa6N4CMU eF5C6McmBhgBinXTPaLgCwRzKHaTjotZwBRnkD9eiaDBUSk1Kjzn2DnRxJhEhw9d2ZCB Z26EnLJXjRCiMx7zB9m1J3Lix/o2LfNdOTMNjcE68NA+Ym7qkvbfa9zc7V+euf8Y48Fv S9nHupoy45he+OP/KwiP07gyGX+jAprG3yg5iSqrM5CbUfzC0+Bwbuufvyj8vYhv2tYa bU5Pqk8mCNNFF9zyLiLxHHayvQZgtqK86wMZYXNJ5nUhIkQnnszTkhOIkC1bRz80zeYu BCjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1tpP1hkNdWvN34AYxj6RVP7WehDDZKUj72Nls7FxEGk=; b=MHGKkwjb7QH4Cx2sf43xFbrTmFLr+upqFq9yljk6WAWsYrKmsOXzvbB7XbcQWy0Z2k e8VgkVgrcRD8L3SAzYYXQucyYXEzaaHHPBAFWZTrbmEuYCZJod60qa/YV8jmgYOVZYWV h7CeFpXniaJqTluyqgYFqV7yvpsU7a6ZPEXPLN9vXqRMN5ZOR/+tgI3QUjBps7r4K8FZ T1LSDZSvqRKPZius8AFVMM1nVHQSFUZ+l/RCMNDoY5hATTd6Dr8Kn78NPtyW+h1yK3kS M4h/AbcmIRMkWwCZxKRvuQrAvSGIMkpSIDwzcowsg/penOVzVugZ3kmfF2IrgoCJ77HU m1CQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t20-20020a056a00139400b0052ea6666960si25474070pfg.337.2022.10.20.19.25.25; Thu, 20 Oct 2022 19:25:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbiJUCWz (ORCPT + 99 others); Thu, 20 Oct 2022 22:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbiJUCWr (ORCPT ); Thu, 20 Oct 2022 22:22:47 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0656522BAEA for ; Thu, 20 Oct 2022 19:22:45 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Mtp7b16HRzpVdt; Fri, 21 Oct 2022 10:19:23 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct 2022 10:22:43 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct 2022 10:22:42 +0800 From: Yang Yingliang To: , , , , , , CC: , , , , , , , , , , , , , , , Subject: [PATCH 07/11] f2fs: fix possible memory leak in f2fs_init_sysfs() Date: Fri, 21 Oct 2022 10:20:58 +0800 Message-ID: <20221021022102.2231464-8-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221021022102.2231464-1-yangyingliang@huawei.com> References: <20221021022102.2231464-1-yangyingliang@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747262256012456967?= X-GMAIL-MSGID: =?utf-8?q?1747262256012456967?= Inject fault while loading module, kset_register() may fail, if it fails, but the refcount of kobject is not decreased to 0, the name allocated in kobject_set_name() is leaked. Fix this by calling kset_put(), so that name can be freed in callback function kobject_cleanup(). unreferenced object 0xffff888101b7cc80 (size 8): comm "modprobe", pid 252, jiffies 4294691378 (age 31.760s) hex dump (first 8 bytes): 66 32 66 73 00 88 ff ff f2fs.... backtrace: [<000000001db5b408>] __kmalloc_node_track_caller+0x44/0x1b0 [<000000002783a073>] kstrdup+0x3a/0x70 [<00000000ead2b281>] kstrdup_const+0x63/0x80 [<000000003e5cf8f7>] kvasprintf_const+0x149/0x180 [<00000000c4d949ff>] kobject_set_name_vargs+0x56/0x150 [<0000000044611660>] kobject_set_name+0xab/0xe0 Fixes: bf9e697ecd42 ("f2fs: expose features to sysfs entry") Signed-off-by: Yang Yingliang Reviewed-by: Chao Yu --- fs/f2fs/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index df27afd71ef4..2ef7a48967be 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -1250,8 +1250,10 @@ int __init f2fs_init_sysfs(void) kobject_set_name(&f2fs_kset.kobj, "f2fs"); f2fs_kset.kobj.parent = fs_kobj; ret = kset_register(&f2fs_kset); - if (ret) + if (ret) { + kset_put(&f2fs_kset); return ret; + } ret = kobject_init_and_add(&f2fs_feat, &f2fs_feat_ktype, NULL, "features");