From patchwork Fri Oct 21 02:20:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 6477 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp437380wrr; Thu, 20 Oct 2022 19:24:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM44xQuAsW1nbV8CZqgs4mG4kXafol6ckq62mNsosBM9umrtyrcgVvFNV7RVjDbe0p3FODPX X-Received: by 2002:a05:6402:51c9:b0:45d:5efe:d1a3 with SMTP id r9-20020a05640251c900b0045d5efed1a3mr14930839edd.58.1666319050020; Thu, 20 Oct 2022 19:24:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666319050; cv=none; d=google.com; s=arc-20160816; b=AGJLky5xpqZRhEUxwNz/nN4N90NIA++xrmb0lKXhGKKsu8qjR9fJ5BOJwk+S+p5swC 2UJ4XPcp1QI6QacVkSRbahs7PN/1S+GaqKlYuJPp0jAIPck82xHVk//LTohADrmIhj14 jJCxdM0/ymPOCQwIPuG2li7kSv2UTrBZ8yq2UZB+t5TSoQE0sZTEJcrq3cfPaGE1wU85 9YhurkWKY4ynW0jp1MV/zLzJrPbrE3tix5AiT1WflIHF3ls0I4vMKUM6klS0pJsX3DbJ mh8QGoEmZtNIGXVBBAzo+O+ykhZuybLNCx3S9/RNivC9UgZSuETARNrUvJot+MKpLijj MYDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WSEXmwx0N4x8ur/qaN3uPQl5/rYkkcR4UAdgcwqWvX0=; b=0DAeVd0hgMU3VFJAph6dYKtZtbZwU4S/4T1Y7Lr/6wk2h8AE95zlbgC7Txw3D+Dv0g yVQEdmHp+438/mU3bbernq6Hbcctj4PEP50KU8c+0c3ALprSSjn6e9E3r6XXc7d9P4DN Ak1X06FMIEodBXTBzj7ofQ1XIB0V6qgCmQrdrNjDBg3edBceZhL4uK1sUedpAO6c26Z9 LUr1dH2xVHDL8jEPnZBadcIUVKRFWAogiIz2T7G4WRZpnZkINuw6aRIrwAmER8rJi7xp WbkciQyEl57rSRlw8XAbHisMyTYsqx8sf6UULOQ3I2mYTuWShrks/mARHEmVOk/mWIFc wnUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n13-20020a05640205cd00b004485081f004si20977295edx.598.2022.10.20.19.23.45; Thu, 20 Oct 2022 19:24:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbiJUCWv (ORCPT + 99 others); Thu, 20 Oct 2022 22:22:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbiJUCWo (ORCPT ); Thu, 20 Oct 2022 22:22:44 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09657226580 for ; Thu, 20 Oct 2022 19:22:44 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Mtp5w3XNvz1P7D4; Fri, 21 Oct 2022 10:17:56 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct 2022 10:22:42 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct 2022 10:22:41 +0800 From: Yang Yingliang To: , , , , , , CC: , , , , , , , , , , , , , , , Subject: [PATCH 06/11] firmware: qemu_fw_cfg: fix possible memory leak in fw_cfg_build_symlink() Date: Fri, 21 Oct 2022 10:20:57 +0800 Message-ID: <20221021022102.2231464-7-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221021022102.2231464-1-yangyingliang@huawei.com> References: <20221021022102.2231464-1-yangyingliang@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747262164152263990?= X-GMAIL-MSGID: =?utf-8?q?1747262164152263990?= Inject fault while loading module, kset_register() may fail, if it fails, but the refcount of kobject is not decreased to 0, the name allocated in kobject_set_name() is leaked. To fix this by calling kset_put(), so that name can be freed in callback function kobject_cleanup() and 'subdir' is freed in kset_release(). unreferenced object 0xffff88810ad69050 (size 8): comm "swapper/0", pid 1, jiffies 4294677178 (age 38.812s) hex dump (first 8 bytes): 65 74 63 00 81 88 ff ff etc..... backtrace: [<00000000a80c7bf1>] __kmalloc_node_track_caller+0x44/0x1b0 [<000000003f0167c7>] kstrdup+0x3a/0x70 [<0000000049336709>] kstrdup_const+0x41/0x60 [<00000000175616e4>] kvasprintf_const+0xf5/0x180 [<000000004bcc30f7>] kobject_set_name_vargs+0x56/0x150 [<000000004b0251bd>] kobject_set_name+0xab/0xe0 [<00000000700151fb>] fw_cfg_sysfs_probe+0xa5b/0x1320 Fixes: 246c46ebaeae ("firmware: create directory hierarchy for sysfs fw_cfg entries") Signed-off-by: Yang Yingliang --- drivers/firmware/qemu_fw_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index a69399a6b7c0..d036e69cabbb 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -544,7 +544,7 @@ static int fw_cfg_build_symlink(struct kset *dir, } ret = kset_register(subdir); if (ret) { - kfree(subdir); + kset_put(subdir); break; }