diff mbox series

[PATCHv4,11/13] regulator: rk808: Use dev_err_probe

Message ID 20221020204251.108565-12-sebastian.reichel@collabora.com
State New
Headers
Series Introduce RK806 Support |

Commit Message

Sebastian Reichel Oct. 20, 2022, 8:42 p.m. UTC 
  Print error message for potential EPROBE_DEFER error using
dev_err_probe, which captures the reason in
/sys/kernel/debug/devices_deferred and otherwise silences
the message.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 drivers/regulator/rk808-regulator.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Mark Brown Nov. 25, 2022, 7:33 p.m. UTC | #1 
On Thu, Oct 20, 2022 at 10:42:49PM +0200, Sebastian Reichel wrote:
> Print error message for potential EPROBE_DEFER error using
> dev_err_probe, which captures the reason in
> /sys/kernel/debug/devices_deferred and otherwise silences
> the message.

This doesn't apply against current code, please check and resend.
Sebastian Reichel Nov. 25, 2022, 11:46 p.m. UTC | #2 
Hi Mark,

On Fri, Nov 25, 2022 at 07:33:32PM +0000, Mark Brown wrote:
> On Thu, Oct 20, 2022 at 10:42:49PM +0200, Sebastian Reichel wrote:
> > Print error message for potential EPROBE_DEFER error using
> > dev_err_probe, which captures the reason in
> > /sys/kernel/debug/devices_deferred and otherwise silences
> > the message.
> 
> This doesn't apply against current code, please check and resend.

That's expected. Patch 2 changes the dev parameter of dev_err(),
which is being changed to dev_err_probe() in this patch.

I think we are getting too close to the merge window for this
series considering it's touching so many subsystems. But you
can take patch 2 + 11 to the regulators tree as is.

Thanks for the review,

-- Sebastian
diff mbox series

Patch

diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index ce9c64cadeba..fa9fc1aa1ae3 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -1343,11 +1343,9 @@  static int rk808_regulator_probe(struct platform_device *pdev)
 	for (i = 0; i < nregulators; i++) {
 		rk808_rdev = devm_regulator_register(&pdev->dev,
 						     &regulators[i], &config);
-		if (IS_ERR(rk808_rdev)) {
-			dev_err(&pdev->dev,
-				"failed to register %d regulator\n", i);
-			return PTR_ERR(rk808_rdev);
-		}
+		if (IS_ERR(rk808_rdev))
+			return dev_err_probe(&pdev->dev, PTR_ERR(rk808_rdev),
+					     "failed to register %d regulator\n", i);
 	}
 
 	return 0;