From patchwork Thu Oct 20 16:26:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 6292 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp206284wrr; Thu, 20 Oct 2022 09:33:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7vdyUHQIpv/5mtaNnB6D2D6PYBtzMQiFnofYyQ31Whu3wpY6o5c1m10vLwVCcRDu1CCyqn X-Received: by 2002:a17:90a:460d:b0:20c:1147:bf32 with SMTP id w13-20020a17090a460d00b0020c1147bf32mr51577061pjg.24.1666283579802; Thu, 20 Oct 2022 09:32:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666283579; cv=none; d=google.com; s=arc-20160816; b=SV8K9wgXRPbT5ui045u4OsQtf+gL7lQMDFDIxknBRBOV6xgXefK/aWv94SjQ8nD4iL J0Z7PdqjLDuf0G5zebmpcBW9Br8CgZw/KtSAJGNrDqzWynWPZpWQ86JvaPbBF/IQotEr LY96PavUNKSlFr2GQthgWwV70Vwm3aBK1qf//l/PWjBf86p5qM1Zf5e5WkXVnxdDKNpg QSTdrW8js+FtOcxMr0TuOmiIXnBaHT3cMDji6MwkxbraH0KPip2TXj+mvuzqBXMNQGy+ SLFf9t7zdfJJJlw60pvFCLL/QAj/GAARZlJLfvk79JxCRYVxejLwChCGz9K2wwgsXArV gxhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dfxi02ZGVzhDqMslDJ3NlyYOGPoRJguQP4k7Ys09ds0=; b=kuGS7bt6J3uFnjRQYLoFkmdgzwB2kI/lhGL6jS4tM7ErIzWy+8xaPtOybtizMyc3Ld vnaNP7S+oAVKZ235po5kKQrpI5HL4aDgIR3KwClUlKlu2U4NjL280VgnzMjED40JB53Y guYn1QhAIMBAXZ/7HMkfMAAJONqiH01HS3GCHOAi6Cqwf9UdI+7P94uCUAJHypc+1a3f K7l5S4bPLFa9pvASThcSJC36nKHsBCvdH2sc5oiaCSRtLHTvfLwlFlZwg/0K9PkSYZ4+ G2lhwHghP0b4a2rFc/3ntGxiaJ9oHzUMtBHPqxsZlWIAjhpD7pDE7PLS3mymQ23g122C UlIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k6yYxprO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a655902000000b004599da2b2b6si24904164pgu.716.2022.10.20.09.32.37; Thu, 20 Oct 2022 09:32:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k6yYxprO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbiJTQ0b (ORCPT + 99 others); Thu, 20 Oct 2022 12:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbiJTQ0V (ORCPT ); Thu, 20 Oct 2022 12:26:21 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 228CB53A43; Thu, 20 Oct 2022 09:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666283179; x=1697819179; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cfcsEqumavJluV35nSU7Tp0DTMNCGeUslHFIyDpA79w=; b=k6yYxprOyXnObrgX+y0yBNIgTY6a2TvOh6r5M0Rn4CXf9rRVqbqR5tmC svPFdq2SLPPmw6+lUtSZXcYKDDj/heOdoEQN8qI6ruCMDsQdYb9i4xIu2 0er5gTZ0BuFNy5lWUsojgl+BSfUUAGV6OJ3FzZ5PB5dDrocKE8Ct6Z7ru yoNof3sJggrEMynFdCX1sqd14XDBdiibirJrZR7YpYJ9HQBfX+cUjXEMJ b6qoZ0wZ+n//TlrhDk+BxsBfryPsaAgjOw/i6lVYetXALRzaSlNHGxnVr koaQxmrIvnoJcwV00m4yxdi+KwMNqEW23N9PjfJv9cAhVJoEz7PxUAxXn A==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="287164940" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="287164940" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 09:26:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="581004360" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="581004360" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2022 09:26:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id CD6346DC; Thu, 20 Oct 2022 19:26:32 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , Jonathan Cameron Subject: [PATCH v3 4/5] spi: pxa2xx: Move OF and ACPI ID tables closer to their user Date: Thu, 20 Oct 2022 19:26:30 +0300 Message-Id: <20221020162631.68914-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221020162631.68914-1-andriy.shevchenko@linux.intel.com> References: <20221020162631.68914-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747224970715472544?= X-GMAIL-MSGID: =?utf-8?q?1747224970715472544?= There is no code that uses ID tables directly, except the struct device_driver at the end of the file. Hence, move tables closer to its user. It's always possible to access them via pointer to a platform device. Signed-off-by: Andy Shevchenko Reviewed-by: Jonathan Cameron --- drivers/spi/spi-pxa2xx.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 31927493eeb0..76046612466d 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1321,25 +1321,6 @@ static void cleanup(struct spi_device *spi) kfree(chip); } -#ifdef CONFIG_ACPI -static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { - { "INT33C0" }, - { "INT33C1" }, - { "INT3430" }, - { "INT3431" }, - { "80860F0E" }, - { "8086228E" }, - { }, -}; -MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); -#endif - -static const struct of_device_id pxa2xx_spi_of_match[] = { - { .compatible = "marvell,mmp2-ssp", .data = (void *)MMP2_SSP }, - {}, -}; -MODULE_DEVICE_TABLE(of, pxa2xx_spi_of_match); - static bool pxa2xx_spi_idma_filter(struct dma_chan *chan, void *param) { return param == chan->device->dev; @@ -1759,6 +1740,25 @@ static const struct dev_pm_ops pxa2xx_spi_pm_ops = { pxa2xx_spi_runtime_resume, NULL) }; +#ifdef CONFIG_ACPI +static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { + { "80860F0E" }, + { "8086228E" }, + { "INT33C0" }, + { "INT33C1" }, + { "INT3430" }, + { "INT3431" }, + {} +}; +MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); +#endif + +static const struct of_device_id pxa2xx_spi_of_match[] = { + { .compatible = "marvell,mmp2-ssp", .data = (void *)MMP2_SSP }, + {} +}; +MODULE_DEVICE_TABLE(of, pxa2xx_spi_of_match); + static struct platform_driver driver = { .driver = { .name = "pxa2xx-spi",