| Message ID | 20221020095934.1659449-4-peng.fan@oss.nxp.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp9149wrr;
Thu, 20 Oct 2022 03:01:04 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM747OYB6Ym6lO58HUDRTPh9skVedtC/7sGV0KII0k2PRpcCPeruVC8rFpKtCNz0/KGGTIH+
X-Received: by 2002:a17:906:ee86:b0:741:89bc:27a1 with SMTP id
wt6-20020a170906ee8600b0074189bc27a1mr10460779ejb.725.1666260053031;
Thu, 20 Oct 2022 03:00:53 -0700 (PDT)
ARC-Seal: i=2; a=rsa-sha256; t=1666260053; cv=pass;
d=google.com; s=arc-20160816;
b=JsrwmdBNMSlJxnR5RMOxYao9PaIjVtCg1YSmNicIYpLv1x+08QEcsYJ/B4FQrA7W3/
p/hcNP7lckTDQuprs6r4oAt6SX/N2pMyc+0FpA7gKGlTJu+YORfUW0ebtdXe3qwd0RvH
3rSQWzGIxvNwJCx4Wx3AfHzKkaYRAw4sZLg4Ku0oXcPyqnSX6aSI/jyiOtSWXtTjVizt
ORHLpd58yDxqmItVMIhr/T9E5kOP9CVU2ldbcwnAaic82X4qk6z9TkB/tpEHSI5dS/+W
zneIaEhxNxgBpdutpGpCvvyOvybhm6ATllkCEziRLWchwCRwOk81mn5mfXj3NjsIfpdh
7U6w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:content-transfer-encoding
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=VBXjdRB0++g9Slb/jRrA+HS5bgqM2cbPRvV1kiZgpvg=;
b=qlHKCeDo+W/YeDG/q6ATzkgy1rbkEHiFLGG5DQyBXMKG5ts5SiF2PMFpl8K4C4owOO
ba8qzGUcHB5PRz8Z+IKQnLxDJPk+/dHNs2mGuUrfllq22RpmYBXeCOMNmv73fwzZycm+
TUCwQs/iqTAQt6U6K/vRJ4ZleMejBhXdmurYJpmcEVWO4kA2cH/56rUoVhWm1xCujLuX
Tp+6XberuK6TWE3AGx3kPqqMd2uwNt+RpmIoH48fCGvRwZDHGR2Irk2rd/44PuVDlw5p
LHHSt0d964fs8ohrHurCkNZW5cMbd2Omue4JnntYZ+9or2tD4982yXQF9ZCCKdyPsosg
Jcig==
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@NXP1.onmicrosoft.com
header.s=selector2-NXP1-onmicrosoft-com header.b=JGRFGrTV;
arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass
dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com);
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
cw17-20020a170906479100b00781132a4ca6si15469398ejc.850.2022.10.20.03.00.28;
Thu, 20 Oct 2022 03:00:53 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@NXP1.onmicrosoft.com
header.s=selector2-NXP1-onmicrosoft-com header.b=JGRFGrTV;
arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass
dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com);
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229998AbiJTJ6f (ORCPT <rfc822;realc9580@gmail.com> + 99 others);
Thu, 20 Oct 2022 05:58:35 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39376 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229784AbiJTJ6b (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 20 Oct 2022 05:58:31 -0400
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
(mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 817451CF557;
Thu, 20 Oct 2022 02:58:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Mt9NMQhiv2A8ZVOxxBzm1puu401jSwSUwYlvQBOhkyq+3Iz68cLjXHWFVxXW/1iPVDOJrFmWOPiS/RvHJhDCgAtR075edEt+ez8+WoWNqVejkxCEmdNBdQpXdBoaDF5F5kW0r/gLDR9Ie2ftvuxvaIPdjhzHIxdZy0hBB9TGMi2ER+FG09LkyBethoDsvaMPYXx7OUSdCYEc9o0ndGqIZy4A6Ai6IfGDei8vuk/es0ChZbHW6AyS+1i9FyIkQgZdY5Ok39qIIJWHFWaNJykifbgQH6NciFh7eYNMkfWebXyJKP5kHJbbVhTB730uuQw2rk+q9kXvA5aldIsnA8shqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=VBXjdRB0++g9Slb/jRrA+HS5bgqM2cbPRvV1kiZgpvg=;
b=VHcLD6qPqLb0ms57Z17Khw0hi9xL+xvz3gFShGdGdS19aFCsfhS+/XiMljH2ilk9ofpB1DB8NVIn+Fian+mdJsICibzoAzgeW35O72dheZAG24oJMhcoWmVG/MPcvk2DfOh9dJngQ5kjRsb/wSvI5iQtE6BmJQvQ+ujRzJ+EX7RqwR6uUTmI0xhlOd2n4g3fIeRMn+olW/FjeHvtVG470nlAJavLBPcmWxr++5VYO3qaJcshadZdChDL0voGxoqKdDaz2Tdf8QNnVWTI+0LqOBZ1o/k0it3PZKuy7aZemuY363ohPObElTH3evH9iKv058kxveQMAqfIj5N6sL85aw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
s=selector2-NXP1-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VBXjdRB0++g9Slb/jRrA+HS5bgqM2cbPRvV1kiZgpvg=;
b=JGRFGrTV2GMhV5mkUFLFsbjjsKveGi84c6z7jaEYa4/dehrmuscgxOcJRk8GnW0mkXRLGPJHTKw7LGsuDns/WXIdERsp6cEkTKaRQ0pqOSKpS/mir4VYOUZpdtH74T1wQYpOwacQCDERPY85cy3/egA6l6V9doeNHwyZ0BKKTlQ=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=oss.nxp.com;
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
2022 09:58:26 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
([fe80::a5ff:3d28:4bbc:e1ed]) by DU0PR04MB9417.eurprd04.prod.outlook.com
([fe80::a5ff:3d28:4bbc:e1ed%6]) with mapi id 15.20.5723.032; Thu, 20 Oct 2022
09:58:26 +0000
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 03/15] arm64: dts: imx8mp-evk: fix BUCK/LDO voltage
Date: Thu, 20 Oct 2022 17:59:22 +0800
Message-Id: <20221020095934.1659449-4-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221020095934.1659449-1-peng.fan@oss.nxp.com>
References: <20221020095934.1659449-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SI2PR04CA0008.apcprd04.prod.outlook.com
(2603:1096:4:197::20) To DU0PR04MB9417.eurprd04.prod.outlook.com
(2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS8PR04MB8039:EE_
X-MS-Office365-Filtering-Correlation-Id: 3eb2123b-e761-4c53-7f34-08dab281a1d2
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
/R7dgCYNAeKxZXCfZcILkx67eZYxT1f55v9Nfzqyhsy2ALJf+95U+a0K/ZfycH2DxkfwyB/YW6wUoRTqcQsH0GiLtFxBiO2KzYGQARH2/d/Z/UxvqeALO1L+cdLVTn7zmdB+4yIASftofZSuiWAx/86YJd8jo+DjgwXNr/81d91dQezewKIZc7pwDt47ey41TMFBPxUldmxdvGVMmQ0HnumfoZGHRhJdgtnAqYHxWFveCSvFe3ZQCLTxLWbrC3pH7PZe+9Nf7rAiwTBE+clNK31wDZDxL4aXmXcFD2vLtZuqqbC+e+5rf+Qov/TvXe0zFDl5bQ/zG0olUY7agORsXCAH5Mw1HwcNjLEwQfO0H3iA7MCBqDdQvJzw1st1nPhDTdZ0x/7ECCK7WoiZS0wsmeR3trpl0SVy+x9SHUlLY4g6Z1F7Eb3/m5/lOOmrz9PqUjHv8GTAEBA9WjajALWxnW7eiQYxTUWCumdgo0DphujXyJKSc2wIJhbDW4fCDlCn8Wu4zD22nRemUb5UDnKj5If8tAV4RzKb34lTZqqpjkaDunQuxlQRhtEZtrLHFC8IaBTmxHeuGEdmmDW3Qz/WvTEvXEAjK37bRzsxlKBu1yTvn5P0gUBMEbV9iF7kEmB3TX3W0oB9Diak4eGxWB/uqa7G6r+COsVxDX5SEvELbcIeui62g8PlgqNPFspv4c//AbqJhp5pMbpEJJWlDEx0YSVEVg3R7qsPp+BCp68fUGXFFusrrYCKMAfUUP01TX3j7cwJh237KZIz9Qh9EXpJ6eMbJ7oSWM9F2JB/IFk/aY4=
X-Forefront-Antispam-Report:
CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199015)(6486002)(83380400001)(478600001)(86362001)(66946007)(66556008)(6666004)(26005)(41300700001)(6512007)(4326008)(8676002)(8936002)(66476007)(38100700002)(2616005)(2906002)(38350700002)(1076003)(186003)(5660300002)(6506007)(52116002)(316002)(32563001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?tvj11KqsHzgkDapfJYeBW+r8nUfn?=
=?utf-8?q?xZgRKFNsufV68+n0FGdpVrCFKvc5S8j8OExlfG+MFQr6jDqhedxUp9wMT/rS69939?=
=?utf-8?q?RCfWIj95xAg0JcJfhclvpabHh7XQ2re5v/o9GR9gXMV/TTXNQall5/EJTlepTiipX?=
=?utf-8?q?NysxIrLJ1232S8JSZXbRI8hjnWzG1aroSPRZbf6O58Hess37aWwRVrI9pIdXsoITQ?=
=?utf-8?q?GKY/HbfaZAgDVcmTvvlLiSl5rV7MRjlp2QGWmgr1tOqoDdK8+SfBoHcwOMOIEMThf?=
=?utf-8?q?x3WFx165XTTjrS3IAcwzsWkgce+lUoPOvMqF+Gg3DXS4STkEKQi+N9p1u4zDmv676?=
=?utf-8?q?OUyMViOqss9t3nx/XKiaCerp2/+zY19aM57C3Y3QNX6PT/GUfzGreaRzCb8uPBPCU?=
=?utf-8?q?/YmO9wDbMie1u4+sQv+9MapXslaQz+lifoU5A+O8e+DbcRj0AUcEHm/cl/RWiJ2Tq?=
=?utf-8?q?KxHrQLwcXRT0Cny9IRPa4j75LhLzGJWO2pqaxoGIXSU8XXyIc4uOHk+0x4G2oleI4?=
=?utf-8?q?CDyMDxkfK11kYF3Wf6Ct4aFuT90kk4urtRasd2FSjaGGjYng3sUs59MuU5KEnMtfG?=
=?utf-8?q?mEvCm+jOM0RttBX/TNoh52yLDI7ZoMczRV00HYJmT9k/i9uui8Rd7nof60iQZ6FOY?=
=?utf-8?q?kAtBkR5dBSLMQcRoRueEld6k05QKPJF2/PyLSquUtkRXZqjBeV4U6uTSNraQy2uM8?=
=?utf-8?q?s5Xh9vAdKbOFMOpAlRWUgiWeg6NpPBC3urqOOlktVd6PM0HeV05245MQNXviByMvF?=
=?utf-8?q?8R9JuRtJh2JId0iS7FfbM/fFYhkfaoeICgwCuZ+CHmIKcJiDL0Td4KkoPAoLNFmLt?=
=?utf-8?q?tBKKG3lp+l2pt9pmtg4nFAHpER6BRHZmIFmtMPx0dceR/N5F5SGLZlQanIzU/f+rg?=
=?utf-8?q?mbVvQnUt+anDGCKURIrBwIxQR77JpbiXo1BD6nXVNNwedIPGvT1mR2UGvVSA1b790?=
=?utf-8?q?W8x8Y9KSBBFiPvL8BsrCc8B2BP99gQ9wuduq7RKQk1W5myzAGYi4WFVtUVzfr+T85?=
=?utf-8?q?hY7b8LMBYWU5lVTy9hYga1rH/lbMCzjXc1iXjZfRuz1HDM1MYHTUjojm02dN0UqV0?=
=?utf-8?q?5TCHyyJsx/G3ZTwiQUEMFXIRWfScgPhdFueK06scEG7OVGMELXkolugR9rAqAr7A/?=
=?utf-8?q?4jvz5tKBUtMjIQxyTMWJkQfnJF8FK5U0Lt0ZA0L+dSQZdDuq0Zo5jPqFTYwc0tUFt?=
=?utf-8?q?Z9z2ypFC+qJlvpk/1WiKeapXmMt1lTBNVrTD94T4bXcjKWpQJfY6hTdM2pI8JG6Cq?=
=?utf-8?q?Vpt/aUVQZJr2yXlV//yP4A8SeRRY63PNZ6LRFD2LnRLk1AuUf0q84r5I/HyDMmZgf?=
=?utf-8?q?jTXHLv1SXD3ZJcvoP4OJXViCqgritAGixCpDAkLF1E/g6sUl+dN2D5vCf6dK8dSvh?=
=?utf-8?q?WgJeE4g1F7/dMOIovtsb+49A5mRxlQP/izNp+e0W7p/8LWQ0jK+O7eWBOQ4V64p4+?=
=?utf-8?q?8zNCotpY04BivPzkfa4giyriyhklwNe6gaj1CfoqGuSF/9MwCfb5o1ObGsFV53N41?=
=?utf-8?q?lFfe03b5eCLG?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id:
3eb2123b-e761-4c53-7f34-08dab281a1d2
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:58:26.4297
(UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName:
QWoxTzXlif+shdGkzDi7ZlMrwls97KSsjZ2i5qHMlgWjBCVYKiD/PWO+DgX2DNGlM1XQMX3h6KjIPAxY1mBECw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747200301490300088?=
X-GMAIL-MSGID: =?utf-8?q?1747200301490300088?=
|
| Series |
arm64: dts: imx8m-evk: misc dts update
|
|
Commit Message
Peng Fan (OSS)
Oct. 20, 2022, 9:59 a.m. UTC
From: Peng Fan <peng.fan@nxp.com> Per PCA9450C datasheet, the voltage range as below: BUCK1 0.6 - 2.1875 BUCK2 0.6 - 2.1875 BUCK4 0.6 - 3.4 BUCK5 0.6 - 3.4 BUCK6 0.6 - 3.4 LDO1 1.6-1.9, 3.0-3.3 LDO2 0.8 – 1.15 LDO3 0.8 - 3.3 LDO4 0.8 - 3.3 LDO5 1.8 - 3.3 So correct them, and also add LDO[2,4] Fixes: 5497bc2a2bff ("arm64: dts: imx8mp-evk: Add PMIC device") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 44 +++++++++++++------- 1 file changed, 30 insertions(+), 14 deletions(-)
Comments
Hi Peng, On 22-10-20, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Per PCA9450C datasheet, the voltage range as below: > BUCK1 0.6 - 2.1875 > BUCK2 0.6 - 2.1875 > BUCK4 0.6 - 3.4 > BUCK5 0.6 - 3.4 > BUCK6 0.6 - 3.4 > > LDO1 1.6-1.9, 3.0-3.3 > LDO2 0.8 – 1.15 > LDO3 0.8 - 3.3 > LDO4 0.8 - 3.3 > LDO5 1.8 - 3.3 > > So correct them, and also add LDO[2,4] In the DTS you specify voltage constraints for a specific hardware and not the one supported by the PMIC. What the PMIC supports (min/max) is specified within the driver. Regards, Marco > > Fixes: 5497bc2a2bff ("arm64: dts: imx8mp-evk: Add PMIC device") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 44 +++++++++++++------- > 1 file changed, 30 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > index b4c1ef2559f2..a4cddc5a8620 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > @@ -248,8 +248,8 @@ pmic@25 { > regulators { > BUCK1 { > regulator-name = "BUCK1"; > - regulator-min-microvolt = <720000>; > - regulator-max-microvolt = <1000000>; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <2187500>; > regulator-boot-on; > regulator-always-on; > regulator-ramp-delay = <3125>; > @@ -257,8 +257,8 @@ BUCK1 { > > reg_arm: BUCK2 { > regulator-name = "BUCK2"; > - regulator-min-microvolt = <720000>; > - regulator-max-microvolt = <1025000>; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <2187500>; > regulator-boot-on; > regulator-always-on; > regulator-ramp-delay = <3125>; > @@ -268,40 +268,56 @@ reg_arm: BUCK2 { > > BUCK4 { > regulator-name = "BUCK4"; > - regulator-min-microvolt = <3000000>; > - regulator-max-microvolt = <3600000>; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <3400000>; > regulator-boot-on; > regulator-always-on; > }; > > BUCK5 { > regulator-name = "BUCK5"; > - regulator-min-microvolt = <1650000>; > - regulator-max-microvolt = <1950000>; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <3400000>; > regulator-boot-on; > regulator-always-on; > }; > > BUCK6 { > regulator-name = "BUCK6"; > - regulator-min-microvolt = <1045000>; > - regulator-max-microvolt = <1155000>; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <3400000>; > regulator-boot-on; > regulator-always-on; > }; > > LDO1 { > regulator-name = "LDO1"; > - regulator-min-microvolt = <1650000>; > - regulator-max-microvolt = <1950000>; > + regulator-min-microvolt = <1600000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1150000>; > regulator-boot-on; > regulator-always-on; > }; > > LDO3 { > regulator-name = "LDO3"; > - regulator-min-microvolt = <1710000>; > - regulator-max-microvolt = <1890000>; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo4: LDO4 { > + regulator-name = "LDO4"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <3300000>; > regulator-boot-on; > regulator-always-on; > }; > -- > 2.37.1 > > >
Hi Marco On 10/20/2022 7:02 PM, Marco Felsch wrote: > Hi Peng, > > On 22-10-20, Peng Fan (OSS) wrote: >> From: Peng Fan <peng.fan@nxp.com> >> >> Per PCA9450C datasheet, the voltage range as below: >> BUCK1 0.6 - 2.1875 >> BUCK2 0.6 - 2.1875 >> BUCK4 0.6 - 3.4 >> BUCK5 0.6 - 3.4 >> BUCK6 0.6 - 3.4 >> >> LDO1 1.6-1.9, 3.0-3.3 >> LDO2 0.8 – 1.15 >> LDO3 0.8 - 3.3 >> LDO4 0.8 - 3.3 >> LDO5 1.8 - 3.3 >> >> So correct them, and also add LDO[2,4] > > In the DTS you specify voltage constraints for a specific hardware and > not the one supported by the PMIC. What the PMIC supports (min/max) is > specified within the driver. Technically we could set board voltage to PMIC voltage range, it not damage the board from hardware level. but I am not sure whether Linux could work proper. Saying set VDD_SOC/DDR to pmic min voltage, system will crash, because it could not support higher freq. I am not sure how to proceed on this, just update commit log to say that the board voltage range could be set to pmic voltage range? Thanks, Peng. > > Regards, > Marco > >> >> Fixes: 5497bc2a2bff ("arm64: dts: imx8mp-evk: Add PMIC device") >> Signed-off-by: Peng Fan <peng.fan@nxp.com> >> --- >> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 44 +++++++++++++------- >> 1 file changed, 30 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts >> index b4c1ef2559f2..a4cddc5a8620 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts >> @@ -248,8 +248,8 @@ pmic@25 { >> regulators { >> BUCK1 { >> regulator-name = "BUCK1"; >> - regulator-min-microvolt = <720000>; >> - regulator-max-microvolt = <1000000>; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <2187500>; >> regulator-boot-on; >> regulator-always-on; >> regulator-ramp-delay = <3125>; >> @@ -257,8 +257,8 @@ BUCK1 { >> >> reg_arm: BUCK2 { >> regulator-name = "BUCK2"; >> - regulator-min-microvolt = <720000>; >> - regulator-max-microvolt = <1025000>; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <2187500>; >> regulator-boot-on; >> regulator-always-on; >> regulator-ramp-delay = <3125>; >> @@ -268,40 +268,56 @@ reg_arm: BUCK2 { >> >> BUCK4 { >> regulator-name = "BUCK4"; >> - regulator-min-microvolt = <3000000>; >> - regulator-max-microvolt = <3600000>; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <3400000>; >> regulator-boot-on; >> regulator-always-on; >> }; >> >> BUCK5 { >> regulator-name = "BUCK5"; >> - regulator-min-microvolt = <1650000>; >> - regulator-max-microvolt = <1950000>; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <3400000>; >> regulator-boot-on; >> regulator-always-on; >> }; >> >> BUCK6 { >> regulator-name = "BUCK6"; >> - regulator-min-microvolt = <1045000>; >> - regulator-max-microvolt = <1155000>; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <3400000>; >> regulator-boot-on; >> regulator-always-on; >> }; >> >> LDO1 { >> regulator-name = "LDO1"; >> - regulator-min-microvolt = <1650000>; >> - regulator-max-microvolt = <1950000>; >> + regulator-min-microvolt = <1600000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + LDO2 { >> + regulator-name = "LDO2"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1150000>; >> regulator-boot-on; >> regulator-always-on; >> }; >> >> LDO3 { >> regulator-name = "LDO3"; >> - regulator-min-microvolt = <1710000>; >> - regulator-max-microvolt = <1890000>; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + ldo4: LDO4 { >> + regulator-name = "LDO4"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <3300000>; >> regulator-boot-on; >> regulator-always-on; >> }; >> -- >> 2.37.1 >> >> >>
> Subject: Re: [PATCH 03/15] arm64: dts: imx8mp-evk: fix BUCK/LDO voltage > > Hi Marco > > On 10/20/2022 7:02 PM, Marco Felsch wrote: > > Hi Peng, > > > > On 22-10-20, Peng Fan (OSS) wrote: > >> From: Peng Fan <peng.fan@nxp.com> > >> > >> Per PCA9450C datasheet, the voltage range as below: > >> BUCK1 0.6 - 2.1875 > >> BUCK2 0.6 - 2.1875 > >> BUCK4 0.6 - 3.4 > >> BUCK5 0.6 - 3.4 > >> BUCK6 0.6 - 3.4 > >> > >> LDO1 1.6-1.9, 3.0-3.3 > >> LDO2 0.8 – 1.15 > >> LDO3 0.8 - 3.3 > >> LDO4 0.8 - 3.3 > >> LDO5 1.8 - 3.3 > >> > >> So correct them, and also add LDO[2,4] > > > > In the DTS you specify voltage constraints for a specific hardware and > > not the one supported by the PMIC. What the PMIC supports (min/max) is > > specified within the driver. > IMO, the dts properties regulator-min/max-microvolt in the regulator node should be properties to list the ability of each regulator of PMIC. If these properties is not for PMIC itself, how to define the board range using these properties? ^_^ And in the PMIC driver, no each PMIC's min/max range define. BR > Technically we could set board voltage to PMIC voltage range, it not damage > the board from hardware level. > but I am not sure whether Linux could work proper. > Saying set VDD_SOC/DDR to pmic min voltage, system will crash, because it > could not support higher freq. > > I am not sure how to proceed on this, just update commit log to say that the > board voltage range could be set to pmic voltage range? > > Thanks, > Peng. > > > > > Regards, > > Marco > > > >> > >> Fixes: 5497bc2a2bff ("arm64: dts: imx8mp-evk: Add PMIC device") > >> Signed-off-by: Peng Fan <peng.fan@nxp.com> > >> --- > >> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 44 > +++++++++++++------- > >> 1 file changed, 30 insertions(+), 14 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > >> b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > >> index b4c1ef2559f2..a4cddc5a8620 100644 > >> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > >> @@ -248,8 +248,8 @@ pmic@25 { > >> regulators { > >> BUCK1 { > >> regulator-name = "BUCK1"; > >> - regulator-min-microvolt = <720000>; > >> - regulator-max-microvolt = <1000000>; > >> + regulator-min-microvolt = <600000>; > >> + regulator-max-microvolt = <2187500>; > >> regulator-boot-on; > >> regulator-always-on; > >> regulator-ramp-delay = <3125>; > >> @@ -257,8 +257,8 @@ BUCK1 { > >> > >> reg_arm: BUCK2 { > >> regulator-name = "BUCK2"; > >> - regulator-min-microvolt = <720000>; > >> - regulator-max-microvolt = <1025000>; > >> + regulator-min-microvolt = <600000>; > >> + regulator-max-microvolt = <2187500>; > >> regulator-boot-on; > >> regulator-always-on; > >> regulator-ramp-delay = <3125>; > >> @@ -268,40 +268,56 @@ reg_arm: BUCK2 { > >> > >> BUCK4 { > >> regulator-name = "BUCK4"; > >> - regulator-min-microvolt = <3000000>; > >> - regulator-max-microvolt = <3600000>; > >> + regulator-min-microvolt = <600000>; > >> + regulator-max-microvolt = <3400000>; > >> regulator-boot-on; > >> regulator-always-on; > >> }; > >> > >> BUCK5 { > >> regulator-name = "BUCK5"; > >> - regulator-min-microvolt = <1650000>; > >> - regulator-max-microvolt = <1950000>; > >> + regulator-min-microvolt = <600000>; > >> + regulator-max-microvolt = <3400000>; > >> regulator-boot-on; > >> regulator-always-on; > >> }; > >> > >> BUCK6 { > >> regulator-name = "BUCK6"; > >> - regulator-min-microvolt = <1045000>; > >> - regulator-max-microvolt = <1155000>; > >> + regulator-min-microvolt = <600000>; > >> + regulator-max-microvolt = <3400000>; > >> regulator-boot-on; > >> regulator-always-on; > >> }; > >> > >> LDO1 { > >> regulator-name = "LDO1"; > >> - regulator-min-microvolt = <1650000>; > >> - regulator-max-microvolt = <1950000>; > >> + regulator-min-microvolt = <1600000>; > >> + regulator-max-microvolt = <3300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + LDO2 { > >> + regulator-name = "LDO2"; > >> + regulator-min-microvolt = <800000>; > >> + regulator-max-microvolt = <1150000>; > >> regulator-boot-on; > >> regulator-always-on; > >> }; > >> > >> LDO3 { > >> regulator-name = "LDO3"; > >> - regulator-min-microvolt = <1710000>; > >> - regulator-max-microvolt = <1890000>; > >> + regulator-min-microvolt = <800000>; > >> + regulator-max-microvolt = <3300000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> + ldo4: LDO4 { > >> + regulator-name = "LDO4"; > >> + regulator-min-microvolt = <800000>; > >> + regulator-max-microvolt = <3300000>; > >> regulator-boot-on; > >> regulator-always-on; > >> }; > >> -- > >> 2.37.1 > >> > >> > >>
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index b4c1ef2559f2..a4cddc5a8620 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts @@ -248,8 +248,8 @@ pmic@25 { regulators { BUCK1 { regulator-name = "BUCK1"; - regulator-min-microvolt = <720000>; - regulator-max-microvolt = <1000000>; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <2187500>; regulator-boot-on; regulator-always-on; regulator-ramp-delay = <3125>; @@ -257,8 +257,8 @@ BUCK1 { reg_arm: BUCK2 { regulator-name = "BUCK2"; - regulator-min-microvolt = <720000>; - regulator-max-microvolt = <1025000>; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <2187500>; regulator-boot-on; regulator-always-on; regulator-ramp-delay = <3125>; @@ -268,40 +268,56 @@ reg_arm: BUCK2 { BUCK4 { regulator-name = "BUCK4"; - regulator-min-microvolt = <3000000>; - regulator-max-microvolt = <3600000>; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <3400000>; regulator-boot-on; regulator-always-on; }; BUCK5 { regulator-name = "BUCK5"; - regulator-min-microvolt = <1650000>; - regulator-max-microvolt = <1950000>; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <3400000>; regulator-boot-on; regulator-always-on; }; BUCK6 { regulator-name = "BUCK6"; - regulator-min-microvolt = <1045000>; - regulator-max-microvolt = <1155000>; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <3400000>; regulator-boot-on; regulator-always-on; }; LDO1 { regulator-name = "LDO1"; - regulator-min-microvolt = <1650000>; - regulator-max-microvolt = <1950000>; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + LDO2 { + regulator-name = "LDO2"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1150000>; regulator-boot-on; regulator-always-on; }; LDO3 { regulator-name = "LDO3"; - regulator-min-microvolt = <1710000>; - regulator-max-microvolt = <1890000>; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo4: LDO4 { + regulator-name = "LDO4"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <3300000>; regulator-boot-on; regulator-always-on; };