From patchwork Wed Oct 19 23:04:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 5928 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp576524wrs; Wed, 19 Oct 2022 16:05:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5HoWhRkVIYZcpFBLlp2lYEfW0KtEdDD3cIGpYaG8dIPtWk5lrxNn+JaXTWdlJhV0v8uhuf X-Received: by 2002:a17:907:7d90:b0:78d:bc5a:913c with SMTP id oz16-20020a1709077d9000b0078dbc5a913cmr8490946ejc.390.1666220734320; Wed, 19 Oct 2022 16:05:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666220734; cv=none; d=google.com; s=arc-20160816; b=oqiSbuRhgNaIznUi25nF802S2FDszraUyL7xAW43z9ixcrKitRCjm/+Yuuxo6kJL1E d47b+BXJ3nTLEdgBSJE83B+0WyxfnXbOFePccZLivWjkTyodIbLFQrGzjZgk8C+zb7ut DtD7bJ+M/mVn5UWVatjyAb+gKoIvMxbw5cZ4L0zL96aKuj1lui9WTpQGDClS73PnrI/W fFPdcDyngXyD0btiH5kDS+o/jaK39+z4BtTz04zR+GmIBwRFMfwlR+4ODm/zmDEPxpde aNE/WqiAIzrLaxLW258i5U0cedDT9aOxGaq40fLjm8ZNR0hLi24Mm7TU4kal4R/CadGU aGHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fUtCU4kEsogL3th/B1bpR7s1fXeGGqX6ji/5tcjGGAk=; b=AtA87BKhoMvfrRvUvx6d3K72Hi0xCP490pBFeB6ACZNRHKsyUWXfiJP87CQTp5zR8E Oz2THLqhHrpuc4e7E/FAo9MkN3gGBs240ZZeWAgwKA1IDpnk8Dur5/2M7MA5+THqk55n 5wFNZHzmRlob5aAvPPWFuXceGkCh1wLFR8nBU7IMu5zj2/N9MyQv8u67L5T7IgjghzDP YV7+BK+gGkx7U1YkWfLDL+kvKARamQhnZKqMiCbhpY87iczEqJpmU2JecmnU3CJrOI/m 6NqS5GaRFvjWMiaxEjDgF7C8MqrZNxv63VGeb4A5ZOfAPd6N2hJF+VqRS0DR1kdLel27 nVbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YrX9Uiwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz13-20020a0564021d4d00b00453a0393deasi17690647edb.368.2022.10.19.16.05.09; Wed, 19 Oct 2022 16:05:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YrX9Uiwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231537AbiJSXES (ORCPT + 99 others); Wed, 19 Oct 2022 19:04:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbiJSXEO (ORCPT ); Wed, 19 Oct 2022 19:04:14 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F375B1BB946 for ; Wed, 19 Oct 2022 16:04:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1D3B6CE247B for ; Wed, 19 Oct 2022 23:04:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E0A5C433C1; Wed, 19 Oct 2022 23:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666220647; bh=7lFI8jwYjTgUuAGoBEvqrl/zt90PET5zynmRHnpkDdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YrX9Uiwq9Ld4pObV/swVMAbLV4J/q8QJ+0XwveQJ3YWIHa6NxjC1TggJimC5/JPSX s82EOo+IMq0oQpD2fIhpstg/gLAgLD4GQivPTM2FL6W2jzG5vmFZ+A8dK/qmOdopHx LrtuclBvlUEREXEM01VFp6kUiU/KtPl2PPPsRdj4ocvMm73gfv9xkAhp8KxPzPFSa4 6eBu/RI051dPFB+7uWcnr2FFu7pcSvxqNefJ3PymkM3+9TdsDv0z/u/oPvxwXfmqzT GCP1edBgu/TDKecIkfcN2MO7tYaUTNOadBqc35ePGxxZBvZNbWngPZ6mya4HHUGPq7 4r2momI8VJHzg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 2C6CB5C0879; Wed, 19 Oct 2022 16:04:07 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, kernel-team@fb.com, mingo@kernel.org Cc: elver@google.com, andreyknvl@google.com, glider@google.com, dvyukov@google.com, cai@lca.pw, boqun.feng@gmail.com, "Paul E . McKenney" Subject: [PATCH kcsan 2/3] objtool, kcsan: Add volatile read/write instrumentation to whitelist Date: Wed, 19 Oct 2022 16:04:04 -0700 Message-Id: <20221019230405.2502089-2-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20221019230356.GA2501950@paulmck-ThinkPad-P17-Gen-1> References: <20221019230356.GA2501950@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747159072630107162?= X-GMAIL-MSGID: =?utf-8?q?1747159072630107162?= From: Marco Elver Adds KCSAN's volatile instrumentation to objtool's uaccess whitelist. Recent kernel change have shown that this was missing from the uaccess whitelist (since the first upstreamed version of KCSAN): mm/gup.o: warning: objtool: fault_in_readable+0x101: call to __tsan_volatile_write1() with UACCESS enabled Fixes: 75d75b7a4d54 ("kcsan: Support distinguishing volatile accesses") Signed-off-by: Marco Elver Reviewed-by: Dmitry Vyukov Signed-off-by: Paul E. McKenney --- tools/objtool/check.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 43ec14c29a60c..a7f1e6c8bb0a7 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -999,6 +999,16 @@ static const char *uaccess_safe_builtin[] = { "__tsan_read_write4", "__tsan_read_write8", "__tsan_read_write16", + "__tsan_volatile_read1", + "__tsan_volatile_read2", + "__tsan_volatile_read4", + "__tsan_volatile_read8", + "__tsan_volatile_read16", + "__tsan_volatile_write1", + "__tsan_volatile_write2", + "__tsan_volatile_write4", + "__tsan_volatile_write8", + "__tsan_volatile_write16", "__tsan_atomic8_load", "__tsan_atomic16_load", "__tsan_atomic32_load",