Message ID | 20221019225144.2500095-12-paulmck@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp573163wrs; Wed, 19 Oct 2022 15:57:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5TGvJhotbAxKcXuFdDadeP1q8kYl+lB8qoSk7mJn+d+LeTG+nky6HDuGf6TUiTgnPYvuMJ X-Received: by 2002:a17:907:980e:b0:78d:b6d8:f53c with SMTP id ji14-20020a170907980e00b0078db6d8f53cmr8945033ejc.70.1666220260466; Wed, 19 Oct 2022 15:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666220260; cv=none; d=google.com; s=arc-20160816; b=kUTmC8lVlv9jax5cIcJaeA6sxEHoOy4hCiPx76VdysDSThBBR37bChxigmXMz1iQY5 UTHEBJA4PIJarF9pnSfkWerYX1rAmUVZyaQQ4ct3ylQZPC215Bv+/iSn9v+U2s4+aLA9 E6bZEZDmd50rbFpSPNvNmg5Wpc+UKuaSguTvUR8oTvyfo/fysRNY8mx/DT9vKIyNhZrF 53L6fUhoUbPtwrjE9N1w86i6HjyGlpZWxSAs9iS6yKzQp3STOAaAMwvO8YwSma50ohK0 PdEshw3ZyXmfFfcmT9fWakV39iW8DylXmqJ7ObKZFEtKJf2VCe7JVRv9ZpRKHCpd7/JX wpvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0k3zUguHHnriBVab5UKTW5zaQWYk29YiZfTXiF/8Q5c=; b=JsIH/9uHVH0RgFKwFjFwKo6q1hmL5UXdbhid9BWzP6Vv6Hc/b3SS7WDvwXMlDSV98u 6hkxtx5eKBOi3+M2UrLAhVwGm+KK11krMhv0sp6QxrpC7kVfimL5LUf6dZc3Q8AWMrWq wqXEe9r9jzjgTIt6n0bwciHQ5XJiBFGa30zZ3N9+tpLScZ1ftXnd2izKFQElQac6LDzh 98iF/GhSgNhn4fIsKuGAgbRKfIoM1B2JihLXkrascyqUGv7DsTQXsIcbAdt2a/5IzRvV s+GUozFMqS+Fx/kmXIqRC56AU4v+JPzN5b1GBODDnR5hFdy6sVRs9df/XIWV098G+GxG F4+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tT1EJTN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gg20-20020a170906e29400b0073d6c0facdcsi13233804ejb.259.2022.10.19.15.57.15; Wed, 19 Oct 2022 15:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tT1EJTN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231398AbiJSWwn (ORCPT <rfc822;samuel.l.nystrom@gmail.com> + 99 others); Wed, 19 Oct 2022 18:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbiJSWv4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Oct 2022 18:51:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC0B018DD58; Wed, 19 Oct 2022 15:51:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82A9EB82625; Wed, 19 Oct 2022 22:51:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E5DEC4314E; Wed, 19 Oct 2022 22:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666219907; bh=mhcpLJZcHbiLjOBEVgPlVc5Zs6jp1PTb1ytPNog7Qy4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tT1EJTN+S1m0Ws51ZJ2CUpp/35nOFOnx0Nrqc0pVhtve35sQ5QKg5oABH2+dZYKLZ RyNb2mkA1cqKxeibNUnzFKG1fEFWiia+sKd08hawKOFpC8IWO8ZfhHCpXZNL/K6O7u 2VPp3Eq6w6wzJQjfdHYniExubZP/g/wD6l6Ym1wnPRHgxKP02qp87QnouD6cXwVZPH l6zKFEZAtItER+MAkWi1Wi98W6AfmUv904rH+o3o47GOR2VMVXkr5cbCjjUMMZMIJJ 4W3x5LdBiUiryhYxg4UVe4P5+ld3HFaLo9ptC5Of3F5OAO8Z7r9+pu0E1gkUW1ODv5 uHmTOcjkhDSDA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 8B5795C0E1E; Wed, 19 Oct 2022 15:51:46 -0700 (PDT) From: "Paul E. McKenney" <paulmck@kernel.org> To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, rostedt@goodmis.org, Uladzislau Rezki <urezki@gmail.com>, Joel Fernandes <joel@joelfernandes.org>, "Paul E . McKenney" <paulmck@kernel.org> Subject: [PATCH rcu 12/14] scsi/scsi_error: Use call_rcu_flush() instead of call_rcu() Date: Wed, 19 Oct 2022 15:51:42 -0700 Message-Id: <20221019225144.2500095-12-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20221019225138.GA2499943@paulmck-ThinkPad-P17-Gen-1> References: <20221019225138.GA2499943@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747158575922366616?= X-GMAIL-MSGID: =?utf-8?q?1747158575922366616?= |
Series |
Lazy call_rcu() updates for v6.2
|
|
Commit Message
Paul E. McKenney
Oct. 19, 2022, 10:51 p.m. UTC
From: Uladzislau Rezki <urezki@gmail.com> Slow boot time is seen on KVM running typical Linux distributions due to SCSI layer calling call_rcu(). Recent changes to save power may be causing this slowness. Using call_rcu_flush() fixes the issue and brings the boot time back to what it originally was. Convert it. Tested-by: Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by: Uladzislau Rezki <urezki@gmail.com> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> --- drivers/scsi/scsi_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 6995c89792300..634672e67c81f 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -312,7 +312,7 @@ void scsi_eh_scmd_add(struct scsi_cmnd *scmd) * Ensure that all tasks observe the host state change before the * host_failed change. */ - call_rcu(&scmd->rcu, scsi_eh_inc_host_failed); + call_rcu_flush(&scmd->rcu, scsi_eh_inc_host_failed); } /**