[printk,v2,18/38] usb: early: xhci-dbc: use console_is_enabled()

Message ID 20221019145600.1282823-19-john.ogness@linutronix.de
State New
Headers
Series reduce console_lock scope |

Commit Message

John Ogness Oct. 19, 2022, 2:55 p.m. UTC
  Replace (console->flags & CON_ENABLED) usage with console_is_enabled().

Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
 drivers/usb/early/xhci-dbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Greg KH Oct. 19, 2022, 4:01 p.m. UTC | #1
On Wed, Oct 19, 2022 at 05:01:40PM +0206, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  
Petr Mladek Oct. 21, 2022, 2:27 p.m. UTC | #2
On Wed 2022-10-19 17:01:40, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> ---
>  drivers/usb/early/xhci-dbc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
> index bfb7e2b85299..b1a9c393160b 100644
> --- a/drivers/usb/early/xhci-dbc.c
> +++ b/drivers/usb/early/xhci-dbc.c
> @@ -927,7 +927,7 @@ void __init early_xdbc_register_console(void)
>  
>  static void xdbc_unregister_console(void)
>  {
> -	if (early_xdbc_console.flags & CON_ENABLED)
> +	if (console_is_enabled(&early_xdbc_console))
>  		unregister_console(&early_xdbc_console);
>  }

Again, we should rather check here if the console is in console_list.

But it is old bug. It might be fixed later. The patch does not change
the existing behavior. Feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
  

Patch

diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
index bfb7e2b85299..b1a9c393160b 100644
--- a/drivers/usb/early/xhci-dbc.c
+++ b/drivers/usb/early/xhci-dbc.c
@@ -927,7 +927,7 @@  void __init early_xdbc_register_console(void)
 
 static void xdbc_unregister_console(void)
 {
-	if (early_xdbc_console.flags & CON_ENABLED)
+	if (console_is_enabled(&early_xdbc_console))
 		unregister_console(&early_xdbc_console);
 }