diff mbox series

[3/6] arm: configs: spear6xx: Enable PL110 display controller

Message ID 20221019133208.319626-4-kory.maincent@bootlin.com
State New
Headers
Series [1/6] arm: configs: spear6xx: Refresh defconfig |

Commit Message

Köry Maincent Oct. 19, 2022, 1:32 p.m. UTC 
  From: Kory Maincent <kory.maincent@bootlin.com>

Enable the PL110 DRM driver, used by the spear600.

CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 arch/arm/configs/spear6xx_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 19, 2022, 1:38 p.m. UTC | #1 
On 19/10/2022 09:32, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
> 
> Enable the PL110 DRM driver, used by the spear600.
> 
> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.

I2C as a user-selectable option should stay. Don't remove such
(user-selectable) top-level options just because something else selected it.


Best regards,
Krzysztof
Köry Maincent Oct. 19, 2022, 1:48 p.m. UTC | #2 
Hello Krzysztof,

On Wed, 19 Oct 2022 09:38:45 -0400
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 19/10/2022 09:32, Köry Maincent wrote:
> > From: Kory Maincent <kory.maincent@bootlin.com>
> > 
> > Enable the PL110 DRM driver, used by the spear600.
> > 
> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.  
> 
> I2C as a user-selectable option should stay. Don't remove such
> (user-selectable) top-level options just because something else selected it.

As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
Why keeping something that is already automatically enabled by CONFIG_DRM?
Arnd Bergmann Oct. 19, 2022, 1:52 p.m. UTC | #3 
On Wed, Oct 19, 2022, at 15:48, Köry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 19/10/2022 09:32, Köry Maincent wrote:
>> > From: Kory Maincent <kory.maincent@bootlin.com>
>> > 
>> > Enable the PL110 DRM driver, used by the spear600.
>> > 
>> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.  
>> 
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?

It's something that DRM probably should not select, so if this
ever gets fixed in DRM, you get a broken build. Just leaving
the line in there is harmless.

      Arnd
Krzysztof Kozlowski Oct. 19, 2022, 1:57 p.m. UTC | #4 
On 19/10/2022 09:48, Köry Maincent wrote:
> Hello Krzysztof,
> 
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 19/10/2022 09:32, Köry Maincent wrote:
>>> From: Kory Maincent <kory.maincent@bootlin.com>
>>>
>>> Enable the PL110 DRM driver, used by the spear600.
>>>
>>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.  
>>
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
> 
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?

Same question every few months :)

Because otherwise we can drop select in DRM and do not update the
defconfigs.

https://patchwork.kernel.org/project/linux-samsung-soc/patch/20191125125515.30795-1-m.szyprowski@samsung.com/#23021125

https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/

https://lore.kernel.org/all/c5150e83-0e50-3be6-b6bd-bf30fe5e94d1@linaro.org/

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2315d3aea5976acd919d3d3fcf82f752562c25b

Best regards,
Krzysztof
Köry Maincent Oct. 19, 2022, 2:05 p.m. UTC | #5 
Krzysztof

On Wed, 19 Oct 2022 09:57:26 -0400
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 19/10/2022 09:48, Köry Maincent wrote:
> > Hello Krzysztof,
> > 
> > On Wed, 19 Oct 2022 09:38:45 -0400
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >   
> >> On 19/10/2022 09:32, Köry Maincent wrote:  
> >>> From: Kory Maincent <kory.maincent@bootlin.com>
> >>>
> >>> Enable the PL110 DRM driver, used by the spear600.
> >>>
> >>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
> >>>    
> >>
> >> I2C as a user-selectable option should stay. Don't remove such
> >> (user-selectable) top-level options just because something else selected
> >> it.  
> > 
> > As the CONFIG_DRM selects it, the "make savedefconfig" removes it by
> > default. Why keeping something that is already automatically enabled by
> > CONFIG_DRM?  
> 
> Same question every few months :)
> 
> Because otherwise we can drop select in DRM and do not update the
> defconfigs.

Alright, thanks, I will update it in V2.
I will be more careful with savedefconfig for now !

Köry
diff mbox series

Patch

diff --git a/arch/arm/configs/spear6xx_defconfig b/arch/arm/configs/spear6xx_defconfig
index 1cf0621d2154..231cbd2ac536 100644
--- a/arch/arm/configs/spear6xx_defconfig
+++ b/arch/arm/configs/spear6xx_defconfig
@@ -32,7 +32,6 @@  CONFIG_STMMAC_ETH=y
 # CONFIG_LEGACY_PTYS is not set
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
-CONFIG_I2C=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_SPI=y
 CONFIG_SPI_PL022=y
@@ -40,6 +39,8 @@  CONFIG_GPIO_PL061=y
 # CONFIG_HWMON is not set
 CONFIG_WATCHDOG=y
 CONFIG_ARM_SP805_WATCHDOG=y
+CONFIG_DRM=y
+CONFIG_DRM_PL111=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_OHCI_HCD=y