From patchwork Wed Oct 19 09:42:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 5004 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp244289wrs; Wed, 19 Oct 2022 03:32:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7pHsgZp1Shzp+XPNu/C21I8/+QD+a9XnuLcc8f2NyeMPrNUYsLFN5nq2HpdzHmLtvJi4jn X-Received: by 2002:a17:907:968e:b0:78d:d68d:6751 with SMTP id hd14-20020a170907968e00b0078dd68d6751mr6107502ejc.403.1666175562498; Wed, 19 Oct 2022 03:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666175562; cv=none; d=google.com; s=arc-20160816; b=0eLZAyXaBvqvWiK2zroJXz7gx7SIK363polrOEs0jVvSD9sewFm6tSQzuo77dMmSPV 3qZsrxfk2QZwHnP7hnTGiqwX56APN1Ek0a2cgLE2wwl/1HbQn7jsJHksV6f2H+SzYHTH yaBNmHq9ssgm8rA0n5C+9TYtwrCWVQWKqTVmOs0WaEeLlS0bCkQQpbHv1ZuSl2B0MYI/ SokNLLZzPVlVIuJbDD/2SsIZD9L5nCftjjun8y/8dwkw+7J1I+t1d5n1krndsCuWT/dk AZud+SUg0c0hEQ/74YJzNyWk6d2YFJeTZ5hivo1s6aMgS5M4GTblrbEaeg5m6eUOJhBC eoTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8riUL1o6DqM7/kEt5w1zF7rsPtqwVZDnjET4dPTqLNE=; b=bH3zBkUZs3ZvN7ZZreny3mKWyp/izZgerY0OvkPZWLkWH0W2PaaCsNSyxZnkSXcwE6 Aik8EQFC+wJukqNIjh3oKWO+J1LIRS7sxC9Hht3toyqTbHJ19CI8T0xjxHLy+FoB35I4 9ln7diWrZMC5b3Lk81i/lUGTqJr9TWxuyH/d89gCI8JukUyQah+JEchEvNKOvm7qQ2q3 VMKBS/0+FnLODrLmIwfRF65RVConTELI35csr1eDq2qvfXoJfmB5XwF829J3f5x90yHW /soUcIU8K7Qz1mkkTUAP+F60C7zHlpXODThtMUYDdksRD4WJCRjpMH07S8xaMkJc8VqA jlbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FEtnana+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z88-20020a509e61000000b00459dc4e4b7fsi12784130ede.143.2022.10.19.03.32.16; Wed, 19 Oct 2022 03:32:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FEtnana+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbiJSKHK (ORCPT + 99 others); Wed, 19 Oct 2022 06:07:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbiJSKGf (ORCPT ); Wed, 19 Oct 2022 06:06:35 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E89E5E313; Wed, 19 Oct 2022 02:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666172709; x=1697708709; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HCe8PEHgG9sbfAbmIqqIaUbApRLlMQaWbM79cf/MZOY=; b=FEtnana+ULMgR5GUOfCkGClEBcBUHuYnw7Wueg7TDzWQ1dQfRXkIU0k2 eimC6SJBIL0jImdkoQzAKzJW80kHiSroaK2ca9VTcgFiE10dR7YWlrNVH a42Ou56PWjaQpvJEtbXaEcdNsf6z1jnuftjrxS0vDyV/kkxNMBee5qGoa U+SOgdFajsrXZlRl0Njlwyva9Rm7klLMFWpyZSHqpQrrw8sx6bjxwu+3a wOOHv2Abw9RHeWRdMAiSf9oh+2stvSt9xo+FwValtWksjt1i5XAP6xrbi goMXbM/wAVMuoD7lgGnATQJxAGK9NTG1EJYKzoScTCTsmKQQjevyjruOS g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="305097167" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="305097167" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:42:54 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="631584401" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="631584401" Received: from sponnura-mobl1.amr.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.214.35]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:42:52 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 2/2] tty: Cleanup tty buffer align mask Date: Wed, 19 Oct 2022 12:42:40 +0300 Message-Id: <20221019094241.10870-2-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221019094241.10870-1-ilpo.jarvinen@linux.intel.com> References: <20221019094241.10870-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747111706817520688?= X-GMAIL-MSGID: =?utf-8?q?1747111706817520688?= Don't use decimal for mask. Don't use literal for aligning. Signed-off-by: Ilpo Järvinen --- drivers/tty/tty_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index be3431575a19..7a73e8907ef6 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c @@ -21,7 +21,7 @@ #include "tty.h" #define MIN_TTYB_SIZE 256 -#define TTYB_ALIGN_MASK 255 +#define TTYB_ALIGN_MASK 0xff /* * Byte threshold to limit memory consumption for flip buffers. @@ -37,7 +37,7 @@ * logic this must match. */ -#define TTY_BUFFER_PAGE (((PAGE_SIZE - sizeof(struct tty_buffer)) / 2) & ~0xFF) +#define TTY_BUFFER_PAGE (((PAGE_SIZE - sizeof(struct tty_buffer)) / 2) & ~TTYB_ALIGN_MASK) /** * tty_buffer_lock_exclusive - gain exclusive access to buffer