From patchwork Wed Oct 19 09:40:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kang Minchul X-Patchwork-Id: 5014 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp244755wrs; Wed, 19 Oct 2022 03:33:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5S9vpmRQKx4b9jy95HvpzK1Fuo1GVMdog+2ldLB3qWrktN8tBN2WO7EqUomJrumRLxwmEv X-Received: by 2002:a17:906:5a44:b0:78d:4c17:9856 with SMTP id my4-20020a1709065a4400b0078d4c179856mr6161331ejc.477.1666175624899; Wed, 19 Oct 2022 03:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666175624; cv=none; d=google.com; s=arc-20160816; b=SYfgGLLziFs7W5Wlhg4J2gEDaJTBGrlc0fV5wTauqxC14bM2ADHTRM+BwNIRuldepG GFHTScrYutgHtm1cYqBWMcn9eTuHFe2dIZi3rk3gLB4/NifhoWMTgI8r1B03d6v5+V3n bC9PTwrSHpH797GzpZvxweXQOHIgX9QjZW/Vk2JbOrvytTCvDK7ZGF9tKYFO02LnRv27 JsVD2V1jJyF6Dgl16qh1j1t0ututVZTQ1DbX7vPEaGtVoIWk65+Oikw4ucLDNW2OODix JCPRTm6Z8rHThjlctA0CmzE+gP/1zgcHhnhMyFYVzhn11GQ0ReDCYVDwzCGaHNNQonOi YpaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SF1fl++U+j/mY88q9ogCinNcnaen6ZIX+6+t5RwhoIM=; b=Zcm1DobrAczjMLkNBGg0TlOEVNmgfGa5LB2CgFkF8yviMJNtbxwSMHdHIguwAuWRoQ sUEoOG0rUZ40vWriSe8dA2TrGi2PSnW6Wv6FpUNxSXSxg5b+YZcd8WbLYtvPVYAc7nAF 7Kf60VtjpdxuOqQyMfgnnCr1k/QmjHyvUrZJ86BJhzdrvjr6z5Q0JJZTofR8ynOp4/8g OxXQ61/oYAZHpY0Kpv150oMzRWppRKb98llH4Z6vw+solVI0qhMwmJK0a285K9/kk09X 6be6fk4hcSfXELu+hKk441T+ya3xpt3zA8xipdeC+zrrpuxs442H9CuD889aYeW07tNf XVuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DlCGggHW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp28-20020a1709071b1c00b0078e27f2fbe3si12413556ejc.115.2022.10.19.03.33.18; Wed, 19 Oct 2022 03:33:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DlCGggHW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbiJSKLp (ORCPT + 99 others); Wed, 19 Oct 2022 06:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230340AbiJSKL0 (ORCPT ); Wed, 19 Oct 2022 06:11:26 -0400 Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADA9BFE928 for ; Wed, 19 Oct 2022 02:50:54 -0700 (PDT) Received: by mail-vk1-xa2f.google.com with SMTP id v81so8078576vkv.5 for ; Wed, 19 Oct 2022 02:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SF1fl++U+j/mY88q9ogCinNcnaen6ZIX+6+t5RwhoIM=; b=DlCGggHWY+p58GuPoeTXjD2I5F1u7nPQNxrYEXmmluzk6DVlmKUPG1HgCJf41PBdxA XTlinPyNOlWg5/90VLRbwMyA02x8kiJlwLAM/BUKfzvZ6sIkopvKo9BwkKtCbthlcYoH ykoF1P8mElDRzc8CLuqAkABevEBMNTm3FC/53xiZC609OkYpYoSeaukXBcLtykvXBrHx kH+Xqu5+5v/Fq9H+iZfDwsP1smGZwjrPMhgnLskaZuqaYMWgUMxvfD4L5GYv9w6vfzxL ZqcwnG+bMRs1gpEqNIj2sRhaPX4wrOEAhIIKG9wJQ2spQPIjGeXntfu6llgvkNgY1K3O +aXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SF1fl++U+j/mY88q9ogCinNcnaen6ZIX+6+t5RwhoIM=; b=SRUCFTlm0mK6QpvUfbs8R1wvLNsezk1r7ByznajIGck7Bc1qinvimQIUaJL0dvzFEc ugm+AWCSfcpSysyimh5RefBMyl0XawnyfaBX/t9asZjbBPpAJle1h1avd0AYJNygUiGj OeFVgt60Wj4cVm7cnJh/6jYK62bwA30dbzS0wBZRDy20Ny05zrVidXMG2QDIlxjMBHk6 Q+dtnxTcQGuhkshoyha+n0sp8ce0lpDEuWZOxodVlNPk2+rG9wxpLUKBBfRrSGkfbMyU ZUBqqwAU48sL79cpoIXXudap+ZHSOh9Am0ixn6coSLq7wlbmqqZyhkhFqfnyo4hq5/DQ Gs8w== X-Gm-Message-State: ACrzQf2bGvmau7XgLwIId4ohDgOKirLgPpbW7+xE6o6ZfBTpLi2Db5GK 29Y4ywC+ByUDIIbWwiFQuhKK4RzE1SUjKf7o X-Received: by 2002:a17:902:e806:b0:181:ebae:3ec3 with SMTP id u6-20020a170902e80600b00181ebae3ec3mr7399989plg.26.1666172420914; Wed, 19 Oct 2022 02:40:20 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id q59-20020a17090a1b4100b001efa9e83927sm12739970pjq.51.2022.10.19.02.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 02:40:20 -0700 (PDT) From: Kang Minchul To: Greg Kroah-Hartman , Paulo Miguel Almeida Cc: Dan Carpenter , Sidong Yang , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH] staging: pi433: Use div64_u64 instead of do_div Date: Wed, 19 Oct 2022 18:40:15 +0900 Message-Id: <20221019094015.832398-1-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747111772025773365?= X-GMAIL-MSGID: =?utf-8?q?1747111772025773365?= This commit removes warning generated by cocci as follows: do_div() does a 64-by-32 division, please consider using div64_u64 instead. Using div64_u64 instead of do_div can avoid potential truncation. Signed-off-by: Kang Minchul --- drivers/staging/pi433/rf69.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 8c7fab6a46bb..683dd94489f9 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -252,11 +252,11 @@ int rf69_set_deviation(struct spi_device *spi, u32 deviation) // calculat f step f_step = F_OSC * factor; - do_div(f_step, 524288); // 524288 = 2^19 + div64_u64(f_step, 524288); // 524288 = 2^19 // calculate register settings f_reg = deviation * factor; - do_div(f_reg, f_step); + div64_u64(f_reg, f_step); msb = (f_reg & 0xff00) >> 8; lsb = (f_reg & 0xff); @@ -291,7 +291,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 frequency) // calculat f step f_step = F_OSC * factor; - do_div(f_step, 524288); // 524288 = 2^19 + div64_u64(f_step, 524288); // 524288 = 2^19 // check input value f_max = div_u64(f_step * 8388608, factor); @@ -302,7 +302,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 frequency) // calculate reg settings f_reg = frequency * factor; - do_div(f_reg, f_step); + div64_u64(f_reg, f_step); msb = (f_reg & 0xff0000) >> 16; mid = (f_reg & 0xff00) >> 8;