From patchwork Wed Oct 19 09:11:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 5021 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp246058wrs; Wed, 19 Oct 2022 03:37:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4oH1ExT7HixrAn/x7fXbNtZiZCT+KIGrLoHxIJ5Cc+Wl6Ne51yxqVf5BlD1tF103Q4x+K6 X-Received: by 2002:a17:907:3c81:b0:77a:327a:815f with SMTP id gl1-20020a1709073c8100b0077a327a815fmr6241483ejc.422.1666175828144; Wed, 19 Oct 2022 03:37:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666175828; cv=none; d=google.com; s=arc-20160816; b=E/SL0G6lf1hNuGpFcp6r7e4j4WC0MSLMQflG8/lWY0lv9BSuP4d0qHijOSWz9GT3Ux uBhC/+O++Ce2VgJGSMTdE17FR10rWV/7wXa8EW+N5dThXXQmYsP6TI1KtcgcnjwS4JFC Q1ymhNCJoo9bBhrRAHaBX/x8KyP7Ssz7v5pUH29hLRl9ElVKknxEUQePjmq7ROJfZJlg kgYWlTra0oOl8uZnGOGvovNWaLlcQdIt0qu0sLiPYKpKcSJddfKb914ZpJIg7/7f4MpI hhgVN+cwnaAHHkt+EgP6FU1/6YeoadiEsnG3/TYz8SVjnWUvQgIsp4roC//LPWvmJYld sc2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5oiDndZbeMRUjpZfSxUM7uTZnhV+upm9cxIXeDqBYhk=; b=TRfZweyKoHCZS7O/qTwO/e5v0PPVYTtB2Yit1qB+u8YyCJ8D/JNZ75uFANrEtcJ07x 2w4T8NIf2dt5rQem78x3Hh9L4C462wrlI5XK69Jv/SlcJD4AOqMHeRTd69Y2beA2Md+O wGAU67HK2z7Ow/zEFPNAY6hmdYz/P5Bz/A4g3JNlOoR4HWwag0b8XWL3N7yRDVmArLWZ ry38kgLVtOqwvYmWNUfeob1luYYER9pQvTUSFDpxD1CLYa5VhwwGYRzf4nddBUDcxHRd k3lGenWe9Jo/3WFxJtQjRM+MX46+o35W/Qy4oBzh1oRU0VvhZ30YXRjlKppFo6zHYD0o PwAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iSHRQhnc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn16-20020a17090794d000b00730870cb4b6si10942221ejc.621.2022.10.19.03.36.42; Wed, 19 Oct 2022 03:37:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iSHRQhnc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbiJSKcO (ORCPT + 99 others); Wed, 19 Oct 2022 06:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbiJSKbg (ORCPT ); Wed, 19 Oct 2022 06:31:36 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B08DBF01B7; Wed, 19 Oct 2022 03:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666174228; x=1697710228; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Uap1H5nY8QhFUnLKuQGsMA8Ds5ys9SXkfxi++zVNE9A=; b=iSHRQhncCe/alRTg0MGmpt0EZLSKGBYOD6Iwas3YExkNeO/ObPzsBYYe 8xEktxeXw1sOi2bEkh3GxWOtnK5SUj9ARyWQalEz5opgHJKVuehXRHVVB Zj4dDULjmqYIQlcoTBwfI3jgE098YlpoTgK80h632soecMBSPCPOIE57e 2Hz9/j4nREaDPoFEszSH1QADlpSUOk4jgv76MGRBxivfZD+JzYQxY1j+I hXxGKIdg7jhoVLcIHoWIJs6qWKm1mjjTQ2mm5EQlHLAnsMdHUKrczAHck 3nkNFNxJolOBl5jGRevZvW8JuvkiSZ4EBx+Rt/BnivUEsvnKsaFdd4BbM A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="368407296" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="368407296" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:14:29 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="734119270" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="734119270" Received: from sponnura-mobl1.amr.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.214.35]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:14:26 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , "David S. Miller" , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= Subject: [PATCH 37/44] serial: sunsab: Use uart_xmit_advance() Date: Wed, 19 Oct 2022 12:11:44 +0300 Message-Id: <20221019091151.6692-38-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747111985304291333?= X-GMAIL-MSGID: =?utf-8?q?1747111985304291333?= Take advantage of the new uart_xmit_advance() helper. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/sunsab.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sunsab.c b/drivers/tty/serial/sunsab.c index 99608b2a2b74..94db67f21abf 100644 --- a/drivers/tty/serial/sunsab.c +++ b/drivers/tty/serial/sunsab.c @@ -266,8 +266,7 @@ static void transmit_chars(struct uart_sunsab_port *up, for (i = 0; i < up->port.fifosize; i++) { writeb(xmit->buf[xmit->tail], &up->regs->w.xfifo[i]); - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); - up->port.icount.tx++; + uart_xmit_advance(&up->port, 1); if (uart_circ_empty(xmit)) break; } @@ -453,8 +452,7 @@ static void sunsab_start_tx(struct uart_port *port) for (i = 0; i < up->port.fifosize; i++) { writeb(xmit->buf[xmit->tail], &up->regs->w.xfifo[i]); - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); - up->port.icount.tx++; + uart_xmit_advance(&up->port, 1); if (uart_circ_empty(xmit)) break; }