From patchwork Wed Oct 19 09:11:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 4982 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp227155wrs; Wed, 19 Oct 2022 02:47:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5yiZq1VGtcDb2+EpEenJGOwBfhQRmTc35wEA856EiXn7O0tZ/+3o65PGVYikj1BremyE6x X-Received: by 2002:a17:90a:d397:b0:20c:7a28:8834 with SMTP id q23-20020a17090ad39700b0020c7a288834mr44356605pju.153.1666172877789; Wed, 19 Oct 2022 02:47:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666172877; cv=none; d=google.com; s=arc-20160816; b=akO7HXqPIaicblHTuvJHENweXXQbAyLot4cO0ueJsJ/Ru16c/RzAi6czfoCJWQW+JZ iVJbSQxnNr3lUtl943uuk7AcEsCYi1SkQuIAnJXZJg5listWTTIGgeGVX1Ttha4yHKcK vTPkMxulN689wHeRWZNgVu9us9D78VzMqy0UN/EHWhy3SlJzB47d3aiqBV9JqGnuJ2r+ 2IvqnheEGyKf53Fyhw5XRVnpzrcWANJJC+IQy7UB5MJ6OrKLO1gxPG5ib1blnGeI1IWq 8RSJUxJKFEdYFqv/I9Roa2m13HxrT7ltE5/riJ+sdfkDh0LIh9bsD+vgwWK5m1H880+6 Jv6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MWajHwOVXDSV9AyW03mgIBeKq96H7eXpJpY1b4zsvsw=; b=hKpkOowv7bdKVqvkGsuIZCIO2Xr8GKX1IOKQAWQWFyap32he0hhcNifowvX2v23n05 OBXBf0sQGgQUVY9ujewN5oUA4HRto4Jhm+6NiknPcGhsPDGrT5FMD+IQt1DnzPcMH4A2 Gf7xNp1IasHr2NKdHuzINm8C4+IIjQsvx5pHlIw3XJV37LHsErAI9o7tjHutNAVgi2L1 d/Hz9QkI8sHQPmoMP5ZVJoTHkWGgE5z3BGTQ642zT+qnlBGrCJZ1jztV/rfMJ0dMTQPG X0/TKZXVjUjNPkelTetPVkWVYYVzCsXnAVmrQo00z3dipbQtp7di3nfNycXurxit0Azo uszw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NXU1U4yJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb19-20020a056a004c9300b0053b082ebe62si15387715pfb.269.2022.10.19.02.47.43; Wed, 19 Oct 2022 02:47:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NXU1U4yJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234304AbiJSJjv (ORCPT + 99 others); Wed, 19 Oct 2022 05:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234058AbiJSJec (ORCPT ); Wed, 19 Oct 2022 05:34:32 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF6B344CE4; Wed, 19 Oct 2022 02:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666170912; x=1697706912; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VQJoRuNRdeIpnDk2ac87eJh17oqgdcNVue8yLDhtyxs=; b=NXU1U4yJd3rTUR9GE3weNUpfEhpPcLCST84mO4QLdlUt4JvbHQQ0gpz0 2rQ0gPU/kQN9XYJy0kbYB5GPaHOXidIPiUum1kW/sGxFnpFEsoFkB6V7b Rzq2vaoja1cKILnV1zsF68XT7woM0KYZilKj2NUl2F0ZjkVJItFWPRpiI uNETJSmkxFynVTHYBCkASzUNRsOd/hA5w8K0jWjyTcXZuAYDmeht5LYs6 g2a9rwpTpynxIdDiXdA/4uycBkf1Yh45yMWHnA+SHEJZLrxRW7MJDI3hM PdMfbHBRJgeEzI5q98rZvQkCAx3ffekJ93Tuu1uMfeHPe2lzvtb/k+qz6 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="332911284" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="332911284" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:14:16 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="734119215" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="734119215" Received: from sponnura-mobl1.amr.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.214.35]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:14:13 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= Subject: [PATCH 34/44] serial: stm32: Use uart_xmit_advance() Date: Wed, 19 Oct 2022 12:11:41 +0300 Message-Id: <20221019091151.6692-35-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747108891474384168?= X-GMAIL-MSGID: =?utf-8?q?1747108891474384168?= Take advantage of the new uart_xmit_advance() helper. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/stm32-usart.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index dfdbcf092fac..24def72b2565 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -596,8 +596,7 @@ static void stm32_usart_transmit_chars_pio(struct uart_port *port) if (!(readl_relaxed(port->membase + ofs->isr) & USART_SR_TXE)) break; writel_relaxed(xmit->buf[xmit->tail], port->membase + ofs->tdr); - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); - port->icount.tx++; + uart_xmit_advance(port, 1); } /* rely on TXE irq (mask or unmask) for sending remaining data */ @@ -673,8 +672,8 @@ static void stm32_usart_transmit_chars_dma(struct uart_port *port) stm32_usart_set_bits(port, ofs->cr3, USART_CR3_DMAT); - xmit->tail = (xmit->tail + count) & (UART_XMIT_SIZE - 1); - port->icount.tx += count; + uart_xmit_advance(port, count); + return; fallback_err: