From patchwork Wed Oct 19 09:11:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 4908 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp225696wrs; Wed, 19 Oct 2022 02:43:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4K1cD9kbqLElw9eR08tVqSQ5Xc71Oyxz9mj/TdGJv4NAA2pwBc9brhdUmGd8aZqxpSEPZD X-Received: by 2002:a17:906:cc0d:b0:78e:2c06:8e70 with SMTP id ml13-20020a170906cc0d00b0078e2c068e70mr5817676ejb.732.1666172626638; Wed, 19 Oct 2022 02:43:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666172626; cv=none; d=google.com; s=arc-20160816; b=JCuP/Ss8xuEGBnyjH+/fW0vHvts2X9PauN4o8+cg6fQ7ZCJJP+lz2YU8JmgmyCJveM Skt8ZL+zt+MXCiejZHr2SxxCG4IWxctarIsD2Xbhe3D5aLrIDw8l6fsdP3R8X8Lrsd4W BHFtR1yeE3GsyK81mLNIok0EEU5wLsm+AX7cqzprtcsO7gUD0Bz5gdIU+L2mBCzoMUnh xB1G28x06xJmaGNgJE3wgws4rfmdNk+Odgw7YDxH3kSbbZpbv4UqFHyJJ/5jZD8CIw2/ 7LSqffHg8BBG9CXBoz1ge1gT1cn8GK5+nXkFMd2l3TqH2on8asrNJJfdMwHrZAcD7EMz kj0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M8mop3W7fh49XokRxvlG36xgPLBJekck3G40BK258Hg=; b=BTHP1/oW90iANFD30VY0d7lBsYmIeE4f5OWRg39h5m4XMXxa8rUjcDORujDv0JxvYd W62LTN9/fYRe+m+881p8urUMhHBYxdmDKx+KnUYF8cUBp93DAyt/8qUzUKk3/LBmyGBR R+ZcnNzN6U132LVo6elIedvpa07rvwPZxMh4tK8KwobpiA0DhUOf0DYu5HAugg926IBk LLY/JClC5He9Bc8u8jn1HnRe8b4XlaABIKgB+ob/XNfPauqeAx7SX3GLyllKaCFhCI2d hEztQfYouKuixCX5L6nAtfP/YegtY+rweb6VxbPvbtstBIJr6fszTH9hsKTarYSMAgMY RETg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=drsyqGDt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z22-20020a05640240d600b0045d5a712e82si11608920edb.586.2022.10.19.02.43.18; Wed, 19 Oct 2022 02:43:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=drsyqGDt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233933AbiJSJeE (ORCPT + 99 others); Wed, 19 Oct 2022 05:34:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233768AbiJSJ3W (ORCPT ); Wed, 19 Oct 2022 05:29:22 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28C95E5EDC; Wed, 19 Oct 2022 02:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666170790; x=1697706790; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qrCiMXb9nIBi8SbFsqfFGy4xfI400zKingaQZRHYCPU=; b=drsyqGDt9pDa97KmeOUaVYWP76tXlJ0HRQGywpI5WNTF8SJs42z3TLOV j+HsdxuTOuyuXWzgl69zNKT4SKZ/h8QwMTB+noJBu6rrKo5nNNvJoYMwo ZcavpB+CdaTeBEDIYFFkSrDEjaW1VB+SyC3u+xL8yn1LNk6VarqfIvGt5 7K48T+1jBJdiJ2LzxWHRVkkV1im1nGEQQ2073qGBLspslUA68trnvGvdi XtPOc0E4AAj/5wbOucw5e165f1JCJ4Jqv9Xajw48TydzVt4nH96poTtY+ 3kc15XiU+QgXnsnteDxNFDmOPmgXURzLf8IuRlFl8VoNwDXKY/xLbMpTS w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="332910790" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="332910790" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:12:26 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="734118459" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="734118459" Received: from sponnura-mobl1.amr.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.214.35]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:12:24 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-kernel@vger.kernel.org Cc: Andy Shevchenko , =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= Subject: [PATCH 02/44] serial: men_z135_uart: Use uart_xmit_advance() Date: Wed, 19 Oct 2022 12:11:09 +0300 Message-Id: <20221019091151.6692-3-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747108628384529871?= X-GMAIL-MSGID: =?utf-8?q?1747108628384529871?= Take advantage of the new uart_xmit_advance() helper. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/men_z135_uart.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c index 3690f5cf0f43..d2502aaa3e8c 100644 --- a/drivers/tty/serial/men_z135_uart.c +++ b/drivers/tty/serial/men_z135_uart.c @@ -352,11 +352,8 @@ static void men_z135_handle_tx(struct men_z135_port *uart) n = min(n, s); memcpy_toio(port->membase + MEN_Z135_TX_RAM, &xmit->buf[xmit->tail], n); - xmit->tail = (xmit->tail + n) & (UART_XMIT_SIZE - 1); - iowrite32(n & 0x3ff, port->membase + MEN_Z135_TX_CTRL); - - port->icount.tx += n; + uart_xmit_advance(port, n); if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) uart_write_wakeup(port);