From patchwork Wed Oct 19 08:34:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 5034 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp246701wrs; Wed, 19 Oct 2022 03:38:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7vhKcB3NkBSMR0YpJbVKvjukVVP9fLSPJgdYJ0o1GK37Q/qpkpTgEcn5tacuIDZ09H2sqy X-Received: by 2002:a05:6402:28a1:b0:458:81c0:a379 with SMTP id eg33-20020a05640228a100b0045881c0a379mr6755371edb.388.1666175938901; Wed, 19 Oct 2022 03:38:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666175938; cv=none; d=google.com; s=arc-20160816; b=T8NTaMioiLCiMClO77F3JIyTfg+QscSs1zkpjw9Kqod8sZ9AEB+KdwQtq+LSGYKOdI eO639j/BsiJl/QxAgDRRdkmCrd23jJmlEIHM3ae39uINgQy/TRjEjR2Gd7/O5S7WB0bi NXme/Fr3EjPWA+q09i/eh6UlPgS6m6GM+nFFmRXDqn8TVdQ8KtFJpP19zL2TqzevVtUr MFh4YOS68Kak2yxZZRunmEBWjW39ZpOWUg4i8+lwZog227mfDILywVU5tyAI2oMKgXNp 3FsHErhBc5uKJ9R0tKL2kSOmTUvNZoE3fkI6yKXVn+qt92D7ZscMr+mfIQbszF5BDdL0 LK9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VVJEl7cXTe6dk3PEnNNF8Y5iPjGXdngiZi7OT8KdzGo=; b=MoF3XMmNe8i7EF7MhlsQi1hurAANUR3LZnSnbHt4c2/9PtX15CE4cOo9Pw7dMKHyWT I6ll9JyrUky5ye6P8sxqUuXrjoVl7Rr8gGgiFLuoazZW9sFkr4Z1UmlUt3GKrspUKr9r Qv9jQigRY+CHQnhmKBoyRQyvgiGCH62ozAVYi9KFAbanxZ/FTQ3s+1yyZyzCi8i0DNLl HXvLGhKWbq4TydpoMWdTGKGcQVnNQyP7MtOWtRKVDGnbYsN6QhAxtfLcB/cctOY9/YXO gqQv4kQg8rCflh8IB/WXFBJlKfm6ZYHWbQSbnqagjEHwcz7xxsRqSbcrfvdsPI1EBDEZ +r2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1KkITEmO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a1709065d0e00b0078219af8361si13228507ejt.883.2022.10.19.03.38.33; Wed, 19 Oct 2022 03:38:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1KkITEmO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231163AbiJSKhl (ORCPT + 99 others); Wed, 19 Oct 2022 06:37:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231818AbiJSKg6 (ORCPT ); Wed, 19 Oct 2022 06:36:58 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE58F01B; Wed, 19 Oct 2022 03:15:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 60429CE21B3; Wed, 19 Oct 2022 09:13:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E266C433C1; Wed, 19 Oct 2022 09:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666170811; bh=2vttJVL/wGU2aeD9rhWr5CzNN4oH2sKTlJIu2eSZwmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1KkITEmOv1iZFOs1p5SurGBmrFbRt6U4LM15r+l/FKUlS73G8qVTgpF9AM0Dz6B+P uE2lV5DggZiWt9+UR2kheqYIjryejgHDNVwJOMP23BW0HcVxZ5W+LorQWxVabjSrBZ JR2y5V6sLcVK1mZ2NCBc3gS4JHnR8dMCJHkQU6zE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daisuke Matsuda , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.0 796/862] RDMA/rxe: Delete error messages triggered by incoming Read requests Date: Wed, 19 Oct 2022 10:34:43 +0200 Message-Id: <20221019083325.076112879@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747112101207646312?= X-GMAIL-MSGID: =?utf-8?q?1747112101207646312?= From: Daisuke Matsuda [ Upstream commit 2c02249fcbfc066bd33e2a7375c7006d4cb367f6 ] An incoming Read request causes multiple Read responses. If a user MR to copy data from is unavailable or responder cannot send a reply, then the error messages can be printed for each response attempt, resulting in message overflow. Link: https://lore.kernel.org/r/20220829071218.1639065-1-matsuda-daisuke@fujitsu.com Signed-off-by: Daisuke Matsuda Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index b36ec5c4d5e0..7c336db5cb54 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -809,10 +809,8 @@ static enum resp_states read_reply(struct rxe_qp *qp, if (!skb) return RESPST_ERR_RNR; - err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), - payload, RXE_FROM_MR_OBJ); - if (err) - pr_err("Failed copying memory\n"); + rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), + payload, RXE_FROM_MR_OBJ); if (mr) rxe_put(mr); @@ -823,10 +821,8 @@ static enum resp_states read_reply(struct rxe_qp *qp, } err = rxe_xmit_packet(qp, &ack_pkt, skb); - if (err) { - pr_err("Failed sending RDMA reply.\n"); + if (err) return RESPST_ERR_RNR; - } res->read.va += payload; res->read.resid -= payload;