From patchwork Wed Oct 19 08:31:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 4849 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp223827wrs; Wed, 19 Oct 2022 02:38:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Yi/uq2eSTQvXWbhEKVOoCPTIPMtlUaqGRX2gMPoJAGMbQJvMPC/cP9kTMQrbvYlvx7SZo X-Received: by 2002:a63:5a0c:0:b0:46a:fcba:862c with SMTP id o12-20020a635a0c000000b0046afcba862cmr6455734pgb.187.1666172316555; Wed, 19 Oct 2022 02:38:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666172316; cv=none; d=google.com; s=arc-20160816; b=ooMfZ/dKcuQnMaHXCT2hXrJhT0v7GZWNjee2shJDxPL3PFBGYm1U+eCAQoI+at/Gh8 85OPbwiy9wd0yDMKTDli/t4ISfd6loOG43TT2UowUHm7vydjeMCEId5WbfcBzBRmZKxn IFG3gu2Re0n8bxtAHwooeAN2n1yT5LJaUYVLrqrK2GeaJ+Q8Iw/X4K1UNrqowBQN+TqE M337kjQv1LcNyAhmN0+GREzoiXp3D6Jxa2ocmgGdexs22QdNk5YNZMOMBU3SrAkBg2Ij ynnj9KQl5dJGlWAf9Ou1e+/TwcvaSAX32XlnSM/ZG9qXs7dNqCqmgYhtkJZrFWuH7z+Q Vxmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oEHBg8tstcqvKZm1+Zj5Ta3XNIgFJ2gI6vilybXa+hg=; b=0y2+XqB1G3oyZNHmkeOOKOdQMC/Gy8Jmw5wOB90r9rSn5vT4rL1S8vvN7TD552Ts03 bTMMOC3YrBRKJApurCaok+33VyBfcFWkpZuchJEwOWv+/8sTcI/QmYYnkUFO2LdPijk8 hrpCILo/mfEl5yja25aVgAiDxU3EVzhS+9BU0l1+ehNrCU8ZiofuuVX0K3yUwhoA9HP4 E976/6Cb5I0DuuTH4garXC0+lProx/l/Mmfy18H3x8DrQzf6pQ9lOstK4gXTTs9ovJUe yNevWWpTGuhFDB6dKszz5XzFq/cC0mqPUMnqw3CwmUBFOGbAtTKASnwt/fMMDZZGYyPa TCOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=znUUEREc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r134-20020a632b8c000000b0042b30f95f99si18277715pgr.807.2022.10.19.02.38.23; Wed, 19 Oct 2022 02:38:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=znUUEREc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233363AbiJSJUx (ORCPT + 99 others); Wed, 19 Oct 2022 05:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233591AbiJSJTn (ORCPT ); Wed, 19 Oct 2022 05:19:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99B95DD8B4; Wed, 19 Oct 2022 02:08:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BEDF061866; Wed, 19 Oct 2022 09:04:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1109C433D6; Wed, 19 Oct 2022 09:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666170283; bh=fxmU8Yxirtkx6Nn2/a65k3vYjYq5wHv9VIAQWdJ9EaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=znUUEREc5WbdoW/ha47707mKzit4MtH4R3kdZMujkWxf9MgWcTRmEodfSlzBEBuEL EcMUyclBZ9Fdo0kAI8NZFTA+KLJrh6kW2yMMxqzWQ9jHblfRB1vRiUICX3pDM9TN3L 4btzLcRNysZM6PGFuuR/S2rTy11g804yfQNds8Tc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Maxime Ripard , Stefan Wahren , Stephen Boyd , Sasha Levin Subject: [PATCH 6.0 595/862] clk: bcm2835: Make peripheral PLLC critical Date: Wed, 19 Oct 2022 10:31:22 +0200 Message-Id: <20221019083316.264188613@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747108302947831812?= X-GMAIL-MSGID: =?utf-8?q?1747108302947831812?= From: Maxime Ripard [ Upstream commit 6c5422851d8be8c7451e968fd2e6da41b6109e17 ] When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system. It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled. It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash. Reported-by: Noralf Trønnes Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech Reviewed-by: Stefan Wahren Acked-by: Noralf Trønnes Signed-off-by: Stephen Boyd Stable-dep-of: 0b919a372869 ("clk: bcm2835: fix bcm2835_clock_rate_from_divisor declaration") Signed-off-by: Sasha Levin --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 48a1eb9f2d55..19de0e83b65d 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1784,7 +1784,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLC_LOADPER, .hold_mask = CM_PLLC_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), /* * PLLD is the display PLL, used to drive DSI display panels.