From patchwork Wed Oct 19 08:31:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 4924 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp225858wrs; Wed, 19 Oct 2022 02:44:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5mRj2KNIpmRYgcKaZAmB1+XdJ4bpltwGP4TDUBlia+9KHZCXCbKzy6pxF+paqrf2DRb6zU X-Received: by 2002:a17:907:75dc:b0:783:9c71:5e20 with SMTP id jl28-20020a17090775dc00b007839c715e20mr6012062ejc.125.1666172652932; Wed, 19 Oct 2022 02:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666172652; cv=none; d=google.com; s=arc-20160816; b=YiuFrTHy0Tk2kqurIJ/8Ay3mHATPMV6U+Ll+Fo2QP4mp3k14yWAlFGv/ZMC6lWJFWv qrMabBf622DNNP2WNZcninUvT8rY+0L3z/kIxvkqXK2Fpc1gjSSTXF2MVPi9FLboSgEx +XSX30fwLAaVW3lp5u1QBCG7DdAvBOk4WffVEBz1+F2CD7lJbVNe98d4Nr8mDFvP3xWD n3PntemAcQ6wziqxVG7xr8MIgk6RHpo3rva0CKFCwnPu8CellH7rrywBbcaqBfFffKjk 0sjT69Ze+hZLC8hceJ3kFrg0lqVdu+SZvBrILI8IaCiucctDxKjszfxG4E4jNr6sb9PV VTww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DaTEd/xT6UTzO3OgvZc60DTCtjxGPPhX+9N6vYoS20k=; b=FkWebk22XhxmsUgjunWJJ3nu886N2I8IYxN2L8IRU6Z8p0PkbMGhyfe+8p38emjrrZ rXN4r+xWvZO13xUwpFrKN4ynoVfhnkwl8VoMKetfWGfLSEdK2xMozEXMSFuotYAgbnGS LbChzmJnnITY2o6MKJNQfHJzD76W0PHrk/mfizD7yoivTsSX1ejahhsbsKVLhyRGnUeO jHhUqSS+xYNUX9JvB5efUTsbwl+i5mnhTEsMqliD5oOQ2/9B3lSP14GiezK+r6y5OQ4l WroupwLX+5qP7KNIQ9gu1jO7n9cFD7SbCfbnT3ruIFx8gpsOVdLh2FX7lJS70KC9ncFJ P7Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lrl30fVH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw22-20020a1709066a1600b0073d91a38b35si14029855ejc.789.2022.10.19.02.43.36; Wed, 19 Oct 2022 02:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lrl30fVH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233711AbiJSJdk (ORCPT + 99 others); Wed, 19 Oct 2022 05:33:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233756AbiJSJ3T (ORCPT ); Wed, 19 Oct 2022 05:29:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E828EB77A; Wed, 19 Oct 2022 02:13:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7424061847; Wed, 19 Oct 2022 09:03:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A2DDC433D6; Wed, 19 Oct 2022 09:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666170222; bh=TOSu46mciuE/L6gJio2Q140JlgyZxiLGuzWYQlMx65Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lrl30fVHbt9xRvTXna0z9IGBq1T7bAUl6aHIpNoi/QVFqAQE2XzVkyIhHPJbnIoQi Z9o6CfsmlWVKIns9WRR2moWEhprzhbRmfSC+hpCeMrYP0hoZhCIdJ7NH//kPS7Ncfp YOFik7maRyFM6DXQlqVvSS1eOeK/fnHABFWrfeBs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 6.0 574/862] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Wed, 19 Oct 2022 10:31:01 +0200 Message-Id: <20221019083315.333881079@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747108655642740399?= X-GMAIL-MSGID: =?utf-8?q?1747108655642740399?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 5e8c94e008ed..85d070bce0e2 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -77,6 +77,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }