From patchwork Wed Oct 19 08:29:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 4749 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp214581wrs; Wed, 19 Oct 2022 02:13:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM41Ilp+dKHtDP0RJVf5A04Hd7pa4x2f1gUz/FOaK1OvhxgyroE9bkSR32zHoKajquhWeL41 X-Received: by 2002:a17:907:9707:b0:78d:45d1:487e with SMTP id jg7-20020a170907970700b0078d45d1487emr5840524ejc.566.1666170795658; Wed, 19 Oct 2022 02:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666170795; cv=none; d=google.com; s=arc-20160816; b=WdjhsgpJa9ZNOlc5S8IiGv5yUm3w+A4aW+nFlYcjLIHO5L+jTsFZvINCzCc9u3H853 OS7ad4Jcgfh3E+xyVIV9AMpeinMuFsadbG5MuuO8wlhjZrFhRIya6bc4IpPFbpAc74/L p/SMkqfd8FicaNeKtSgnG16ewrjYuPsZUnr6fQ1c3iPVUJWYnmhy8d5+vPoCS3iWgZNH tXRy/fwrjA0OXJFHdwP4tKWg3fqe7zVo8EpUHmNnsfAyY5jVYiL0kDMQ/LEOccohkNj/ DqxIuMf9reaeGOHLojX4vl+Lfm5gn80CAY/KQ25fBtkUU0K74IjUGQymcLkg4lWPQuHf oIVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jdZiBaCeF9mCiki6kMeIA0wm870tuHE/M0LywtC3ZDU=; b=N73qCA/+yREMcd0hMH56RKODlWPD+iGjmel6epgL9f8kiNuB0+0mBpo95aqlTdy9R7 F3niEQwg/X1NGgZ+qD28mMQ1twCX8A55XvCEdjOKos5XtNpxFLEcE2Zg1qE4sGccAUnw kYBAaE0qJAoUpmTlNSQSF6Cdzt5kOQgWBhambwk9l7cz2BZSgZlLKqp2thismoarWTCP B/76hmlWsGgquZ5DYT6AZrnh9ZTujubOsXbg12/wDZiq3BJlvVPDZuAWSM7veJ3nspWD NSiNzjDPJ7G3jh9s+w5wO6xcY9SZ9ndFdqxLdR74XYopbxA5uJJNW9sRNuCI4Y35kdlL uWRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PN11t2Ir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a1709063a1100b0078dcbd7d244si12090958eje.376.2022.10.19.02.12.50; Wed, 19 Oct 2022 02:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PN11t2Ir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232828AbiJSJL3 (ORCPT + 99 others); Wed, 19 Oct 2022 05:11:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232698AbiJSJIx (ORCPT ); Wed, 19 Oct 2022 05:08:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C31232124C; Wed, 19 Oct 2022 02:00:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 196336186A; Wed, 19 Oct 2022 08:59:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B4EDC433D6; Wed, 19 Oct 2022 08:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666169940; bh=JzLGeM6MnEL8NtCa+37sOxVlXwkKAQTWwUnH0CUDFaE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PN11t2IrZSkKqsGSImnrX3SNXe4m0HJhZDQohGpj37xA2C2g45BSIaDWlYSkoC1Au hK8oqcpajz5UHKyHJltWU7BzAcoGpnHihaf3TiB2/kbaH6kd0bznhyIlDmiGuYcWb6 r+7eyUkHe9Mt/HYxwBsphqXAoPEn3dcFScC64E3s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chunfeng Yun , Christophe JAILLET , Sasha Levin Subject: [PATCH 6.0 466/862] usb: common: usb-conn-gpio: Simplify some error message Date: Wed, 19 Oct 2022 10:29:13 +0200 Message-Id: <20221019083310.563809290@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747106708171397089?= X-GMAIL-MSGID: =?utf-8?q?1747106708171397089?= From: Christophe JAILLET [ Upstream commit d80f4ecb95270d0ecd6646aca44f4c180d3140b0 ] dev_err_probe() already prints the error code in a human readable way, so there is no need to duplicate it as a numerical value at the end of the message. Reviewed-by: Chunfeng Yun Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/7505a9dfa1e097070c492d6f6f84afa2a490b040.1659763173.git.christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman Stable-dep-of: b6155eaf6b05 ("usb: common: debug: Check non-standard control requests") Signed-off-by: Sasha Levin --- drivers/usb/common/usb-conn-gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c index b39c9f1c375d..e20874caba36 100644 --- a/drivers/usb/common/usb-conn-gpio.c +++ b/drivers/usb/common/usb-conn-gpio.c @@ -208,10 +208,8 @@ static int usb_conn_probe(struct platform_device *pdev) if (PTR_ERR(info->vbus) == -ENODEV) info->vbus = NULL; - if (IS_ERR(info->vbus)) { - ret = PTR_ERR(info->vbus); - return dev_err_probe(dev, ret, "failed to get vbus :%d\n", ret); - } + if (IS_ERR(info->vbus)) + return dev_err_probe(dev, PTR_ERR(info->vbus), "failed to get vbus\n"); info->role_sw = usb_role_switch_get(dev); if (IS_ERR(info->role_sw))