[6.0,438/862] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry & use correct node name for pmc8280c_lpg node
Commit Message
Greg KH
Oct. 19, 2022, 8:28 a.m. UTC
From: Bhupesh Sharma <bhupesh.sharma@linaro.org> [ Upstream commit 7dac7991408f77b0b33ee5e6b729baa683889277 ] Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. While at it, also remove the unused unit address in the node label. Also, since dt-bindings expect LPG/PWM node name to be "pwm", use correct node name as well, to fix the following error reported by 'make dtbs_check': 'lpg' does not match any of the regexes Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Cc: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20220905070240.1634997-1-bhupesh.sharma@linaro.org Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Wed, Oct 19, 2022 at 10:28:45AM +0200, Greg Kroah-Hartman wrote: > From: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > [ Upstream commit 7dac7991408f77b0b33ee5e6b729baa683889277 ] > > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. > > While at it, also remove the unused unit address in the node > label. > > Also, since dt-bindings expect LPG/PWM node name to be "pwm", > use correct node name as well, to fix the following > error reported by 'make dtbs_check': > > 'lpg' does not match any of the regexes > > Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") Despite the Fixes tag, this is not a bug a fix but rather a cleanup for compliance with the DT schema (for which there are thousands of similar warnings). Please drop. > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Bjorn Andersson <andersson@kernel.org> > Link: https://lore.kernel.org/r/20220905070240.1634997-1-bhupesh.sharma@linaro.org > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > index ae90b97aecb8..24836b6b9bbc 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > @@ -60,9 +60,8 @@ > #interrupt-cells = <2>; > }; > > - pmc8280c_lpg: lpg@e800 { > + pmc8280c_lpg: pwm { > compatible = "qcom,pm8350c-pwm"; > - reg = <0xe800>; > > #address-cells = <1>; > #size-cells = <0>; Johan
On Wed, Oct 19, 2022 at 05:33:09PM +0200, Johan Hovold wrote: > On Wed, Oct 19, 2022 at 10:28:45AM +0200, Greg Kroah-Hartman wrote: > > From: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > > [ Upstream commit 7dac7991408f77b0b33ee5e6b729baa683889277 ] > > > > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover > > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. > > > > While at it, also remove the unused unit address in the node > > label. > > > > Also, since dt-bindings expect LPG/PWM node name to be "pwm", > > use correct node name as well, to fix the following > > error reported by 'make dtbs_check': > > > > 'lpg' does not match any of the regexes > > > > Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") > > Despite the Fixes tag, this is not a bug a fix but rather a cleanup for > compliance with the DT schema (for which there are thousands of similar > warnings). > > Please drop. Now dropped, thanks. greg k-h
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index ae90b97aecb8..24836b6b9bbc 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -60,9 +60,8 @@ #interrupt-cells = <2>; }; - pmc8280c_lpg: lpg@e800 { + pmc8280c_lpg: pwm { compatible = "qcom,pm8350c-pwm"; - reg = <0xe800>; #address-cells = <1>; #size-cells = <0>;