From patchwork Wed Oct 19 08:25:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 5108 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp250892wrs; Wed, 19 Oct 2022 03:50:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4qirAhSumS1kQLGpkglmnzidxLxreEc39rUoL+Wx/3byHWaUeBxXlWuSKwMUCiDV0wWdpT X-Received: by 2002:a50:fe85:0:b0:458:5562:bf1e with SMTP id d5-20020a50fe85000000b004585562bf1emr6747823edt.167.1666176618777; Wed, 19 Oct 2022 03:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666176618; cv=none; d=google.com; s=arc-20160816; b=k+3sZfQs6Bsqekhjv5V4yPX1h0mnB0IhWeUSOjzE+vACl1ut8bBXhPNaiKIRSw65vE OWJkGyi7VL5MByrs4T3tfyo8Hb5qUrab6HtwhK+KYcQCR6nELdpdXgGg2AoReqpDJI00 fnP+aaYdv4sGUPaREtxZksMs9XhRWnqzPa4B8Ny59vNrcVU1JQz9yGyWJnJ+CZ64FH4b QNxMzWHLQsRP2RyaIjTn53YqJ2kd02zQoV9VETFoE0HAEz7ZEYETa318HTRQxtYRPOPn xhsIkCVsGoY40JiL/iRIa/Tf+SvVxV4NOJbaXVaZr2ZrQGOo0FpyKx5xvjtubZkRtpw2 wlZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SPXz+2SK7iEGe/kOieE0OASf5orUj4AsgH4uWoCc/5U=; b=wDjuQPtIiq31JRNk5izHK2LtVrRDP9XWQCcz9PQMT6Kl6wv4BeYio68CjRHWeL08mq kGTx7qxnTM5lWivJ/QqrkHJKNE1uVxDqQXnog6ksfOykrYUBMNcl7L7kI9N9JS35ihDX EtZtsmrROeZFwDZ+shGf1wyfZGFX2jHFYCUMU8uNkviCUSsHUkojRNX2TAJWUmOr/oez IAcd9Ehaux1Xb+D34F54FLQFx6ifV4gmtJ/ojee3fs5igsH7LZh5YpK6ZXjcvtgv2yNo VnfLl5ynlgTqNmAP4WELucc6YCb3g3yTgZFol2WgH7Tt7ZAKQFxM1YrXMMTM+9qxK0Ke VKjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iF42qtVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020a170906260b00b0078d2a99972fsi11444259ejc.316.2022.10.19.03.49.54; Wed, 19 Oct 2022 03:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iF42qtVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232626AbiJSKsf (ORCPT + 99 others); Wed, 19 Oct 2022 06:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233350AbiJSKqk (ORCPT ); Wed, 19 Oct 2022 06:46:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C08311A94B; Wed, 19 Oct 2022 03:21:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C1C25B822E7; Wed, 19 Oct 2022 08:48:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DFB9C433C1; Wed, 19 Oct 2022 08:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666169280; bh=e+Vd7JvFc0fcUes11UDUpyQCNraPicOwdsaoFGchMI0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iF42qtVC6DvH4BKvQfmRFFrA8te46MQxqmBe0VXi4l8guCHruQGa5/gkU3yn1vqkb AhK63lvEOC6x14198wvQq415Y3xpKLbZ/WmKgZtAC74EQ0I18A8CHKWm7gIivIm0Ns PYF+AeSElwXyg3LNij+MEERasKE3S8k/Pkt4CnRg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huisong Li , Sudeep Holla , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.0 219/862] ACPI: PCC: Fix Tx acknowledge in the PCC address space handler Date: Wed, 19 Oct 2022 10:25:06 +0200 Message-Id: <20221019083259.705947570@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747112814322133177?= X-GMAIL-MSGID: =?utf-8?q?1747112814322133177?= From: Huisong Li [ Upstream commit 18729106c26fb97d4c9ae63ba7aba9889a058dc4 ] Currently, mbox_client_txdone() is called from the PCC address space handler and that expects the user the Tx state machine to be controlled by the client which is not the case and the below warning is thrown: | PCCT: Client can't run the TX ticker Let the controller run the state machine and the end of Tx can be acknowledge by calling mbox_chan_txdone() instead. Fixes: 77e2a04745ff ("ACPI: PCC: Implement OperationRegion handler for the PCC Type 3 subtype") Signed-off-by: Huisong Li Reviewed-by: Sudeep Holla Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpi_pcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index 16ba875e3293..ee4ce5ba1fb2 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -121,7 +121,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physical_address addr, } } - mbox_client_txdone(data->pcc_chan->mchan, ret); + mbox_chan_txdone(data->pcc_chan->mchan, ret); memcpy_fromio(value, data->pcc_comm_addr, data->ctx.length);