From patchwork Wed Oct 19 08:21:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 4506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp202681wrs; Wed, 19 Oct 2022 01:41:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4fT8y8oyUkcOMHKSBphSehsHxn7GaRK9aX66gFROSWrqXZL995yh5fGBiKqbI5Rxdd3FCl X-Received: by 2002:a05:6402:4302:b0:45d:c9b4:c007 with SMTP id m2-20020a056402430200b0045dc9b4c007mr6354838edc.328.1666168870585; Wed, 19 Oct 2022 01:41:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666168870; cv=none; d=google.com; s=arc-20160816; b=ZiSc+vp2XqPzR5sV/iOm7a/qQdJACusjMTK5QPg+F2Fi2r99fj4Dm28KxsVU34S4G4 k8gkvBAxhvrS1nATdPG+w7WaMhpfi7rI59hpp8s6EZVZ/cLoF4GACmdHW/Qfon41uJow gGSLS6haRxyKlXdYuE8Qg89q7yGVIDVGLlqUXl91FZylK0Bh4yrGf4qoZSnOpF45/uu8 rfRBdK2chCfV+Q2jLaey594cP+7G3A8q5RdjFTV0jv5JheKHrKDIEzLV+MH3jXAbeJED yRMd+g7sCCT4QeJmWdsZ8+pzpkWw0xPrgs/t+8eewD/+zHkXlufXaRd+1UhpqFdLnXD0 fHVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=++KajkojadZfT3nN3+UFTEoeAn46AyIxE4aBLUBoRjc=; b=UNp2rnU7FviIn0Wn+jGhT7LJxYhNnrc3cyl8m+GlsazsIjWvl3pwP/N2CytqmGoijL nA0m4CJLC3svfmPmdbH0NfLirXuYubcXRVGoNI2KarhNKqT7iVNOXh1GJcVy/Vfl9jL0 HRL87iPyu6Zl/xKazz/LY2dT/TswbIzuKakRLakGha59BNPCCtHt7TwScdp8VyaUTmrZ jRYx46PM/XLQWm9zZDA1GX6ytrddZ/irGwiTr8Ilw60pEEc47/nqucDhTxYH4FE/EQIE 3tJO6ExTmY5MnlMvZisCz7EISRWbOQN/sFU9LztMz4n/hodJG/j/bTqNOPTWc3dOOS8E tgbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Fbqjh4ZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a056402084700b0045d39f946b4si13194448edz.20.2022.10.19.01.40.45; Wed, 19 Oct 2022 01:41:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Fbqjh4ZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230291AbiJSIj6 (ORCPT + 99 others); Wed, 19 Oct 2022 04:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbiJSIjF (ORCPT ); Wed, 19 Oct 2022 04:39:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C98257FE48; Wed, 19 Oct 2022 01:38:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 091F5617E7; Wed, 19 Oct 2022 08:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1F3AC433C1; Wed, 19 Oct 2022 08:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666168716; bh=c3J8aS+0mHc2rC1YOQ+gpl9CPH8bxkvxWZbbf19llkk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fbqjh4ZJtRwZkcB0/d2AfaqSkBCD3jLkBWkp2d5BcN3mbIjSLgfXlsbxUN/5zMx64 WQ/Xv1vhlVAOrt/jolO+PPtf01X/4qPARyU29Zt+RnZQGZ4U1wr2cEaw9CH3+WwZlE 1LzbQW3rU/0WjtLeWFBxBBSk71E76MZspQOilq1w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Callum Osmotherly , Takashi Iwai Subject: [PATCH 6.0 005/862] ALSA: hda/realtek: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Date: Wed, 19 Oct 2022 10:21:32 +0200 Message-Id: <20221019083250.237245212@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747104689819334072?= X-GMAIL-MSGID: =?utf-8?q?1747104689819334072?= From: Callum Osmotherly commit 417b9c51f59734d852e47252476fadc293ad994a upstream. After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Fixes: 1885ff13d4c4 ("ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop") Signed-off-by: Callum Osmotherly Cc: Link: https://lore.kernel.org/r/Yz0uyN1zwZhnyRD6@piranha Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9186,7 +9186,6 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),