diff mbox series

platform/chrome: cros_hps_i2c: make remove callback return void

Message ID 20221018235237.2274969-1-dcallagh@chromium.org
State New
Headers
Series platform/chrome: cros_hps_i2c: make remove callback return void |

Commit Message

Dan Callaghan Oct. 18, 2022, 11:52 p.m. UTC 
  Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed
the return type of the 'remove' callback to void, but this driver was
originally written before that change landed. Update the remove callback
to match.

Fixes: 5f9952548d91 ("platform/chrome: add a driver for HPS")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Callaghan <dcallagh@chromium.org>
---
 drivers/platform/chrome/cros_hps_i2c.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


base-commit: c7e2618e12562ba6f9d230d8ed4257dfa94d2d9d

Comments

patchwork-bot+chrome-platform@kernel.org Oct. 19, 2022, 2 a.m. UTC | #1 
Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Wed, 19 Oct 2022 10:52:37 +1100 you wrote:
> Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed
> the return type of the 'remove' callback to void, but this driver was
> originally written before that change landed. Update the remove callback
> to match.
> 
> Fixes: 5f9952548d91 ("platform/chrome: add a driver for HPS")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Callaghan <dcallagh@chromium.org>
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_hps_i2c: make remove callback return void
    https://git.kernel.org/chrome-platform/c/d8cb88f1541f

You are awesome, thank you!
patchwork-bot+chrome-platform@kernel.org Oct. 19, 2022, 7:20 a.m. UTC | #2 
Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Wed, 19 Oct 2022 10:52:37 +1100 you wrote:
> Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed
> the return type of the 'remove' callback to void, but this driver was
> originally written before that change landed. Update the remove callback
> to match.
> 
> Fixes: 5f9952548d91 ("platform/chrome: add a driver for HPS")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Callaghan <dcallagh@chromium.org>
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_hps_i2c: make remove callback return void
    https://git.kernel.org/chrome-platform/c/d8cb88f1541f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/platform/chrome/cros_hps_i2c.c b/drivers/platform/chrome/cros_hps_i2c.c
index 92da59d94745..62ccb1acb5de 100644
--- a/drivers/platform/chrome/cros_hps_i2c.c
+++ b/drivers/platform/chrome/cros_hps_i2c.c
@@ -95,7 +95,7 @@  static int hps_i2c_probe(struct i2c_client *client)
 	return 0;
 }
 
-static int hps_i2c_remove(struct i2c_client *client)
+static void hps_i2c_remove(struct i2c_client *client)
 {
 	struct hps_drvdata *hps = i2c_get_clientdata(client);
 
@@ -107,8 +107,6 @@  static int hps_i2c_remove(struct i2c_client *client)
 	 * (i.e. powered on).
 	 */
 	hps_set_power(hps, true);
-
-	return 0;
 }
 
 static int hps_suspend(struct device *dev)