From patchwork Tue Oct 18 23:03:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 4360 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp26208wrs; Tue, 18 Oct 2022 16:06:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4EHEe0SRedpqoSxBGoQcB9w993A0q+qqvxo9Z0Uoqz6bcXAgsIxfNwxdVhgbuyU+L9Om1q X-Received: by 2002:a05:6402:254d:b0:45d:3ed3:8aa9 with SMTP id l13-20020a056402254d00b0045d3ed38aa9mr4588100edb.157.1666134394060; Tue, 18 Oct 2022 16:06:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666134394; cv=none; d=google.com; s=arc-20160816; b=EL54nXyympC0SgiQ4h343OqJGqH/Bk07q2j5JhVG4/qHZmyjsw/74lizEeKMlzj7nS Ww69KT5IuxaKjqs5xAd/EzKelKokFa9eIAFz7LugCLPqEjLvf+ivLdaJUx7oJKFxEHcX rGj65tkWA8Q1B9xwr9W267lG104zAk5Ift8JqpEdXlQjgKYXl2aLF/EwtAzKRCjf+yGn lLgp846WNPiX5awjk9Fr+SaiawFdGiSf7nfuj3ry0I2sL0LQnrJzrGf/Yxw1oVJBdkDq i1PIeiKOW2S1mKb9OuRrQ/S2qDCRdFUQfgevmur03lz62dNQFnxSYf1cc8wozyEiwLuw jcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rDE2/66UDa0hDLDqGdcC3HGG8N6jl6s2qDtARs18Pls=; b=VBuPvl0dODxGEo6m56EsoEdoRB6in5S4rj8Tv3MYGcjJc2fLUVMUZhfv5Wg3CnklEj TPu7Z90hZ1cYOeBj0qLSQkpSeIl4ajCogX5t63pGKyzbok0PrFGaofThoQi1H0QW17NK TIUaPdESB07eopyS20YRnXVT4GqSMHtVGrHejBqsE0uI3JhPA7je7zGdCU4XAEyZBUNg IHW7iRTqtLFQ/v6AbFZj9LEsyN9rWiMgKRFkfpvvuctgQAl1w9Qbh+41bW7fjP8SnF7D bNNMu6P437lMrzUE767iGRaayy4O1Gm3LADM5lIBTAV55YCyD42Psagvw8/DV6e0qMw/ lM3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yXgA+qYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht15-20020a170907608f00b00781599eb7dbsi13466766ejc.573.2022.10.18.16.06.09; Tue, 18 Oct 2022 16:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yXgA+qYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbiJRXEI (ORCPT + 99 others); Tue, 18 Oct 2022 19:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbiJRXEC (ORCPT ); Tue, 18 Oct 2022 19:04:02 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6F01BCBAF for ; Tue, 18 Oct 2022 16:03:58 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id 8so9705357qka.1 for ; Tue, 18 Oct 2022 16:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rDE2/66UDa0hDLDqGdcC3HGG8N6jl6s2qDtARs18Pls=; b=yXgA+qYbSAVhoX3vmAKigDAkRu2K24kIHV9Q3YO/fSgj7Dfow/WN4Vq0mpghp9/cF0 zeTrol5i50aU49KgS+3toEMFfReqARWJx5Dm6eMAqhTYgxnwzfGujFd8AH26MqPbKxBz p9K/S+E0rNkFyhW4EadPxbyN6vVw5FnImBQay9Wo15XyDYPlU949LJ52rIemjxMoww0v dtarmNaaf0IZE3qBkqgMwAei49Z0ZLnaLpVJbHSbggYMI+JJlOEPObwqd7Syb2DpfOxy r56qOpkjFGAS6c90LZUf1LxVW0Z6SzzVnBTXmpCEn0zD50/pOKzLt4LCC/y6jJry64i0 jRNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rDE2/66UDa0hDLDqGdcC3HGG8N6jl6s2qDtARs18Pls=; b=jmX1iZKFopgGSIv0PU6l2wjwYAnph+JoPh9Nx32RBY1zSaPzChO+u8d/GQWAit6GAE FWC11fujXfXt+mp9rISWDDMjKbzoVpBpWihZ5QmtHiCmId2WqRkWm7iXBh3oGibqbUEk vN+Bimdc1bcas0iRFl580oWd+Cyag+qyu6sbOnMmfAt/sIOHbpw2n08BNdAP0O49xkhn Pc27x4+u0l53HvqqyuaWDmBtXV8X8/2CPU78Jhbdp9l3fZMtDTV2LNs5JHNkqg1urIWi JGEeGQJPQPyUqLBjgEjG81cqCTZyhaBa6sya6wMVLjqOj8KL5UhfrFedlLZmBm7AGF12 9ggw== X-Gm-Message-State: ACrzQf2OLKDp0HXOQQ3tNk0guhmqpSL9rGNROktI7pcGLicW1Y70yHi5 iIQi7R1vYDT24USGjjPKaVjj6w== X-Received: by 2002:a05:620a:2b85:b0:6ee:cc4a:de6 with SMTP id dz5-20020a05620a2b8500b006eecc4a0de6mr3536822qkb.458.1666134237725; Tue, 18 Oct 2022 16:03:57 -0700 (PDT) Received: from krzk-bin.MSRM (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id 134-20020a370a8c000000b006cbcdc6efedsm3279010qkk.41.2022.10.18.16.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 16:03:57 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Richard Acayan Subject: [PATCH v2 2/5] dmaengine: qcom: gpi: Document preferred SM6350 binding Date: Tue, 18 Oct 2022 19:03:49 -0400 Message-Id: <20221018230352.1238479-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221018230352.1238479-1-krzysztof.kozlowski@linaro.org> References: <20221018230352.1238479-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747068538675287151?= X-GMAIL-MSGID: =?utf-8?q?1747068538675287151?= Devices with ee offset of 0x10000 should rather bind with SM6350 compatible, so the list will not unnecessarily grow for compatible devices. Signed-off-by: Krzysztof Kozlowski Acked-by: Richard Acayan --- drivers/dma/qcom/gpi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index f8e19e6e6117..061add832295 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) } static const struct of_device_id gpi_of_match[] = { - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, /* - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as - * fallback and not need their own entries here. + * Do not grow the list for compatible devices. Instead use + * qcom,sdm845-gpi-dma (for ee_offset = 0x0) or qcom,sm6350-gpi-dma + * (for ee_offset = 0x10000). */ + { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },