From patchwork Tue Oct 18 14:36:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tuo Cao <91tuocao@gmail.com> X-Patchwork-Id: 4205 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp2002552wrs; Tue, 18 Oct 2022 07:55:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6euq+Vk6Twf51w1L2Vy/E3GB5Gd8I665GRQWyAfAk0fZgipIDk9zpOT99/hVE1psEhgaRD X-Received: by 2002:a05:6a00:1487:b0:563:6367:8a17 with SMTP id v7-20020a056a00148700b0056363678a17mr3622711pfu.85.1666104903567; Tue, 18 Oct 2022 07:55:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666104903; cv=none; d=google.com; s=arc-20160816; b=DtTBoOKuaS724JVXsJ2z5QyiBzgY/ooE/7jVhZWHBYxYpuAW5I7qYyJbxtSUWNBWY7 UqqpWCToUNHSNxA2mPC+O2kyCXe4cxJSDYVNFbjvBe3SMQ8G/jG/06fZVxqtHcpl3JtO qoN9xH21GrAxTFnozMtcA1bA/gvnFpsNXOOUBcG6AYJawbzX5RjM0adhsVBU4GvQCOTy c61Jc+u0P92bWhFumU1t/S5ZWsD7tSmsaCLeUkz4IUioQFZSSMsaeJig6bbkqB6ymsLb TE7HZ6KegRchxoWAVCQrYMw9SNMtaKl4+yyQLDFHDh3/vD22UZbFNKInyrC1SbThGn+W RFvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=zwuWy4jARkZiYQhQKKp3kZsxq7qh8bIcksVC/zF6xJY=; b=0NoYmbK0QEjmxRaQclxogmEoXMAcnxFABOkGh6CGxqdI3fuFbhv6WS5NTFUhoT2T+D JxZ0afUFzdcupa4nEZAnVcTby4o1SHA2Bt3Aif69BWJpTd/nYqC44F7vrCNZqOoFMwCc UB090lkluBJZwVtI5pnM5L5IX9OjPkutxURWcM0BmCBHqt3T6gjn4pS9q0bNFi8JqUkf wgCFgF6SrpbzcW63AiTpBr8Y9DHvVbI0DhV0nnTfHI1HsjhNolJLyWTVOCIh4sSNGxCP W3xsmQzq0gaa3miJTOmYVsgEvlbRPB4C4ayCV3pl+CCHkJojSyOUH45EXbMdqR9ZVdos L6Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eM6DqSRM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r2-20020a63ec42000000b0046040a8c039si15628280pgj.122.2022.10.18.07.54.49; Tue, 18 Oct 2022 07:55:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eM6DqSRM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbiJROiC (ORCPT + 99 others); Tue, 18 Oct 2022 10:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbiJROiB (ORCPT ); Tue, 18 Oct 2022 10:38:01 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947F2CA8B6 for ; Tue, 18 Oct 2022 07:37:57 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id x31-20020a17090a38a200b0020d2afec803so14195298pjb.2 for ; Tue, 18 Oct 2022 07:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zwuWy4jARkZiYQhQKKp3kZsxq7qh8bIcksVC/zF6xJY=; b=eM6DqSRMVv1I6J8Rz4Q13ykLhUES0rYe2ZYVOe4gWNOOFdM/+7+opEMdjXhtGxPWjZ bkpiva/nANsSBAd4nBXwf5CJkXPZHwmTP86j6+lVmWxtrTwFUtpjEBWUaQBk7vPcqxG+ /WNRm2BiHWURU4dh5cUAPm1sloxCaP5vAwC2ysF+c3V73d8Kd85G8tfakguKHGjXbCT2 NN/bPmOoeKedMKykOVFqW/7QOoreIvYon+Ktf8REPPEcnQfj4/j3pzg9f+bR/JUxL5Bh Z7OYmQTVl6APm14AWCO7NdZE+i3+PGBOSSNLz3zsolKGxdt1BaXfdKu9hlAsH/C09RpX 3+Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwuWy4jARkZiYQhQKKp3kZsxq7qh8bIcksVC/zF6xJY=; b=JHRbfdcr2g+i7aMgBD+Hv8mDkgcH1ZOTOigiE/Jp6cYFGtlHKr1I8o9pYRCLRyOe94 z02dBgJOYo2Cb56OwUNKFwQ/OrynBHHYcjImYec7hKXZ+NUlHxngs9sbiYWaaPp3Nabn rEQ5/6fbeD1s+lDd3Kl0rSW+lger7QJN1PWLolBlHi4FAEzvCos7B+nXLHiIkPllPKT1 5ZAqWZbrrC9nHSyKLXgdno0XdOkzWJ8lfV0ofvP85alWHO41P+GCyA645IXy16oywwwJ PemoOBLJjbnlpEra/zitWTdljiIoC4yrbbh5UwcksV9mVMkuGiSI409odqUjqwmxdOVt urDQ== X-Gm-Message-State: ACrzQf3m+0XdAIREcu+m1Eo5yWOK0ogZ3bl68W8+0uw80Ef4nw1rHXfB 19lpWUHDORiU8hiEtZNXLQyITUmcQ6JsNw== X-Received: by 2002:a17:90a:c7d3:b0:20a:68a1:85cb with SMTP id gf19-20020a17090ac7d300b0020a68a185cbmr40099316pjb.138.1666103876522; Tue, 18 Oct 2022 07:37:56 -0700 (PDT) Received: from localhost.localdomain ([182.160.5.243]) by smtp.gmail.com with ESMTPSA id b16-20020a170902e95000b0017b264a2d4asm8814839pll.44.2022.10.18.07.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 07:37:56 -0700 (PDT) From: Tuo Cao <91tuocao@gmail.com> To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 91tuocao@gmail.com Subject: [PATCH] mm: folio-compat: fix bug for pagecache_get_page Date: Tue, 18 Oct 2022 22:36:39 +0800 Message-Id: <20221018143639.5099-1-91tuocao@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747037615317817526?= X-GMAIL-MSGID: =?utf-8?q?1747037615317817526?= The folio returned from __filemap_get_folio may be a NULL, it will causes the kernel crash when access folio->page. Signed-off-by: Tuo Cao <91tuocao@gmail.com> --- mm/folio-compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/folio-compat.c b/mm/folio-compat.c index e1e23b4947d7..37ba33135506 100644 --- a/mm/folio-compat.c +++ b/mm/folio-compat.c @@ -108,7 +108,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, struct folio *folio; folio = __filemap_get_folio(mapping, index, fgp_flags, gfp); - if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio)) + if ((fgp_flags & FGP_HEAD) || xa_is_value(folio)) return &folio->page; return folio_file_page(folio, index); }