From patchwork Tue Oct 18 01:24:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 3866 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1727711wrs; Mon, 17 Oct 2022 18:38:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM41rocwQScl3Mz3LYNTEgHbTwaDibk/dIpQKv/FbxiXxiC36DMLGBNE0slWorIZ+wsoLxwN X-Received: by 2002:a17:906:9bf1:b0:78d:f2d7:efbe with SMTP id de49-20020a1709069bf100b0078df2d7efbemr434282ejc.273.1666057122392; Mon, 17 Oct 2022 18:38:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666057122; cv=none; d=google.com; s=arc-20160816; b=cHkaq767fDGip/JHUO7YAYS6ZvROmW6xOfA+m+vjJGfQV/qKVT4UMSTQpnwamdnCLB GsoEFCN90yzHFaqrBAYUCGhK/doL94e3GNOz1I9hjhA2Ji5TxLaH/9QPepu63BHTKYBG kjxMQ4h9TUYsW4b4IblluXxFqiRdMmO+Baik/zEdfYUmCJzAaIHYcyF/ZFw3NVN8hggE EvNirk1+QzDrTAXS2SzJ5mz1b+TXOQ2sPBMN7Hema8v3Odag14DgOPQbwVonnVddp6oV QjikvRQm6DSFvMPTYUXEBJ4TPtBHPLMQyQzF6+M0J7h48MS7Hf+Up+vPK/6gh7tHXyjf d5uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=ovYciI1whbPEvAwrybxeIj715PXaXyCmrdzpvg20q7Y=; b=vNfi7ApNINRlpDixZPitL82ExNf8pP9xaoXVkGaTDckmzGHmX7kYtFqvfH1Fm/JfoQ 2TiqkVFUc7iZIhJ9nBPdNTvplXo38v6oYUL8CoATng9ALOHeyd8pOFld1tpswPsZsyLP J7WcBO2NG8zI0yZceGv2XjYhQMAvkHwrMMLLMc2nde/bAQwPEqW06NqyjGDBwpxpZSHk wIDQSVfG9Ugf170HX7NKzbM1bljjUuUXzF9vCTGDPrWWUJr2cenFN+aH2zBkfdkI1FTV ENf8h8rv48GmruhtX/mpFyMd5MSUqNNr26oA1N5b1jZSGnwCbBTZlHKaBXSsyS6kKqhr uF0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=QJl5Pt1y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rl21-20020a170907217500b00779a07b4e90si8305052ejb.711.2022.10.17.18.38.18; Mon, 17 Oct 2022 18:38:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=QJl5Pt1y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbiJRBYu (ORCPT + 99 others); Mon, 17 Oct 2022 21:24:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbiJRBYq (ORCPT ); Mon, 17 Oct 2022 21:24:46 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DCBB1C12A; Mon, 17 Oct 2022 18:24:41 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Mrx3l4V5xz4xDn; Tue, 18 Oct 2022 12:24:35 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1666056276; bh=ovYciI1whbPEvAwrybxeIj715PXaXyCmrdzpvg20q7Y=; h=Date:From:To:Cc:Subject:From; b=QJl5Pt1yq09OlrmigUuP3uLeXKhOeQg7n3veUmmuzz0cmXVeoRZ+GbdbntWOpteYz 93/bPm9hciuMsWNuOalTkxcUnQieTa/VltqDV4ruCELWnnJoukjIX0i0dk9G86p7Fp bhuAhNu9sQcBlK8TyW0YGGUnKzQs1ObgWGTvcE4SyhYEFwESjFbQidDT9SxLfMsf17 fwBNlWVlzG1t+S+tm1AsxBsOeyxtH50ij8X1KowVy0n5XhoB5T29AQUzTIW55KiiPR tjAUZKMfP/BtSzKRwQWAvKCZ+VH5Au/67h0c7sPhwxCDMGP3z6sspZ5ILL+TRzXM0O SotR7KgRL9Cog== Date: Tue, 18 Oct 2022 12:24:30 +1100 From: Stephen Rothwell To: Andrew Morton Cc: Sergey Shtylyov , Linux Kernel Mailing List , Linux Next Mailing List Subject: linux-next: build failure after merge of the mm tree Message-ID: <20221018122430.44a47456@canb.auug.org.au> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746987513443541608?= X-GMAIL-MSGID: =?utf-8?q?1746987513443541608?= Hi all, After merging the mm tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/kernel/ptrace/ptrace-view.c: In function 'gpr32_set_common': arch/powerpc/kernel/ptrace/ptrace-view.c:709:16: error: void value not ignored as it ought to be 709 | return user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 710 | (PT_TRAP + 1) * sizeof(reg), -1); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Caused by commit 1afca3ae915b ("regset: make user_regset_copyin_ignore() *void*") after commit 8541413ac862 ("powerpc: ptrace: user_regset_copyin_ignore() always returns 0") missed one call site. I have applied the following patch for today. From: Stephen Rothwell Date: Tue, 18 Oct 2022 12:19:20 +1100 Subject: [PATCH] fix up for "powerpc: ptrace: user_regset_copyin_ignore() always returns 0" Signed-off-by: Stephen Rothwell --- arch/powerpc/kernel/ptrace/ptrace-view.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ptrace/ptrace-view.c b/arch/powerpc/kernel/ptrace/ptrace-view.c index ca0bf8da48fd..2087a785f05f 100644 --- a/arch/powerpc/kernel/ptrace/ptrace-view.c +++ b/arch/powerpc/kernel/ptrace/ptrace-view.c @@ -706,8 +706,9 @@ int gpr32_set_common(struct task_struct *target, ubuf = u; pos *= sizeof(reg); count *= sizeof(reg); - return user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - (PT_TRAP + 1) * sizeof(reg), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + (PT_TRAP + 1) * sizeof(reg), -1); + return 0; Efault: user_read_access_end();