Message ID | 20221018023732.never.700-kees@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1746302wrs; Mon, 17 Oct 2022 19:49:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM42zF6h9rXwGugSBCmSqegn7WvlWphJ2JsgeAR9snzuPK6FayYTOm7fB/FADqcOTBk8bGZx X-Received: by 2002:a17:907:86a2:b0:791:910e:cce4 with SMTP id qa34-20020a17090786a200b00791910ecce4mr621824ejc.36.1666061398595; Mon, 17 Oct 2022 19:49:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666061398; cv=none; d=google.com; s=arc-20160816; b=lN0xf4/IV3KFgdg8Ob9g8SZ9kDHGhTnYjiC/35fntIMsRqS4Y1Em9LXz3k02hFCWZT uhrvquYkMlqeRAcin/GbzGL4VTZzCwbuK7/aXnAEMugM0pdVjPAjcIkzJkhrBg5HgGdm wYwWDPV+nUFKUE3e+qq3HycNmVwpmXNxG7Fq7XJNf7nx24Iz3FpXty4GVGEpNRfJXpWX Z75nPfuA9It+9B/GAgLvvCNKUaKt3lrktyAKiNuuNdvSdNLIDUOYgJ4GBmgyW41FmwUr 4M1oowv3/N7dIi4BO2ytvyR0KFDyimq1GSZSWV4pCHt36gKQ3TneGlNzJxiOkHQYR8w3 VTsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Z/sbw9esP61gV6/BLjaGWBnk+miYGbzeL/QwROnEOEk=; b=xSRBYVnToVp0N8pmTgIMYdaU6abtm4TDBHLR5Zs8qUuuWQSouRXHHQOX2yemI7u+8v cxxAWv1AgusAqMkEDyyYzuluNK8ls7r92+UXDwhN1q0ESmRAby+9MPYZe0RpN5s73/9T 2CtCIrO0scfO1LTXt/QJ73TVQnfenaz8CCJoFDGkw4bI0h9AUkAtfrdQRRqwB7zQyUOx bu53n/v32I8YzpysCPn+fkLpVGGipKOOai/gtNhqisPQWTDsTrIdAZ42qG+ZSXVI6DUT KbGIxVBKGMCPPUM3bSNWTfKhw+qWQ2WrImQZNO40t7tK/MwCCN666gFetUhI4go6lasj N1kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=H2b63KJV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10-20020a0564021e8a00b0045d29efdb5esi10852018edf.381.2022.10.17.19.49.33; Mon, 17 Oct 2022 19:49:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=H2b63KJV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbiJRCiH (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Mon, 17 Oct 2022 22:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbiJRCiG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Oct 2022 22:38:06 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 157A99410D for <linux-kernel@vger.kernel.org>; Mon, 17 Oct 2022 19:38:04 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id fw14so12690041pjb.3 for <linux-kernel@vger.kernel.org>; Mon, 17 Oct 2022 19:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z/sbw9esP61gV6/BLjaGWBnk+miYGbzeL/QwROnEOEk=; b=H2b63KJVBO2GdMY0nV/dRf6TlFnJ9QK+L5IU7T5QQXV42NprTy4I0+Hy0Pf735/iXm 3lx/MrbJ0PvxxE1zwSSXG6I4SG/bhHsWeltVfRw3pEPGkm6o5LHtvIygegVL/ABhfNkG VFoyQeZYn8eVRg5UyTUrqWgY/up6MImhm2A28= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z/sbw9esP61gV6/BLjaGWBnk+miYGbzeL/QwROnEOEk=; b=AY5LHWrjPGmpG1emV/J/GC+x4wNaGtROb0nrVBXtFGJ54oGiXmKxcga+LVqeWrTIKp CINymoXcs0sgNAHmtgNo0I8DqasR3P48rGaIK9CkDcD5dpYp0XThZ1ujqi2HcK8cRxub RE96i9rlfNpB/3HWVmo7fpTbaKqv3pe8Va2WFCIseVaN9wRL0WPq3fzld2pyEzoa4J4n GKX4Uernm2BgrIeFQa/01ZYBguN+hFPgDMXOmedWLGHd1NV+NlQTBq6KgirYqtDAxC/T BWwutbmYG805vZ8+lNe5/cIvm+maKj6A7FY9z9u2I4HiJ/HLVpu7qPeQN7mWTcTgauVh X2Hg== X-Gm-Message-State: ACrzQf1P+WxeEhHGpM3dQt/Xf49IEYIYgp+Enijx1pD6gJ9yKZzePeCe 2FXOBtED3yYCBgWKO0N1dHzFjA== X-Received: by 2002:a17:903:11c4:b0:178:634b:1485 with SMTP id q4-20020a17090311c400b00178634b1485mr715059plh.142.1666060683550; Mon, 17 Oct 2022 19:38:03 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p24-20020a170902a41800b00172b87d97cbsm7315559plq.67.2022.10.17.19.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 19:38:02 -0700 (PDT) From: Kees Cook <keescook@chromium.org> To: Simon Kelley <simon@thekelleys.org.uk> Cc: Kees Cook <keescook@chromium.org>, Kalle Valo <kvalo@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH][next] atmel: Fix atmel_private_handler array size Date: Mon, 17 Oct 2022 19:37:59 -0700 Message-Id: <20221018023732.never.700-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1211; h=from:subject:message-id; bh=Dxza05rOmp3v/aLKDNxxdoNSiFdbo0KfFIwpTTS9BCk=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBjThGHNro1AgkFkolg4wYwZle8Iky3GKlCqcc25/rt uZHSEsmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCY04RhwAKCRCJcvTf3G3AJpZLEA CFUjDExOqbpd2QqGOnokVzYUb9oUUeGMozp2aB0M0LWltq2+sESFlbav9rDITqdSV4an+tRFToGfmL 11+p3ENB1hcZVYN7beLUiiMjBEmU+wQa0/aO8XWS6PDLV+HX1YZaqLCKjE8B0SWD3EGvHXGNWQgBVQ 6j9QtQfWuVq8hE9fsN+lxUshnVUhTJruaV71sPXTyS4uMKeH8FJpb5CiuIDSVSGyu7opBEJRK0AQZk LRjG0PbadvFMM8q+V04WGy9sqIhs13rAOeBFREysnBG3n/tmHhJ9/C9X4BHRH+zVKfDy4xgvCedl57 2VXVizkyBXsbRPBhVO4qWSyyefCIBPVKzTKXVTX5qYQM3r7lzg/zcA3frKW/sUDdZKpHPgdVpzproJ FZS3QRO/zyXQck8HFyi+OWYDOhE/Xl710sh1yRnYMItWOQYMprMaUZyHsRYAG5w8l3IJvrQ+6daOes UqjLO+Ak74KEgnc2e3ZCXgEBlgIROxyk0pqtxd2zjwUDd4mjp+jl3Nh8iqnTK53z/MA8kPPCj7fXQN wQ6YVZkXlO++4qetIMNVa0yHu0IFJf1Qpg7oi6jMixyGhyChjQRGsCC+e6hOsnbzmnzMyyE7693fPI f2RZJoA7CFsMmZl2uRS3NHVSyM/sv1v3hZyNb6/9cCEUPtNgzcy9B4olDoRg== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746991997552869553?= X-GMAIL-MSGID: =?utf-8?q?1746991997552869553?= |
Series |
[next] atmel: Fix atmel_private_handler array size
|
|
Commit Message
Kees Cook
Oct. 18, 2022, 2:37 a.m. UTC
Fix the atmel_private_handler to correctly sized (1 element) again. (I
should have checked the data segment for differences.) This had no
behavioral impact (no private callbacks), but it made a very large
zero-filled array.
Cc: Simon Kelley <simon@thekelleys.org.uk>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Fixes: 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/wireless/atmel/atmel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Kees Cook <keescook@chromium.org> wrote: > Fix the atmel_private_handler to correctly sized (1 element) again. (I > should have checked the data segment for differences.) This had no > behavioral impact (no private callbacks), but it made a very large > zero-filled array. > > Cc: Simon Kelley <simon@thekelleys.org.uk> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Fixes: 8af9d4068e86 ("wifi: atmel: Avoid clashing function prototypes") > Signed-off-by: Kees Cook <keescook@chromium.org> Patch applied to wireless-next.git, thanks. 8b860466b137 wifi: atmel: Fix atmel_private_handler array size
diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c index ed430b91e2aa..7c2d1c588156 100644 --- a/drivers/net/wireless/atmel/atmel.c +++ b/drivers/net/wireless/atmel/atmel.c @@ -2570,7 +2570,7 @@ static const iw_handler atmel_handler[] = static const iw_handler atmel_private_handler[] = { - IW_HANDLER(SIOCIWFIRSTPRIV, NULL), + NULL, /* SIOCIWFIRSTPRIV */ }; struct atmel_priv_ioctl {