From patchwork Mon Oct 17 23:57:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lino Sanfilippo X-Patchwork-Id: 3850 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1697976wrs; Mon, 17 Oct 2022 17:04:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7AZBcdTCe8YFNGZtoR2QQ8T2wcw750/YIRkGP46IlOnqQz66C9l9JvGrXlZ/v+35lMjHvT X-Received: by 2002:a05:6402:249f:b0:453:eb1b:1f8b with SMTP id q31-20020a056402249f00b00453eb1b1f8bmr176203eda.235.1666051445796; Mon, 17 Oct 2022 17:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666051445; cv=none; d=google.com; s=arc-20160816; b=CBBBpg28f02f0aEKZWu9NRM9cK6zB2JeImwJTZ6eR/PA68r90nC9Oe71qFp/PdfT6Z MItAHRiJAJ0DVj58dOYwLqTMKArJKMAPH0i5n654HrCKhAlWeiwThjUSUe2rvQH8Q70K S9N4gCZJToZdsHvzZfCtCZ8teSK4WQGOhBk+jASoTc5XyUgGEScJfbQcRCZ/ImlobjHK NCQ0KX1edevi69959hJAHLLOQZ1VWP2ZSQK3rM3vulXQSSpE4G4gmIJUOUOA/GaTEh+G JlTawykLMeDR8nvXPvlC9QcCuv72PAPF3J/Km2EaHLV85vSVolwfr54cCqz1N28eCaKD 5Mhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1jiHlANZ8thD5aPn63BXGYT+VamFBFNIAjBcdG+2s2o=; b=u1qTzyPMydobIryW+E1SvOAtF56sqCWRiQlqpM1MSQaxs+mzWgVrWzfPnhl1iEMsQB 3CFTc+cKldsD+nZg8ddttBA7nDMjyPpBBnG5VWe0YBmpYj0QVneTZdjroVibiiRzzU0j 7C6Zm5YyafFw5/3G9gvRgRPYlYF9BhjX5Bazhvzjd5fR+GECa++t0WHkXSQ/i3h9de9e Rafmyp1gUs6q3633DzIUxr56T2pUltE1rVP6sYlZQVpW/flmZQJHNSr3SdJyV/wHLupp rMsuB9npp9K4TechuedGV6qOEMNMrrikyFVAkUtG+pNxYrzthISge6gDHlePYPzQ8C0W K5Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=WfOSUaFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l23-20020a170907915700b0078dec48d442si8482038ejs.680.2022.10.17.17.03.20; Mon, 17 Oct 2022 17:04:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=WfOSUaFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbiJQX6m (ORCPT + 99 others); Mon, 17 Oct 2022 19:58:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbiJQX6S (ORCPT ); Mon, 17 Oct 2022 19:58:18 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 807D07E320; Mon, 17 Oct 2022 16:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1666051071; bh=1jiHlANZ8thD5aPn63BXGYT+VamFBFNIAjBcdG+2s2o=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=WfOSUaFoPW6HJeqbKH+NcSgdPAX0B5ef9lmxQeZCm5eQ+sWUG/h3zZ4BlUZ0KeB3L kON0QSj2zBrS+jNnsuLuQTr0/3NG+Y9SSUVUyhz2PFmGzw8wORNnT+ynp+UsV9TMgx v2nDioMQ/Q1N8I2dE4d8JIS02DjoW/0SEI+NvxP0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from Venus.speedport.ip ([84.162.5.241]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrhUK-1pVj2245BM-00newU; Tue, 18 Oct 2022 01:57:51 +0200 From: Lino Sanfilippo To: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca Cc: stefanb@linux.vnet.ibm.com, linux@mniewoehner.de, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, jandryuk@gmail.com, pmenzel@molgen.mpg.de, l.sanfilippo@kunbus.com, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com Subject: [PATCH v8 02/11] tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register Date: Tue, 18 Oct 2022 01:57:23 +0200 Message-Id: <20221017235732.10145-3-LinoSanfilippo@gmx.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20221017235732.10145-1-LinoSanfilippo@gmx.de> References: <20221017235732.10145-1-LinoSanfilippo@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:whnPCRKszgC0VgfRk1iaMt3PYAXQaO9DbMnke0FD70ejHgdIZYz FW/+L6Nx4I6sLOM/msmQC4djx9ELQ+m18UrEng6kHRW7mw17Qaibyts6KutKT0BhfxYH+Uc L5af/A0V5731fnhpzS1NHJHtlCThZ0D6d1QcWUl/jRxL31Hms7DGOFldgxd+htzPZeTIrWM No9LCspdPnw2jXliLZInA== X-UI-Out-Filterresults: notjunk:1;V03:K0:rm9hQAolfWY=:AmHIBZamZBq/hhplD7Btke 2DoMix2mAEavR3w14Jtm9aNsIWhRJCpVK+hnveXnRd52Ixa2ZX10mv39/shArTBy9TQyJEUGz 7/gtHpfqmTV1pe94P9k/URq2ZWf+CxX4ZAZaiSuoZAGofLIMq5m1fJOUfQwMaWPlE3DCkYToI FL0CQ642K9h5mkfBlmy6GdyN1HIT09FkQy7GYx7RCMiVREx7KFRS6YWotUOfSRUkHDqgUUVr9 ZvwV5lmVZR2j2sqioiAeEoRv7y7f9p9BxjywIgWEz+itmc5Kek9QBC4fjhCzUGHxpLfnwvF0w AJq0TYSFpn/mewbi5M7W13RQK1UfHUQ7s3VqGqAdWOSji/I78jATelWLSHi0ajB1taW+QT5pN oyCSCLwL/9QMQHlxsJnJISC7208RqPqn3hBGHT5IOEPGeyi21aTaQecWfZlQDB1TmmQpPPt1j 1XK4HP+vVW2/d6FB/yxX/dmK9u4n9YneQic5RwwQYJ7HG9GT5VfrNT2NFfO2uqxCWeii1eLRM aWkdw1e5s+qf6Q66ZmyyBQ9eNuob/D7P7BKbBQTT+78Hi+b9wwUJQvKCZxKELKr7uSLt9jalk MI4njFeWEjZPgMF4p7PCZmY+hVnYq4zUMLK0XsCq2VhOQlhoh8o0bKeUkvaLB/As9Qp00UE8/ gR35AP+CuF3YopqVgmc1iSVb7IFQFfrJVeHfgCbUNJj/28YNsD6BZHxzuQWfsRTnnmMpe2Hwd wkQ4okUDfK5FCRbRj0Biq17luNv0D8UQA8OX3uhWdwzIxmKBVpl+hdSvMHQA2hYjXiAB1Yi8n WOhM2+eoz8VZX6wIaHQXGCYNs1sHk4FcQ9X6HvEaeSJaHQaTNjcxF8pMCWbHT20u10AmVU5LJ 12NQLB2jk09kkrjaDyINJuQP48OPgA7Jv7NL7YMls1kdut2rg5S/jPqaTpE5yhemfJIE6V2lc 5qKfzqBgFzvz4DxHapuEg0jIL0vGrBqqgO55LwYXo1P0bY7nWIjvxf0MLENepRDmmm3jZFPXN E0NqQpMyW+Va/88Esuq8ZjVG8lTkI0u84ZKZzpUagh5QbBG1bPBorO3H1071M01kBX6OUDok2 JWgQ/B0ZXg9VjR2ocLU66+3dYQbkIaQtFroJnXsVinCmQ7r638tUA/6DUf8PcAtLN1GeXfEYx ps7/ro2SXh68CZhuKGE0DGpH/DcdtaePKa8nRNeehVvfX8c+bCg6o8RlDtWY7/yAMPWomdCD5 H0DszsuFqkZrSz2SCc2KaUYPQTrkrtRz0tka6xLs3O5EhYZV40eM4ZlRLZDDG/eswGEfYyYsF mda2pkEOZ/biKe+aXd6mRKuYMB/CHNAXzYcK6f8A1eaR1ja6jWxu8VmYPHSRBWYZ61mG73H+S tFZrXPOZqN8/oHPtd0zjetF8buuUOnnsodwj9kvo5Lzl7/OQyEWqIo4skQfH1z0tNDDIt5bcj UAqK5lIa/lJKbkEzTzhqrVGcbx//5pLCK1DL8/ILORwOA6pny0LYtpOahjH/9QK4HWsEtc8SE iV29t0sjcJ0tpTnpsV55iAvdsNv/0ciNuyL3MUctNmor6 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746981561220006607?= X-GMAIL-MSGID: =?utf-8?q?1746981561220006607?= From: Lino Sanfilippo In disable_interrupts() the TPM_GLOBAL_INT_ENABLE bit is unset in the TPM_INT_ENABLE register to shut the interrupts off. However modifying the register is only possible with a held locality. So claim the locality before disable_interrupts() is called. Signed-off-by: Lino Sanfilippo Reviewed-by: Jarkko Sakkinen Tested-by: Michael Niewöhner --- drivers/char/tpm/tpm_tis_core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index c0008efb95dc..d2c9c9d76893 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -1098,7 +1098,11 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, dev_err(&chip->dev, FW_BUG "TPM interrupt not working, polling instead\n"); + rc = request_locality(chip, 0); + if (rc < 0) + goto out_err; disable_interrupts(chip); + release_locality(chip, 0); } } else { tpm_tis_probe_irq(chip, intmask);